* [PATCH] iputils: arping fails to set correct broadcast address
@ 2010-08-13 9:44 Jesper Dangaard Brouer
2010-09-16 8:28 ` YOSHIFUJI Hideaki
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2010-08-13 9:44 UTC (permalink / raw)
To: YOSHIFUJI Hideaki; +Cc: netdev, 585591, Noah Meyerhans, Paul Martin, hawk
From: Paul Martin <pm@debian.org>
There seems to have been introduced a bug in iputils release s20100418.
This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
(git commit fe342ca3148)
The regression is caused by commit 56018bf1b3
arping: Support link-layer type with larger link-layer address.
As reported by: Paul Martin <pm@debian.org> in Debian bugreport #585591.
There's a logic error in the function that parses the interface's
broadcast address, causing it not to fill the broadcast address array
correctly.
Please apply.
Reported-by: Paul Martin <pm@debian.org>
Tested-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
arping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arping.c b/arping.c
index 9bd6927..2613a12 100644
--- a/arping.c
+++ b/arping.c
@@ -336,7 +336,7 @@ void set_device_broadcast(char *device, unsigned char *ba, size_t balen)
}
for (p = ba, ch = 0; p < ba + balen; p++, ch += 3)
- *p++ = strtoul(brdcast->value + ch * 3, NULL, 16);
+ *p = strtoul(brdcast->value + ch, NULL, 16);
return;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iputils: arping fails to set correct broadcast address
2010-08-13 9:44 [PATCH] iputils: arping fails to set correct broadcast address Jesper Dangaard Brouer
@ 2010-09-16 8:28 ` YOSHIFUJI Hideaki
0 siblings, 0 replies; 2+ messages in thread
From: YOSHIFUJI Hideaki @ 2010-09-16 8:28 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: netdev, 585591, Noah Meyerhans, Paul Martin
Hello.
(4:59), Jesper Dangaard Brouer wrote:
>
> From: Paul Martin<pm@debian.org>
>
> There seems to have been introduced a bug in iputils release s20100418.
>
> This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
> (git commit fe342ca3148)
>
> The regression is caused by commit 56018bf1b3
> arping: Support link-layer type with larger link-layer address.
>
> As reported by: Paul Martin<pm@debian.org> in Debian bugreport #585591.
>
> There's a logic error in the function that parses the interface's
> broadcast address, causing it not to fill the broadcast address array
> correctly.
>
> Please apply.
>
> Reported-by: Paul Martin<pm@debian.org>
> Tested-by: Jesper Dangaard Brouer<hawk@comx.dk>
> Signed-off-by: Jesper Dangaard Brouer<hawk@comx.dk>
Applied. Thank you very much!
--yoshfuji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-16 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-13 9:44 [PATCH] iputils: arping fails to set correct broadcast address Jesper Dangaard Brouer
2010-09-16 8:28 ` YOSHIFUJI Hideaki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.