* [PATCH] [fs/9p] Remove the redundant rsize calculation in v9fs_file_write()
@ 2010-08-17 17:20 Venkateswararao Jujjuri (JV)
2010-08-23 16:15 ` [V9fs-developer] " Eric Van Hensbergen
0 siblings, 1 reply; 2+ messages in thread
From: Venkateswararao Jujjuri (JV) @ 2010-08-17 17:20 UTC (permalink / raw)
To: v9fs-developer
Cc: linux-fsdevel, Venkateswararao Jujjuri (JV), Badari Pulavarty
The same calculation is done in p9_client_write().
Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
---
fs/9p/vfs_file.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index e97c92b..2695491 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -235,11 +235,8 @@ v9fs_file_write(struct file *filp, const char __user * data,
rsize = fid->iounit ? fid->iounit : clnt->msize - P9_IOHDRSZ;
do {
- if (count < rsize)
- rsize = count;
-
n = p9_client_write(fid, NULL, data+total, origin+total,
- rsize);
+ count);
if (n <= 0)
break;
count -= n;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [V9fs-developer] [PATCH] [fs/9p] Remove the redundant rsize calculation in v9fs_file_write()
2010-08-17 17:20 [PATCH] [fs/9p] Remove the redundant rsize calculation in v9fs_file_write() Venkateswararao Jujjuri (JV)
@ 2010-08-23 16:15 ` Eric Van Hensbergen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Van Hensbergen @ 2010-08-23 16:15 UTC (permalink / raw)
To: Venkateswararao Jujjuri (JV)
Cc: v9fs-developer, linux-fsdevel, Badari Pulavarty
If we are eliminating the check, we should just eliminate the
calculation higher up (and the rsize variable) from this function.
Please resubmit with more extensive cleanup. Thanks.
-eric
On Tue, Aug 17, 2010 at 12:20 PM, Venkateswararao Jujjuri (JV)
<jvrao@linux.vnet.ibm.com> wrote:
> The same calculation is done in p9_client_write().
>
> Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
> ---
> fs/9p/vfs_file.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index e97c92b..2695491 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -235,11 +235,8 @@ v9fs_file_write(struct file *filp, const char __user * data,
> rsize = fid->iounit ? fid->iounit : clnt->msize - P9_IOHDRSZ;
>
> do {
> - if (count < rsize)
> - rsize = count;
> -
> n = p9_client_write(fid, NULL, data+total, origin+total,
> - rsize);
> + count);
> if (n <= 0)
> break;
> count -= n;
> --
> 1.6.5.2
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-23 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-17 17:20 [PATCH] [fs/9p] Remove the redundant rsize calculation in v9fs_file_write() Venkateswararao Jujjuri (JV)
2010-08-23 16:15 ` [V9fs-developer] " Eric Van Hensbergen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.