From: Michael Rubin <mrubin@google.com> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: jack@suse.cz, riel@redhat.com, akpm@linux-foundation.org, david@fromorbit.com, npiggin@suse.de, hch@lst.de, axboe@kernel.dk, Michael Rubin <mrubin@google.com> Subject: [PATCH 3/3] writeback: Reporting dirty thresholds in /proc/vmstat Date: Thu, 19 Aug 2010 13:57:27 -0700 [thread overview] Message-ID: <1282251447-16937-4-git-send-email-mrubin@google.com> (raw) In-Reply-To: <1282251447-16937-1-git-send-email-mrubin@google.com> The kernel already exposes the desired thresholds in /proc/sys/vm with dirty_background_ratio and background_ratio. Instead the kernel may alter the number requested without giving the user any indication that is the case. Knowing the actual ratios the kernel is honoring can help app developers understand how their buffered IO will be sent to the disk. $ grep threshold /proc/vmstat nr_pages_dirty_threshold 409111 nr_pages_dirty_background_threshold 818223 Signed-off-by: Michael Rubin <mrubin@google.com> --- include/linux/mmzone.h | 2 ++ mm/vmstat.c | 8 ++++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index f160481..7c4a3bf 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -114,6 +114,8 @@ enum zone_stat_item { #endif NR_PAGES_ENTERED_WRITEBACK, /* number of times pages enter writeback */ NR_FILE_PAGES_DIRTIED, /* number of times pages get dirtied */ + NR_PAGES_DIRTY_THRESHOLD, /* writeback threshold */ + NR_PAGES_DIRTY_BG_THRESHOLD,/* bg writeback threshold */ NR_VM_ZONE_STAT_ITEMS }; /* diff --git a/mm/vmstat.c b/mm/vmstat.c index e177a40..8b5bc78 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -17,6 +17,7 @@ #include <linux/vmstat.h> #include <linux/sched.h> #include <linux/math64.h> +#include <linux/writeback.h> #ifdef CONFIG_VM_EVENT_COUNTERS DEFINE_PER_CPU(struct vm_event_state, vm_event_states) = {{0}}; @@ -742,6 +743,8 @@ static const char * const vmstat_text[] = { #endif "nr_pages_entered_writeback", "nr_file_pages_dirtied", + "nr_pages_dirty_threshold", + "nr_pages_dirty_background_threshold", #ifdef CONFIG_VM_EVENT_COUNTERS "pgpgin", @@ -901,6 +904,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) #ifdef CONFIG_VM_EVENT_COUNTERS unsigned long *e; #endif + unsigned long dirty_thresh, dirty_bg_thresh; int i; if (*pos >= ARRAY_SIZE(vmstat_text)) @@ -918,6 +922,10 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) return ERR_PTR(-ENOMEM); for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) v[i] = global_page_state(i); + + get_dirty_limits(&dirty_thresh, &dirty_bg_thresh, NULL, NULL); + v[NR_PAGES_DIRTY_THRESHOLD] = dirty_thresh; + v[NR_PAGES_DIRTY_BG_THRESHOLD] = dirty_bg_thresh; #ifdef CONFIG_VM_EVENT_COUNTERS e = v + NR_VM_ZONE_STAT_ITEMS; all_vm_events(e); -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Michael Rubin <mrubin@google.com> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: jack@suse.cz, riel@redhat.com, akpm@linux-foundation.org, david@fromorbit.com, npiggin@suse.de, hch@lst.de, axboe@kernel.dk, Michael Rubin <mrubin@google.com> Subject: [PATCH 3/3] writeback: Reporting dirty thresholds in /proc/vmstat Date: Thu, 19 Aug 2010 13:57:27 -0700 [thread overview] Message-ID: <1282251447-16937-4-git-send-email-mrubin@google.com> (raw) In-Reply-To: <1282251447-16937-1-git-send-email-mrubin@google.com> The kernel already exposes the desired thresholds in /proc/sys/vm with dirty_background_ratio and background_ratio. Instead the kernel may alter the number requested without giving the user any indication that is the case. Knowing the actual ratios the kernel is honoring can help app developers understand how their buffered IO will be sent to the disk. $ grep threshold /proc/vmstat nr_pages_dirty_threshold 409111 nr_pages_dirty_background_threshold 818223 Signed-off-by: Michael Rubin <mrubin@google.com> --- include/linux/mmzone.h | 2 ++ mm/vmstat.c | 8 ++++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index f160481..7c4a3bf 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -114,6 +114,8 @@ enum zone_stat_item { #endif NR_PAGES_ENTERED_WRITEBACK, /* number of times pages enter writeback */ NR_FILE_PAGES_DIRTIED, /* number of times pages get dirtied */ + NR_PAGES_DIRTY_THRESHOLD, /* writeback threshold */ + NR_PAGES_DIRTY_BG_THRESHOLD,/* bg writeback threshold */ NR_VM_ZONE_STAT_ITEMS }; /* diff --git a/mm/vmstat.c b/mm/vmstat.c index e177a40..8b5bc78 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -17,6 +17,7 @@ #include <linux/vmstat.h> #include <linux/sched.h> #include <linux/math64.h> +#include <linux/writeback.h> #ifdef CONFIG_VM_EVENT_COUNTERS DEFINE_PER_CPU(struct vm_event_state, vm_event_states) = {{0}}; @@ -742,6 +743,8 @@ static const char * const vmstat_text[] = { #endif "nr_pages_entered_writeback", "nr_file_pages_dirtied", + "nr_pages_dirty_threshold", + "nr_pages_dirty_background_threshold", #ifdef CONFIG_VM_EVENT_COUNTERS "pgpgin", @@ -901,6 +904,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) #ifdef CONFIG_VM_EVENT_COUNTERS unsigned long *e; #endif + unsigned long dirty_thresh, dirty_bg_thresh; int i; if (*pos >= ARRAY_SIZE(vmstat_text)) @@ -918,6 +922,10 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) return ERR_PTR(-ENOMEM); for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) v[i] = global_page_state(i); + + get_dirty_limits(&dirty_thresh, &dirty_bg_thresh, NULL, NULL); + v[NR_PAGES_DIRTY_THRESHOLD] = dirty_thresh; + v[NR_PAGES_DIRTY_BG_THRESHOLD] = dirty_bg_thresh; #ifdef CONFIG_VM_EVENT_COUNTERS e = v + NR_VM_ZONE_STAT_ITEMS; all_vm_events(e); -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-19 20:58 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-19 20:57 [PATCH 0/3] writeback: kernel visibility Michael Rubin 2010-08-19 20:57 ` Michael Rubin 2010-08-19 20:57 ` [PATCH 1/3] mm: helper functions for dirty and writeback accounting Michael Rubin 2010-08-19 20:57 ` Michael Rubin 2010-08-20 2:34 ` Wu Fengguang 2010-08-20 2:34 ` Wu Fengguang 2010-08-20 8:19 ` Michael Rubin 2010-08-20 8:19 ` Michael Rubin 2010-08-19 20:57 ` [PATCH 2/3] writeback: Adding pages_dirtied and pages_entered_writeback Michael Rubin 2010-08-19 20:57 ` Michael Rubin 2010-08-20 2:51 ` Wu Fengguang 2010-08-20 2:51 ` Wu Fengguang 2010-08-20 6:54 ` Wu Fengguang 2010-08-20 6:54 ` Wu Fengguang 2010-08-20 8:16 ` Michael Rubin 2010-08-20 8:16 ` Michael Rubin 2010-08-20 8:43 ` Wu Fengguang 2010-08-20 8:43 ` Wu Fengguang 2010-08-20 8:43 ` Wu Fengguang 2010-08-19 20:57 ` Michael Rubin [this message] 2010-08-19 20:57 ` [PATCH 3/3] writeback: Reporting dirty thresholds in /proc/vmstat Michael Rubin 2010-08-20 3:16 ` Wu Fengguang 2010-08-20 3:16 ` Wu Fengguang 2010-08-20 8:18 ` Michael Rubin 2010-08-20 8:18 ` Michael Rubin 2010-08-19 22:11 ` [PATCH 0/3] writeback: kernel visibility Rik van Riel 2010-08-19 22:11 ` Rik van Riel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1282251447-16937-4-git-send-email-mrubin@google.com \ --to=mrubin@google.com \ --cc=akpm@linux-foundation.org \ --cc=axboe@kernel.dk \ --cc=david@fromorbit.com \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=npiggin@suse.de \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.