* [PATCH] regulator: max8998 - set max8998->num_regulators
@ 2010-08-22 7:26 Axel Lin
2010-08-23 10:01 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-08-22 7:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, Kyungmin Park, Marek Szyprowski
Set max8998->num_regulators = pdata->num_regulators,
otherwise it's default value is 0.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/max8998.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index ab67298..f0d8261 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -558,6 +558,7 @@ static __devinit int max8998_pmic_probe(struct platform_device *pdev)
rdev = max8998->rdev;
max8998->iodev = iodev;
+ max8998->num_regulators = pdata->num_regulators;
platform_set_drvdata(pdev, max8998);
for (i = 0; i < pdata->num_regulators; i++) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: max8998 - set max8998->num_regulators
2010-08-22 7:26 [PATCH] regulator: max8998 - set max8998->num_regulators Axel Lin
@ 2010-08-23 10:01 ` Mark Brown
2010-08-24 14:01 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2010-08-23 10:01 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Kyungmin Park, Marek Szyprowski
On Sun, Aug 22, 2010 at 03:26:49PM +0800, Axel Lin wrote:
> Set max8998->num_regulators = pdata->num_regulators,
> otherwise it's default value is 0.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
With a change like this it's good to note why things worked prior to the
change - my first thought was that it might be better to loose the
driver data copy entirely if we were fine with it being set to zero.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: max8998 - set max8998->num_regulators
2010-08-23 10:01 ` Mark Brown
@ 2010-08-24 14:01 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-08-24 14:01 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Kyungmin Park, Marek Szyprowski
On Mon, 2010-08-23 at 11:01 +0100, Mark Brown wrote:
> On Sun, Aug 22, 2010 at 03:26:49PM +0800, Axel Lin wrote:
> > Set max8998->num_regulators = pdata->num_regulators,
> > otherwise it's default value is 0.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-24 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-22 7:26 [PATCH] regulator: max8998 - set max8998->num_regulators Axel Lin
2010-08-23 10:01 ` Mark Brown
2010-08-24 14:01 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.