All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: The Fungi <fungi@yuggoth.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Intel 965 and Custom Resolutions
Date: Tue, 31 Aug 2010 11:28:40 -0400	[thread overview]
Message-ID: <1283268520.7791.7018.camel@atropine> (raw)
In-Reply-To: <20100831141931.GK2241@yuggoth.org>


[-- Attachment #1.1: Type: text/plain, Size: 2385 bytes --]

On Tue, 2010-08-31 at 14:19 +0000, The Fungi wrote:
> On Tue, Aug 31, 2010 at 09:49:53AM -0400, Adam Jackson wrote:
> > It's possible but improbable. What kernel are you running anyway?
> 
> That system had 2.6.35-rc5 i686 with PAE at the last boot (needed
> some patches for Wacom BT/HID support which got integrated in rc4 or
> rc5). I'll most likely replace that with a 2.6.35 release version
> next time I get around to rebooting, unless 2.6.36 is out by then.

Sigh, okay.  You should be able to get the complete EDID block out
of /sys/class/drm/card0/*/edid, at least if you have in your kernel:

commit 7466f4cc508878a8328dff1c328a2b4108888d2e
Author: Adam Jackson <ajax@redhat.com>
Date:   Mon Mar 29 21:43:23 2010 +0000

    drm/edid: Remove arbitrary EDID extension limit
    
    Signed-off-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>

which should already be present in 2.6.35.  But the X driver looks like
it never sets MONITOR_EDID_COMPLETE_RAWDATA, which means the X core
doesn't know that any sections beyond the first are present, so it won't
ever hand back more than 128 bytes to clients.  Boo.

This should help:

---
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 6f7e5f1..886c58f 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -731,6 +731,7 @@ drmmode_output_get_modes(xf86OutputPtr output)
 	drmModePropertyPtr props;
 	struct fixed_panel_lvds *p_lvds;
 	drmModeModeInfo *mode_ptr;
+	xf86MonPtr mon = NULL;
 
 	/* look for an EDID property */
 	for (i = 0; i < koutput->count_props; i++) {
@@ -751,14 +752,13 @@ drmmode_output_get_modes(xf86OutputPtr output)
 		drmModeFreeProperty(props);
 	}
 
-	if (drmmode_output->edid_blob)
-		xf86OutputSetEDID(output,
-				  xf86InterpretEDID(output->scrn->scrnIndex,
-						    drmmode_output->edid_blob->data));
-	else
-		xf86OutputSetEDID(output,
-				  xf86InterpretEDID(output->scrn->scrnIndex,
-						    NULL));
+	if (drmmode_output->edid_blob) {
+		mon = xf86InterpretEDID(output->scrn->scrnIndex,
+					drmmode_output->edid_blob->data);
+		if (drmmode->edid_blob->length > 128)
+			mon->flags |= MONITOR_EDID_COMPLETE_RAWDATA;
+	}
+	xf86OutputSetEDID(output, mon);
 
 	/* modes should already be available */
 	for (i = 0; i < koutput->count_modes; i++) {
---

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2010-08-31 15:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 16:28 Intel 965 and Custom Resolutions Lucas
2010-08-30 16:44 ` Nasa
2010-08-30 16:53   ` Felix Miata
2010-08-30 17:23     ` Lucas Burdick
2010-08-30 17:14   ` The Fungi
2010-08-30 18:19     ` Adam Jackson
2010-08-30 18:47       ` The Fungi
2010-08-30 18:56         ` Adam Jackson
2010-08-31  1:12           ` The Fungi
2010-08-31 13:49             ` Adam Jackson
2010-08-31 14:19               ` The Fungi
2010-08-31 15:28                 ` Adam Jackson [this message]
2010-08-31 15:48                   ` The Fungi
2010-08-31  1:06   ` Lucas
     [not found] <1340898485.95210.1283241609780.JavaMail.root@sz0115a.westchester.pa.mail.comcast.net>
2010-08-31  8:00 ` Nasa
     [not found] <255483846.95852.1283248533607.JavaMail.root@sz0115a.westchester.pa.mail.comcast.net>
2010-08-31 10:03 ` Nasa
2010-08-31 12:23   ` Felix Miata
2010-08-31 16:10     ` Lucas
     [not found] <1080537060.134598.1283287238589.JavaMail.root@sz0115a.westchester.pa.mail.comcast.net>
2010-08-31 22:32 ` Felix Miata
2010-08-31 22:34   ` Felix Miata
2010-09-01  5:10     ` Lucas
     [not found] <2112186755.243040.1283445050545.JavaMail.root@sz0115a.westchester.pa.mail.comcast.net>
     [not found] ` <601134063.243781.1283445785428.JavaMail.root@sz0115a.westchester.pa.mail.comcast.net>
2010-09-08 17:11   ` Lucas Burdick
2010-09-08 18:11     ` Adam Jackson
2010-09-08 19:47       ` Lucas Burdick
2010-09-08 20:51         ` Lucas
2010-09-08 21:44           ` Lucas Burdick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283268520.7791.7018.camel@atropine \
    --to=ajax@redhat.com \
    --cc=fungi@yuggoth.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.