All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael 'Mickey' Lauer <mickey@vanille-media.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
Date: Thu, 02 Sep 2010 01:00:09 +0200	[thread overview]
Message-ID: <1283382009.2012.15.camel@saphir> (raw)
In-Reply-To: <1283356972-28880-1-git-send-email-noor_ahsan@mentor.com>

Thanks for your patch, but here's what I don't like
(yes, probably oe-stylize is to blame, perhaps someone
could fix it there)

> -export BUILD_SYS
> -export HOST_SYS
> -export STAGING_LIBDIR
> -export STAGING_INCDIR
> -
>  EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
>  
>  do_configure_prepend() {
> -	cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> +        cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
>  }
> -
>  do_stage() {
> -	install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> -	cd ${WORKDIR}/sip-${PV} && python configure.py
> -	install -d ${STAGING_PYDIR}/site-packages
> -	install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> +        install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> +        cd ${WORKDIR}/sip-${PV} && python configure.py
> +        install -d ${STAGING_PYDIR}/site-packages
> +        install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
>  }
>  
> -SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
> -SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
> +export BUILD_SYS
> +export HOST_SYS
> +export STAGING_LIBDIR
> +export STAGING_INCDIR
> +
> +DEFAULT_PREFERENCE = "-1"

I like to keep a mental model of recipes being somewhat executed in a
top-down manner; in the model, exported variable assignments do in fact
affect all of tasks, so I think they should be kept next to the
non-exported assignments.

-- 
:M:




  parent reply	other threads:[~2010-09-01 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 16:02 [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly Noor Ahsan
2010-09-01 19:41 ` Frans Meulenbroeks
2010-09-01 23:05   ` Michael 'Mickey' Lauer
2010-09-01 23:00 ` Michael 'Mickey' Lauer [this message]
2010-09-01 23:08   ` Tom Rini
2010-09-01 23:10     ` Michael 'Mickey' Lauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283382009.2012.15.camel@saphir \
    --to=mickey@vanille-media.de \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.