* [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
@ 2010-09-01 16:02 Noor Ahsan
2010-09-01 19:41 ` Frans Meulenbroeks
2010-09-01 23:00 ` Michael 'Mickey' Lauer
0 siblings, 2 replies; 6+ messages in thread
From: Noor Ahsan @ 2010-09-01 16:02 UTC (permalink / raw)
To: openembedded-devel
* Run oe-stylize script on the recipe and updated the recipe according to the output of the script.
Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
recipes/sip/sip-native_4.7.9.bb | 34 +++++++++++++++++-----------------
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/recipes/sip/sip-native_4.7.9.bb b/recipes/sip/sip-native_4.7.9.bb
index 0b025df..2d78ac1 100644
--- a/recipes/sip/sip-native_4.7.9.bb
+++ b/recipes/sip/sip-native_4.7.9.bb
@@ -1,35 +1,35 @@
DESCRIPTION = "SIP is a C++/Python Wrapper Generator"
-SECTION = "devel"
-HOMEPAGE = "http://www.riverbankcomputing.co.uk/sip"
AUTHOR = "Phil Thompson"
+HOMEPAGE = "http://www.riverbankcomputing.co.uk/sip"
+SECTION = "devel"
PRIORITY = "optional"
LICENSE = "GPL"
PR = "ml0"
-DEFAULT_PREFERENCE = "-1"
-
SRC_URI = "http://www.riverbankcomputing.co.uk/static/Downloads/sip4/sip-${PV}.tar.gz"
+SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
+SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
+
S = "${WORKDIR}/sip-${PV}/sipgen"
inherit qt4x11 native
-export BUILD_SYS
-export HOST_SYS
-export STAGING_LIBDIR
-export STAGING_INCDIR
-
EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
do_configure_prepend() {
- cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
+ cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
}
-
do_stage() {
- install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
- cd ${WORKDIR}/sip-${PV} && python configure.py
- install -d ${STAGING_PYDIR}/site-packages
- install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
+ install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
+ cd ${WORKDIR}/sip-${PV} && python configure.py
+ install -d ${STAGING_PYDIR}/site-packages
+ install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
}
-SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
-SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
+export BUILD_SYS
+export HOST_SYS
+export STAGING_LIBDIR
+export STAGING_INCDIR
+
+DEFAULT_PREFERENCE = "-1"
+
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
2010-09-01 16:02 [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly Noor Ahsan
@ 2010-09-01 19:41 ` Frans Meulenbroeks
2010-09-01 23:05 ` Michael 'Mickey' Lauer
2010-09-01 23:00 ` Michael 'Mickey' Lauer
1 sibling, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-01 19:41 UTC (permalink / raw)
To: openembedded-devel
2010/9/1 Noor Ahsan <noor_ahsan@mentor.com>:
> * Run oe-stylize script on the recipe and updated the recipe according to the output of the script.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
> recipes/sip/sip-native_4.7.9.bb | 34 +++++++++++++++++-----------------
> 1 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/recipes/sip/sip-native_4.7.9.bb b/recipes/sip/sip-native_4.7.9.bb
> index 0b025df..2d78ac1 100644
> --- a/recipes/sip/sip-native_4.7.9.bb
> +++ b/recipes/sip/sip-native_4.7.9.bb
> @@ -1,35 +1,35 @@
> DESCRIPTION = "SIP is a C++/Python Wrapper Generator"
> -SECTION = "devel"
> -HOMEPAGE = "http://www.riverbankcomputing.co.uk/sip"
> AUTHOR = "Phil Thompson"
> +HOMEPAGE = "http://www.riverbankcomputing.co.uk/sip"
> +SECTION = "devel"
> PRIORITY = "optional"
> LICENSE = "GPL"
> PR = "ml0"
>
> -DEFAULT_PREFERENCE = "-1"
> -
> SRC_URI = "http://www.riverbankcomputing.co.uk/static/Downloads/sip4/sip-${PV}.tar.gz"
> +SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
> +SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
> +
> S = "${WORKDIR}/sip-${PV}/sipgen"
>
> inherit qt4x11 native
>
> -export BUILD_SYS
> -export HOST_SYS
> -export STAGING_LIBDIR
> -export STAGING_INCDIR
> -
> EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
>
> do_configure_prepend() {
> - cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> + cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> }
> -
> do_stage() {
> - install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> - cd ${WORKDIR}/sip-${PV} && python configure.py
> - install -d ${STAGING_PYDIR}/site-packages
> - install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> + cd ${WORKDIR}/sip-${PV} && python configure.py
> + install -d ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> }
>
> -SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
> -SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
> +export BUILD_SYS
> +export HOST_SYS
> +export STAGING_LIBDIR
> +export STAGING_INCDIR
> +
> +DEFAULT_PREFERENCE = "-1"
> +
> --
>
Mickey can you say something about this recipe.
It is from 2008 and has DEFAULT_PREFERENCE = -1
pyqt seems to depend on this recipe
and there are also two sip3-native recipes. Could not find a user for this.
Frans
PS: despite what the name suggests, this package does not seem to have
anything to do with voip.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
2010-09-01 19:41 ` Frans Meulenbroeks
@ 2010-09-01 23:05 ` Michael 'Mickey' Lauer
0 siblings, 0 replies; 6+ messages in thread
From: Michael 'Mickey' Lauer @ 2010-09-01 23:05 UTC (permalink / raw)
To: openembedded-devel
Am Mittwoch, den 01.09.2010, 21:41 +0200 schrieb Frans Meulenbroeks:
> Mickey can you say something about this recipe.
> It is from 2008 and has DEFAULT_PREFERENCE = -1
sip is sip4 and has never been tested as extensively as I have tested
sip3.
> pyqt seems to depend on this recipe
Yes. sip is 'a sip of swig', a preprocessor to create Python bindings.
> and there are also two sip3-native recipes. Could not find a user for this.
PyQt3 used to depend on it and I used to maintain PyQt/Embedded for the
Zaurus and iPaq many years after the original author lost interest
(Sharp actually stopped paying him to do that, but that's another
story). Since 2007 I no longer use it though and since there have been
so many changes in Qt and PyQt, I'm afraid I don't know about the state
of it in OE.
Cheers,
--
:M:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
2010-09-01 16:02 [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly Noor Ahsan
2010-09-01 19:41 ` Frans Meulenbroeks
@ 2010-09-01 23:00 ` Michael 'Mickey' Lauer
2010-09-01 23:08 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Michael 'Mickey' Lauer @ 2010-09-01 23:00 UTC (permalink / raw)
To: openembedded-devel
Thanks for your patch, but here's what I don't like
(yes, probably oe-stylize is to blame, perhaps someone
could fix it there)
> -export BUILD_SYS
> -export HOST_SYS
> -export STAGING_LIBDIR
> -export STAGING_INCDIR
> -
> EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
>
> do_configure_prepend() {
> - cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> + cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> }
> -
> do_stage() {
> - install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> - cd ${WORKDIR}/sip-${PV} && python configure.py
> - install -d ${STAGING_PYDIR}/site-packages
> - install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> + cd ${WORKDIR}/sip-${PV} && python configure.py
> + install -d ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> }
>
> -SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
> -SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
> +export BUILD_SYS
> +export HOST_SYS
> +export STAGING_LIBDIR
> +export STAGING_INCDIR
> +
> +DEFAULT_PREFERENCE = "-1"
I like to keep a mental model of recipes being somewhat executed in a
top-down manner; in the model, exported variable assignments do in fact
affect all of tasks, so I think they should be kept next to the
non-exported assignments.
--
:M:
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
2010-09-01 23:00 ` Michael 'Mickey' Lauer
@ 2010-09-01 23:08 ` Tom Rini
2010-09-01 23:10 ` Michael 'Mickey' Lauer
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2010-09-01 23:08 UTC (permalink / raw)
To: openembedded-devel
Michael 'Mickey' Lauer wrote:
> Thanks for your patch, but here's what I don't like
> (yes, probably oe-stylize is to blame, perhaps someone
> could fix it there)
>
>> -export BUILD_SYS
>> -export HOST_SYS
>> -export STAGING_LIBDIR
>> -export STAGING_INCDIR
>> -
>> EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
>>
>> do_configure_prepend() {
>> - cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
>> + cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
>> }
>> -
>> do_stage() {
>> - install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
>> - cd ${WORKDIR}/sip-${PV} && python configure.py
>> - install -d ${STAGING_PYDIR}/site-packages
>> - install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
>> + install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
>> + cd ${WORKDIR}/sip-${PV} && python configure.py
>> + install -d ${STAGING_PYDIR}/site-packages
>> + install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
>> }
>>
>> -SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
>> -SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
>> +export BUILD_SYS
>> +export HOST_SYS
>> +export STAGING_LIBDIR
>> +export STAGING_INCDIR
>> +
>> +DEFAULT_PREFERENCE = "-1"
>
> I like to keep a mental model of recipes being somewhat executed in a
> top-down manner; in the model, exported variable assignments do in fact
> affect all of tasks, so I think they should be kept next to the
> non-exported assignments.
Yes, that does sound right, fixing oe-stylize now...
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
2010-09-01 23:08 ` Tom Rini
@ 2010-09-01 23:10 ` Michael 'Mickey' Lauer
0 siblings, 0 replies; 6+ messages in thread
From: Michael 'Mickey' Lauer @ 2010-09-01 23:10 UTC (permalink / raw)
To: openembedded-devel
Am Mittwoch, den 01.09.2010, 16:08 -0700 schrieb Tom Rini:
> > I like to keep a mental model of recipes being somewhat executed in a
> > top-down manner; in the model, exported variable assignments do in fact
> > affect all of tasks, so I think they should be kept next to the
> > non-exported assignments.
>
> Yes, that does sound right, fixing oe-stylize now...
Splendid! Thanks a lot.
--
:M:
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-01 23:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-01 16:02 [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly Noor Ahsan
2010-09-01 19:41 ` Frans Meulenbroeks
2010-09-01 23:05 ` Michael 'Mickey' Lauer
2010-09-01 23:00 ` Michael 'Mickey' Lauer
2010-09-01 23:08 ` Tom Rini
2010-09-01 23:10 ` Michael 'Mickey' Lauer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.