All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling
@ 2010-09-02  8:27 Axel Lin
  2010-09-02 10:31 ` Liam Girdwood
  2010-09-02 12:23 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2010-09-02  8:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Liam Girdwood, Dmitry Torokhov, linux-input

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/input/touchscreen/wm97xx-core.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index cbfef1e..770537c 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -684,8 +684,7 @@ static int wm97xx_probe(struct device *dev)
  touch_reg_err:
 	platform_device_put(wm->touch_dev);
  touch_err:
-	platform_device_unregister(wm->battery_dev);
-	wm->battery_dev = NULL;
+	platform_device_del(wm->battery_dev);
  batt_reg_err:
 	platform_device_put(wm->battery_dev);
  batt_err:
-- 
1.7.2




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling
  2010-09-02  8:27 [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling Axel Lin
@ 2010-09-02 10:31 ` Liam Girdwood
  2010-09-02 12:23 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-09-02 10:31 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Mark Brown, Dmitry Torokhov, linux-input

On Thu, 2010-09-02 at 16:27 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/input/touchscreen/wm97xx-core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> index cbfef1e..770537c 100644
> --- a/drivers/input/touchscreen/wm97xx-core.c
> +++ b/drivers/input/touchscreen/wm97xx-core.c
> @@ -684,8 +684,7 @@ static int wm97xx_probe(struct device *dev)
>   touch_reg_err:
>  	platform_device_put(wm->touch_dev);
>   touch_err:
> -	platform_device_unregister(wm->battery_dev);
> -	wm->battery_dev = NULL;
> +	platform_device_del(wm->battery_dev);
>   batt_reg_err:
>  	platform_device_put(wm->battery_dev);
>   batt_err:

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling
  2010-09-02  8:27 [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling Axel Lin
  2010-09-02 10:31 ` Liam Girdwood
@ 2010-09-02 12:23 ` Mark Brown
  2010-09-02 15:56   ` Dmitry Torokhov
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2010-09-02 12:23 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Dmitry Torokhov, linux-input

On Thu, Sep 02, 2010 at 04:27:09PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Mark Brown <broonie@opensoruce.wolfsonmicro.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling
  2010-09-02 12:23 ` Mark Brown
@ 2010-09-02 15:56   ` Dmitry Torokhov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2010-09-02 15:56 UTC (permalink / raw)
  To: Mark Brown; +Cc: Axel Lin, linux-kernel, Liam Girdwood, linux-input

On Thu, Sep 02, 2010 at 01:23:37PM +0100, Mark Brown wrote:
> On Thu, Sep 02, 2010 at 04:27:09PM +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> 
> Acked-by: Mark Brown <broonie@opensoruce.wolfsonmicro.com>

Applied, thanks Axel.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-09-02 15:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-02  8:27 [PATCH] Input: wm97xx-core - use platform_device_del instead of platform_device_unregister for error handling Axel Lin
2010-09-02 10:31 ` Liam Girdwood
2010-09-02 12:23 ` Mark Brown
2010-09-02 15:56   ` Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.