* [PATCH 1/1] NET: bna, fix lock imbalance
@ 2010-09-04 12:08 Jiri Slaby
2010-09-07 1:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2010-09-04 12:08 UTC (permalink / raw)
To: davem; +Cc: linux-kernel, jirislaby, netdev, Debashis Dutt, Rasesh Mody
bnad_set_rx_mode omit to unlock bna_lock on one fail path. Fix that.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Debashis Dutt <ddutt@brocade.com>
Cc: Rasesh Mody <rmody@brocade.com>
Cc: David S. Miller <davem@davemloft.net>
---
drivers/net/bna/bnad.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bna/bnad.c b/drivers/net/bna/bnad.c
index cbc1d56..a1a449a 100644
--- a/drivers/net/bna/bnad.c
+++ b/drivers/net/bna/bnad.c
@@ -2706,7 +2706,7 @@ bnad_set_rx_mode(struct net_device *netdev)
kzalloc((mc_count + 1) * ETH_ALEN,
GFP_ATOMIC);
if (!mcaddr_list)
- return;
+ goto unlock;
memcpy(&mcaddr_list[0], &bnad_bcast_addr[0], ETH_ALEN);
@@ -2719,6 +2719,7 @@ bnad_set_rx_mode(struct net_device *netdev)
/* Should we enable BNAD_CF_ALLMULTI for err != 0 ? */
kfree(mcaddr_list);
}
+unlock:
spin_unlock_irqrestore(&bnad->bna_lock, flags);
}
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] NET: bna, fix lock imbalance
2010-09-04 12:08 [PATCH 1/1] NET: bna, fix lock imbalance Jiri Slaby
@ 2010-09-07 1:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-07 1:29 UTC (permalink / raw)
To: jslaby; +Cc: linux-kernel, jirislaby, netdev, ddutt, rmody
From: Jiri Slaby <jslaby@suse.cz>
Date: Sat, 4 Sep 2010 14:08:41 +0200
> bnad_set_rx_mode omit to unlock bna_lock on one fail path. Fix that.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-07 1:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-04 12:08 [PATCH 1/1] NET: bna, fix lock imbalance Jiri Slaby
2010-09-07 1:29 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.