From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Ohad Ben-Cohen <ohad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
San Mehat <san@google.com>,
"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>,
Nicolas Pitre <nico@fluxnic.net>,
Gao Yunpeng <yunpeng.gao@intel.com>
Subject: Re: [PATCH v1 8/8] wireless: wl1271_sdio: enable Runtime PM
Date: Wed, 08 Sep 2010 10:40:23 -0700 [thread overview]
Message-ID: <1283967623.9120.13.camel@capsicum> (raw)
In-Reply-To: <1283858949-11073-9-git-send-email-ohad@wizery.com>
On Tue, 2010-09-07 at 13:29 +0200, ext Ohad Ben-Cohen wrote:
> Enable runtime pm for the wl1271 SDIO device.
>
> We request power whenever the WLAN interface is brought up,
> and release it after the WLAN interface is taken down.
>
> As a result, power is released immediately after probe returns,
> since at that point power has not been explicitly requested yet
> (i.e. the WLAN interface is still down).
>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
Looks fine to me, after considering David's comment and since it's done
in the same way for PCI.
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
--
Cheers,
Luca.
WARNING: multiple messages have this Message-ID (diff)
From: Luciano Coelho <luciano.coelho-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: ext Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
Cc: "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
San Mehat <san-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Quadros Roger (Nokia-MS/Helsinki)"
<roger.quadros-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
Nicolas Pitre <nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org>,
Gao Yunpeng <yunpeng.gao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v1 8/8] wireless: wl1271_sdio: enable Runtime PM
Date: Wed, 08 Sep 2010 10:40:23 -0700 [thread overview]
Message-ID: <1283967623.9120.13.camel@capsicum> (raw)
In-Reply-To: <1283858949-11073-9-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
On Tue, 2010-09-07 at 13:29 +0200, ext Ohad Ben-Cohen wrote:
> Enable runtime pm for the wl1271 SDIO device.
>
> We request power whenever the WLAN interface is brought up,
> and release it after the WLAN interface is taken down.
>
> As a result, power is released immediately after probe returns,
> since at that point power has not been explicitly requested yet
> (i.e. the WLAN interface is still down).
>
> Signed-off-by: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
> ---
Looks fine to me, after considering David's comment and since it's done
in the same way for PCI.
Acked-by: Luciano Coelho <luciano.coelho-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-09-08 17:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 11:29 [PATCH v1 0/8] SDIO Runtime PM Support Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 1/8] mmc: sdio: fully reconfigure oldcard on resume Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 2/8] mmc: propagate power save/restore ops return value Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 3/8] sdio: add power_restore support Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 4/8] mmc: add general Runtime PM support Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 5/8] sdio: add general runtime " Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 6/8] sdio: enable Runtime PM for SDIO cards Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-14 19:27 ` Chris Ball
2010-09-14 19:27 ` Chris Ball
2010-09-14 19:32 ` Ohad Ben-Cohen
2010-09-14 19:32 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 8/8] wireless: wl1271_sdio: enable Runtime PM Ohad Ben-Cohen
2010-09-07 11:29 ` Ohad Ben-Cohen
2010-09-07 13:02 ` David Vrabel
2010-09-07 13:02 ` David Vrabel
2010-09-07 13:15 ` Ohad Ben-Cohen
2010-09-07 22:20 ` David Vrabel
2010-09-08 17:40 ` Luciano Coelho [this message]
2010-09-08 17:40 ` Luciano Coelho
2010-09-08 17:52 ` [PATCH v1 0/8] SDIO Runtime PM Support Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283967623.9120.13.camel@capsicum \
--to=luciano.coelho@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.