* [PATCH] atlx: make strings const
@ 2010-09-08 22:18 Stephen Hemminger
2010-09-08 22:58 ` Joe Perches
2010-09-09 4:32 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2010-09-08 22:18 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Chris Snook <chris.snook@gmail.com>
--- a/drivers/net/atlx/atl2.c 2010-09-02 10:51:39.529679405 -0700
+++ b/drivers/net/atlx/atl2.c 2010-09-02 10:52:23.904667707 -0700
@@ -51,10 +51,10 @@
#define ATL2_DRV_VERSION "2.2.3"
-static char atl2_driver_name[] = "atl2";
+static const char atl2_driver_name[] = "atl2";
static const char atl2_driver_string[] = "Atheros(R) L2 Ethernet Driver";
-static char atl2_copyright[] = "Copyright (c) 2007 Atheros Corporation.";
-static char atl2_driver_version[] = ATL2_DRV_VERSION;
+static const char atl2_copyright[] = "Copyright (c) 2007 Atheros Corporation.";
+static const char atl2_driver_version[] = ATL2_DRV_VERSION;
MODULE_AUTHOR("Atheros Corporation <xiong.huang@atheros.com>, Chris Snook <csnook@redhat.com>");
MODULE_DESCRIPTION("Atheros Fast Ethernet Network Driver");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] atlx: make strings const
2010-09-08 22:18 [PATCH] atlx: make strings const Stephen Hemminger
@ 2010-09-08 22:58 ` Joe Perches
2010-09-09 1:54 ` Stephen Hemminger
2010-09-09 4:32 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2010-09-08 22:58 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev
On Wed, 2010-09-08 at 15:18 -0700, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Chris Snook <chris.snook@gmail.com>
>
Shouldn't that be done with all of the global
static char foo[] = "bar"; declarations?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] atlx: make strings const
2010-09-08 22:58 ` Joe Perches
@ 2010-09-09 1:54 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2010-09-09 1:54 UTC (permalink / raw)
To: Joe Perches; +Cc: David Miller, netdev
On Wed, 08 Sep 2010 15:58:11 -0700
Joe Perches <joe@perches.com> wrote:
> On Wed, 2010-09-08 at 15:18 -0700, Stephen Hemminger wrote:
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> > Acked-by: Chris Snook <chris.snook@gmail.com>
> >
>
> Shouldn't that be done with all of the global
> static char foo[] = "bar"; declarations?
Yes, that what I was looking at when I found some of these.
Those that are __initdata don't matter as much since they
get dropped (although they could be changed to __initconst).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] atlx: make strings const
2010-09-08 22:18 [PATCH] atlx: make strings const Stephen Hemminger
2010-09-08 22:58 ` Joe Perches
@ 2010-09-09 4:32 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-09-09 4:32 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 8 Sep 2010 15:18:36 -0700
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Chris Snook <chris.snook@gmail.com>
Applied, feel free to hit those __initconst cases too.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-09 4:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-08 22:18 [PATCH] atlx: make strings const Stephen Hemminger
2010-09-08 22:58 ` Joe Perches
2010-09-09 1:54 ` Stephen Hemminger
2010-09-09 4:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.