mks.jffs2 uid/gid for root inode

mks.jffs2 uid/gid for root inode

[Arno Steffen]

I use mkfs.jffs2 to generate a partition out of a directory tree (not
the hole root-filesystem).
It seem the owner of the root point of this directory tree is always
root:root, althouh it might have other owners.

Example

mkfs.jffs2 -lnp -e 0x20000 -r /opt/rootfs/opt -o /mnt/hgfs/share/fs_opt.jffs2

In my NFS-rootfs /opt/rootfs/opt is owned by user but flashing the
created jffs file will be mounted as owner root.
>From my point of view this is a bug, as it doesn't care about the real
owner of this part of filetree.
Or did I misused the -r option?

I hope you can give me a comment or some feedback, how to change this behaviour.

Best regards
Arno

Re: mks.jffs2 uid/gid for root inode

[Artem Bityutskiy]

On Fri, 2010-09-03 at 14:12 +0200, Arno Steffen wrote:
> I use mkfs.jffs2 to generate a partition out of a directory tree (not
> the hole root-filesystem).
> It seem the owner of the root point of this directory tree is always
> root:root, althouh it might have other owners.
> 
> Example
> 
> mkfs.jffs2 -lnp -e 0x20000 -r /opt/rootfs/opt -o /mnt/hgfs/share/fs_opt.jffs2
> 
> In my NFS-rootfs /opt/rootfs/opt is owned by user but flashing the
> created jffs file will be mounted as owner root.
> From my point of view this is a bug, as it doesn't care about the real
> owner of this part of filetree.
> Or did I misused the -r option?
> 
> I hope you can give me a comment or some feedback, how to change this behaviour.

Sounds like a bug. I'll take a look at this as soon as I have some time.
Or you can send a patch.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: mks.jffs2 uid/gid for root inode

[Arno Steffen]

2010/9/7 Artem Bityutskiy <dedekind1@gmail.com>:
> On Fri, 2010-09-03 at 14:12 +0200, Arno Steffen wrote:
>> I use mkfs.jffs2 to generate a partition out of a directory tree (not
>> the hole root-filesystem).
>> It seem the owner of the root point of this directory tree is always
>> root:root, althouh it might have other owners.
>>
>> Example
>>
>> mkfs.jffs2 -lnp -e 0x20000 -r /opt/rootfs/opt -o /mnt/hgfs/share/fs_opt.jffs2
>>
>> In my NFS-rootfs /opt/rootfs/opt is owned by user but flashing the
>> created jffs file will be mounted as owner root.
>> From my point of view this is a bug, as it doesn't care about the real
>> owner of this part of filetree.
>> Or did I misused the -r option?
>>
>> I hope you can give me a comment or some feedback, how to change this behaviour.
>
> Sounds like a bug. I'll take a look at this as soon as I have some time.
> Or you can send a patch.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)

Thanks, thought already nobody is interested in this. Regarding a
patch: I did look at the code, but my knowledge about the details is
to less.

Re: mks.jffs2 uid/gid for root inode

[Artem Bityutskiy]

On Thu, 2010-09-09 at 08:17 +0200, Arno Steffen wrote:
> Thanks, thought already nobody is interested in this. Regarding a
> patch: I did look at the code, but my knowledge about the details is
> to less.

I've sent you the patch. Please, test v2 of the patch and let me know if
it works for you. Thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: mks.jffs2 uid/gid for root inode

[Arno Steffen]

2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
> On Thu, 2010-09-09 at 11:57 +0200, Arno Steffen wrote:
>> 2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
>> > On Thu, 2010-09-09 at 08:17 +0200, Arno Steffen wrote:
>> >> Thanks, thought already nobody is interested in this. Regarding a
>> >> patch: I did look at the code, but my knowledge about the details is
>> >> to less.
>> >
>> > I've sent you the patch. Please, test v2 of the patch and let me know if
>> > it works for you. Thanks!
>> >
>> > --
>> > Best Regards,
>> > Artem Bityutskiy (Артём Битюцкий)
>>
>> Havn't got e mail with patch ?!?
>
> Attached. It was sent to the MTD ML and you was in CC.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>

Thanks for the patch. But this is for ubifs, while I detected this bug
in jffs2 - this is what I am using.
So I can't test this.
Best regards
Arno

Re: mks.jffs2 uid/gid for root inode

[Artem Bityutskiy]

On Thu, 2010-09-09 at 13:54 +0200, Arno Steffen wrote:
> Thanks for the patch. But this is for ubifs, while I detected this bug
> in jffs2 - this is what I am using.

Oh my god, I really need to start wearing glasses. Sorry. But the same
bug exists in mkfs.ubifs, anyway. Since I'm not interested in JFFS2
anymore, I'm not going to fix it. You can do analogous thing for
mkfs.jffs2, if you wish.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: mks.jffs2 uid/gid for root inode

[Arno Steffen]

2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
> On Thu, 2010-09-09 at 13:54 +0200, Arno Steffen wrote:
>> Thanks for the patch. But this is for ubifs, while I detected this bug
>> in jffs2 - this is what I am using.
>
> Oh my god, I really need to start wearing glasses. Sorry. But the same
> bug exists in mkfs.ubifs, anyway. Since I'm not interested in JFFS2
> anymore, I'm not going to fix it. You can do analogous thing for
> mkfs.jffs2, if you wish.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)

If it's mkfs.jffs2 is not your fokus, Artem, maybe David can have a look at it.
It make sense to keep the same functionality for all mkfs tools.

Best regards
Arno

Re: mks.jffs2 uid/gid for root inode

[Artem Bityutskiy]

On Fri, 2010-09-24 at 11:52 +0200, Arno Steffen wrote:
> 2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Thu, 2010-09-09 at 13:54 +0200, Arno Steffen wrote:
> >> Thanks for the patch. But this is for ubifs, while I detected this bug
> >> in jffs2 - this is what I am using.
> >
> > Oh my god, I really need to start wearing glasses. Sorry. But the same
> > bug exists in mkfs.ubifs, anyway. Since I'm not interested in JFFS2
> > anymore, I'm not going to fix it. You can do analogous thing for
> > mkfs.jffs2, if you wish.
> >
> > --
> > Best Regards,
> > Artem Bityutskiy (Артём Битюцкий)
> 
> If it's mkfs.jffs2 is not your fokus, Artem, maybe David can have a look at it.
> It make sense to keep the same functionality for all mkfs tools.

May be, unsurprisingly, I have no jurisdiction over him, he is free to
do or not to do something for you.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: mks.jffs2 uid/gid for root inode

[Arno Steffen]

2010/9/24 Artem Bityutskiy <dedekind1@gmail.com>:
> On Fri, 2010-09-24 at 11:52 +0200, Arno Steffen wrote:
>> 2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
>> > On Thu, 2010-09-09 at 13:54 +0200, Arno Steffen wrote:
>> >> Thanks for the patch. But this is for ubifs, while I detected this bug
>> >> in jffs2 - this is what I am using.
>> >
>> > Oh my god, I really need to start wearing glasses. Sorry. But the same
>> > bug exists in mkfs.ubifs, anyway. Since I'm not interested in JFFS2
>> > anymore, I'm not going to fix it. You can do analogous thing for
>> > mkfs.jffs2, if you wish.
>> >
>> > --
>> > Best Regards,
>> > Artem Bityutskiy (Артём Битюцкий)
>>
>> If it's mkfs.jffs2 is not your fokus, Artem, maybe David can have a look at it.
>> It make sense to keep the same functionality for all mkfs tools.
>
> May be, unsurprisingly, I have no jurisdiction over him, he is free to
> do or not to do something for you.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
>

Hasn't expect an order. Just a broad hint for David ;) (or someone
else who has the ability).
If It would be just for me, I wouldn't push. I know that my only
chance is to argue.

Re: mks.jffs2 uid/gid for root inode

[Arno Steffen]

Unfortunatly, this bug isn't fixed until now. (I just compiled the head)
The infomation about the owner for the mount point seems not to be part of jffs2

To make this situation more clean: My flash has 2 partitions
/ and /opt

And I also create two jffs2 files, one for each partition: root.jffs2
and opt.jffs2

If I mount /opt - the ownership of /opt is root, although it has been
"user" in the tree I generated the jffs2 files from.

Best regards
Arno



2010/9/24 Arno Steffen <arno.steffen@googlemail.com>:
> 2010/9/24 Artem Bityutskiy <dedekind1@gmail.com>:
>> On Fri, 2010-09-24 at 11:52 +0200, Arno Steffen wrote:
>>> 2010/9/9 Artem Bityutskiy <dedekind1@gmail.com>:
>>> > On Thu, 2010-09-09 at 13:54 +0200, Arno Steffen wrote:
>>> >> Thanks for the patch. But this is for ubifs, while I detected this bug
>>> >> in jffs2 - this is what I am using.
>>> >
>>> > Oh my god, I really need to start wearing glasses. Sorry. But the same
>>> > bug exists in mkfs.ubifs, anyway. Since I'm not interested in JFFS2
>>> > anymore, I'm not going to fix it. You can do analogous thing for
>>> > mkfs.jffs2, if you wish.
>>> >
>>> > --
>>> > Best Regards,
>>> > Artem Bityutskiy (Артём Битюцкий)
>>>
>>> If it's mkfs.jffs2 is not your fokus, Artem, maybe David can have a look at it.
>>> It make sense to keep the same functionality for all mkfs tools.
>>
>> May be, unsurprisingly, I have no jurisdiction over him, he is free to
>> do or not to do something for you.
>>
>> --
>> Best Regards,
>> Artem Bityutskiy (Артём Битюцкий)
>>
>>
>
> Hasn't expect an order. Just a broad hint for David ;) (or someone
> else who has the ability).
> If It would be just for me, I wouldn't push. I know that my only
> chance is to argue.
>