* [PATCH] ASoC: Fix off-by-one bug in register cache size configuration
@ 2010-09-10 17:24 Dimitris Papastamos
2010-09-11 8:02 ` Liam Girdwood
2010-09-11 9:46 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2010-09-10 17:24 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
This is a simple off-by-one bug, the size of the register cache is
incorrectly set to the maximum register index. Fix it by adding one.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8962.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index 58ba2d3..30984dd 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -1780,7 +1780,7 @@ static struct snd_soc_codec_driver soc_codec_dev_wm8962 = {
.remove = wm8962_remove,
.resume = wm8962_resume,
.set_bias_level = wm8962_set_bias_level,
- .reg_cache_size = WM8962_MAX_REGISTER,
+ .reg_cache_size = WM8962_MAX_REGISTER + 1,
.reg_word_size = sizeof(u16),
.reg_cache_default = wm8962_reg,
.volatile_register = wm8962_volatile_register,
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Fix off-by-one bug in register cache size configuration
2010-09-10 17:24 [PATCH] ASoC: Fix off-by-one bug in register cache size configuration Dimitris Papastamos
@ 2010-09-11 8:02 ` Liam Girdwood
2010-09-11 9:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-09-11 8:02 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Fri, 2010-09-10 at 18:24 +0100, Dimitris Papastamos wrote:
> This is a simple off-by-one bug, the size of the register cache is
> incorrectly set to the maximum register index. Fix it by adding one.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Fix off-by-one bug in register cache size configuration
2010-09-10 17:24 [PATCH] ASoC: Fix off-by-one bug in register cache size configuration Dimitris Papastamos
2010-09-11 8:02 ` Liam Girdwood
@ 2010-09-11 9:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-11 9:46 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Fri, Sep 10, 2010 at 06:24:08PM +0100, Dimitris Papastamos wrote:
> This is a simple off-by-one bug, the size of the register cache is
> incorrectly set to the maximum register index. Fix it by adding one.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-11 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-10 17:24 [PATCH] ASoC: Fix off-by-one bug in register cache size configuration Dimitris Papastamos
2010-09-11 8:02 ` Liam Girdwood
2010-09-11 9:46 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.