* [PATCH] block: fix blk_rq_map_kern bio direction flag
@ 2010-09-13 19:08 Benny Halevy
2010-09-13 19:30 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Benny Halevy @ 2010-09-13 19:08 UTC (permalink / raw)
To: Jens Axboe
Cc: Christoph Hellwig, linux-scsi, linux-kernel, Benny Halevy, Boaz Harrosh
This bug was introduced in 7b6d91daee5cac6402186ff224c3af39d79f4a0e
"block: unify flags for struct bio and struct request"
Cc: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
block/blk-map.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/blk-map.c b/block/blk-map.c
index c65d759..ade0a08 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -307,7 +307,7 @@ int blk_rq_map_kern(struct request_queue *q, struct request *rq, void *kbuf,
return PTR_ERR(bio);
if (rq_data_dir(rq) == WRITE)
- bio->bi_rw |= (1 << REQ_WRITE);
+ bio->bi_rw |= REQ_WRITE;
if (do_copy)
rq->cmd_flags |= REQ_COPY_USER;
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: fix blk_rq_map_kern bio direction flag
2010-09-13 19:08 [PATCH] block: fix blk_rq_map_kern bio direction flag Benny Halevy
@ 2010-09-13 19:30 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2010-09-13 19:30 UTC (permalink / raw)
To: Benny Halevy; +Cc: Christoph Hellwig, linux-scsi, linux-kernel, Boaz Harrosh
On 2010-09-13 21:08, Benny Halevy wrote:
> This bug was introduced in 7b6d91daee5cac6402186ff224c3af39d79f4a0e
> "block: unify flags for struct bio and struct request"
Thanks, that's pretty nasty. I'll expedite this.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-13 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-13 19:08 [PATCH] block: fix blk_rq_map_kern bio direction flag Benny Halevy
2010-09-13 19:30 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.