* [Buildroot] [PATCH] host tools: create the host sed in $(O)/host/
@ 2010-09-13 23:27 Yann E. MORIN
2010-09-14 6:02 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2010-09-13 23:27 UTC (permalink / raw)
To: buildroot
The host sed does not belong to $(O)toolchain/ but
really belongs to $(O)/host/
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
package/sed/sed.mk | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/package/sed/sed.mk b/package/sed/sed.mk
index c393dd9..deae71d 100644
--- a/package/sed/sed.mk
+++ b/package/sed/sed.mk
@@ -7,7 +7,7 @@ SED_VERSION:=4.2.1
SED_SOURCE:=sed-$(SED_VERSION).tar.gz
SED_SITE:=$(BR2_GNU_MIRROR)/sed
SED_CAT:=$(ZCAT)
-SED_DIR1:=$(TOOLCHAIN_DIR)/sed-$(SED_VERSION)
+SED_DIR1:=$(HOST_DIR)/sed-$(SED_VERSION)
SED_DIR2:=$(BUILD_DIR)/sed-$(SED_VERSION)
SED_BINARY:=sed/sed
SED_TARGET_BINARY:=bin/sed
@@ -15,7 +15,7 @@ ifeq ($(BR2_LARGEFILE),y)
SED_CPPFLAGS=-D_FILE_OFFSET_BITS=64
endif
#HOST_SED_DIR:=$(STAGING_DIR)
-HOST_SED_DIR:=$(TOOLCHAIN_DIR)
+HOST_SED_DIR:=$(HOST_DIR)
SED:=$(HOST_SED_DIR)/bin/sed -i -e
HOST_SED_BINARY:=$(shell package/sed/sedcheck.sh)
HOST_SED_IF_ANY=$(shell toolchain/dependencies/check-host-sed.sh)
@@ -33,9 +33,7 @@ sed-source: $(DL_DIR)/$(SED_SOURCE)
#
#############################################################
$(SED_DIR1)/.unpacked: $(DL_DIR)/$(SED_SOURCE)
- mkdir -p $(TOOLCHAIN_DIR)
- mkdir -p $(HOST_SED_DIR)/bin
- $(SED_CAT) $(DL_DIR)/$(SED_SOURCE) | tar -C $(TOOLCHAIN_DIR) $(TAR_OPTIONS) -
+ $(SED_CAT) $(DL_DIR)/$(SED_SOURCE) | tar -C $(HOST_DIR) $(TAR_OPTIONS) -
toolchain/patch-kernel.sh $(SED_DIR1) package/sed/ configure.patch
$(CONFIG_UPDATE) $(SED_DIR1)/config
touch $@
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] host tools: create the host sed in $(O)/host/
2010-09-13 23:27 [Buildroot] [PATCH] host tools: create the host sed in $(O)/host/ Yann E. MORIN
@ 2010-09-14 6:02 ` Thomas Petazzoni
2010-09-18 21:05 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2010-09-14 6:02 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 14 Sep 2010 01:27:14 +0200
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> wrote:
> The host sed does not belong to $(O)toolchain/ but
> really belongs to $(O)/host/
In my opinion, the host-sed does not belong anywhere, we could just use
the real host sed, and remove all the crap to detect if the host sed is
good or not, the symlinking stuff, etc.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] host tools: create the host sed in $(O)/host/
2010-09-14 6:02 ` Thomas Petazzoni
@ 2010-09-18 21:05 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2010-09-18 21:05 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Hello,
Thomas> On Tue, 14 Sep 2010 01:27:14 +0200
Thomas> "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> wrote:
>> The host sed does not belong to $(O)toolchain/ but
>> really belongs to $(O)/host/
Thomas> In my opinion, the host-sed does not belong anywhere, we could just use
Thomas> the real host sed, and remove all the crap to detect if the host sed is
Thomas> good or not, the symlinking stuff, etc.
Agreed. Care to make a patch?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-18 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-13 23:27 [Buildroot] [PATCH] host tools: create the host sed in $(O)/host/ Yann E. MORIN
2010-09-14 6:02 ` Thomas Petazzoni
2010-09-18 21:05 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.