* [PATCH] s3c-fb: fix spinlock lockup
@ 2010-09-15 18:35 ` Jing Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jing Liu @ 2010-09-15 18:35 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes spinlock lockup caused by calling request_irq before
init_waitqueue_head in s3c-fb.c.
This patch has been tested on SmartQ5.
Signed-off-by: Jing Liu <jing.liu.linux at gmail.com>
---
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index f9aca9d..980ad04 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1160,8 +1160,6 @@ static int __devinit s3c_fb_probe_win(struct
s3c_fb *sfb, unsigned int win_no,
dev_dbg(sfb->dev, "probing window %d, variant %p\n", win_no, variant);
- init_waitqueue_head(&sfb->vsync_info.wait);
-
palette_size = variant->palette_sz * 4;
fbinfo = framebuffer_alloc(sizeof(struct s3c_fb_win) +
@@ -1351,6 +1349,9 @@ static int __devinit s3c_fb_probe(struct
platform_device *pdev)
goto err_ioremap;
}
sfb->irq_no = res->start;
+
+ init_waitqueue_head(&sfb->vsync_info.wait);
+
ret = request_irq(sfb->irq_no, s3c_fb_irq,
0, "s3c_fb", sfb);
if (ret) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] s3c-fb: fix spinlock lockup
@ 2010-09-15 18:35 ` Jing Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jing Liu @ 2010-09-15 18:35 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes spinlock lockup caused by calling request_irq before
init_waitqueue_head in s3c-fb.c.
This patch has been tested on SmartQ5.
Signed-off-by: Jing Liu <jing.liu.linux@gmail.com>
---
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index f9aca9d..980ad04 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1160,8 +1160,6 @@ static int __devinit s3c_fb_probe_win(struct
s3c_fb *sfb, unsigned int win_no,
dev_dbg(sfb->dev, "probing window %d, variant %p\n", win_no, variant);
- init_waitqueue_head(&sfb->vsync_info.wait);
-
palette_size = variant->palette_sz * 4;
fbinfo = framebuffer_alloc(sizeof(struct s3c_fb_win) +
@@ -1351,6 +1349,9 @@ static int __devinit s3c_fb_probe(struct
platform_device *pdev)
goto err_ioremap;
}
sfb->irq_no = res->start;
+
+ init_waitqueue_head(&sfb->vsync_info.wait);
+
ret = request_irq(sfb->irq_no, s3c_fb_irq,
0, "s3c_fb", sfb);
if (ret) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-15 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-15 18:35 [PATCH] s3c-fb: fix spinlock lockup Jing Liu
2010-09-15 18:35 ` Jing Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.