All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: linux-bluetooth@vger.kernel.org
Cc: linux-usb@vger.kernel.org, marcel@holtmann.org,
	Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 2/3] bluetooth: Remove some unnecessary error messages
Date: Thu, 16 Sep 2010 13:58:14 -0400	[thread overview]
Message-ID: <1284659895-27984-2-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1284659895-27984-1-git-send-email-mjg@redhat.com>

The main reason for these urbs to error out on submission is that runtime
pm has kicked in, which is unnecessary noise. Let's just drop them.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/bluetooth/btusb.c |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index d22ce3c..3ace025 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -229,11 +229,8 @@ static void btusb_intr_complete(struct urb *urb)
 	usb_anchor_urb(urb, &data->intr_anchor);
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
-	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
-						hdev->name, urb, -err);
+	if (err < 0)
 		usb_unanchor_urb(urb);
-	}
 }
 
 static int btusb_submit_intr_urb(struct hci_dev *hdev, gfp_t mem_flags)
@@ -313,11 +310,8 @@ static void btusb_bulk_complete(struct urb *urb)
 	usb_mark_last_busy(data->udev);
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
-	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
-						hdev->name, urb, -err);
+	if (err < 0)
 		usb_unanchor_urb(urb);
-	}
 }
 
 static int btusb_submit_bulk_urb(struct hci_dev *hdev, gfp_t mem_flags)
@@ -402,11 +396,8 @@ static void btusb_isoc_complete(struct urb *urb)
 	usb_anchor_urb(urb, &data->isoc_anchor);
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
-	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
-						hdev->name, urb, -err);
+	if (err < 0)
 		usb_unanchor_urb(urb);
-	}
 }
 
 static void inline __fill_isoc_descriptor(struct urb *urb, int len, int mtu)
-- 
1.7.2.3

  reply	other threads:[~2010-09-16 17:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16 17:58 [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Matthew Garrett
2010-09-16 17:58 ` Matthew Garrett [this message]
2010-09-17  8:33   ` [PATCH 2/3] bluetooth: Remove some unnecessary error messages Andrei Emeltchenko
2010-09-17  8:59     ` Oliver Neukum
2010-10-18 11:55   ` Marcel Holtmann
2010-10-19 16:01     ` Matthew Garrett
2010-09-16 17:58 ` [PATCH 3/3] bluetooth: Enable USB autosuspend by default on btusb Matthew Garrett
2010-10-13 10:00   ` Marcel Holtmann
2010-10-18  6:06   ` Gustavo F. Padovan
2010-09-17  8:39 ` [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Oliver Neukum
2010-09-17 12:24   ` Matthew Garrett
2010-10-13  9:32 ` Marcel Holtmann
2010-10-19 16:03   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284659895-27984-2-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.