From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections
Date: Tue, 19 Oct 2010 17:03:26 +0100 [thread overview]
Message-ID: <20101019160326.GC25861@srcf.ucam.org> (raw)
In-Reply-To: <1286962345.3316.1.camel@aeonflux>
On Wed, Oct 13, 2010 at 12:32:25PM +0300, Marcel Holtmann wrote:
> Hi Matthew,
>
> > Bluetooth runtime PM interacts badly with input devices - the connection
> > will be dropped if the device becomes idle, resulting in noticable lag when
> > the user interacts with the input device again. Bump the pm runtime count
> > when the device is associated and release it when it's disassociated in
> > order to avoid this.
>
> we already have hci_conn_hold_device() and hci_conn_put_device() calls
> for HID to hold reference of the ACL connection. Why do we need more?
Because doing so doesn't do anything to influence runtime PM behaviour.
Putting the calls in these functions might be reasonable though - would
you prefer that?
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-10-19 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 17:58 [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Matthew Garrett
2010-09-16 17:58 ` [PATCH 2/3] bluetooth: Remove some unnecessary error messages Matthew Garrett
2010-09-17 8:33 ` Andrei Emeltchenko
2010-09-17 8:59 ` Oliver Neukum
2010-10-18 11:55 ` Marcel Holtmann
2010-10-19 16:01 ` Matthew Garrett
2010-09-16 17:58 ` [PATCH 3/3] bluetooth: Enable USB autosuspend by default on btusb Matthew Garrett
2010-10-13 10:00 ` Marcel Holtmann
2010-10-18 6:06 ` Gustavo F. Padovan
2010-09-17 8:39 ` [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Oliver Neukum
2010-09-17 12:24 ` Matthew Garrett
2010-10-13 9:32 ` Marcel Holtmann
2010-10-19 16:03 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019160326.GC25861@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.