* [PATCH v2] drivers/net/tulip/de4x5.c
@ 2010-09-15 21:43 Dan Rosenberg
2010-09-17 4:53 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Dan Rosenberg @ 2010-09-15 21:43 UTC (permalink / raw)
To: grundler; +Cc: linux-kernel, netdev, kyle, davem, jeffm, security
Fixed formatting (tabs and line breaks).
This was previously reported as a security issue due to leakage of
uninitialized stack memory. Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
--- linux-2.6.35.4.orig/drivers/net/tulip/de4x5.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/tulip/de4x5.c 2010-09-14 21:26:52.499474207 -0400
@@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, stru
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j;
- if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drivers/net/tulip/de4x5.c
2010-09-15 21:43 [PATCH v2] drivers/net/tulip/de4x5.c Dan Rosenberg
@ 2010-09-17 4:53 ` David Miller
2010-09-17 5:05 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Dan Rosenberg
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2010-09-17 4:53 UTC (permalink / raw)
To: drosenberg; +Cc: grundler, linux-kernel, netdev, kyle, jeffm, security
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Wed, 15 Sep 2010 17:43:18 -0400
> Fixed formatting (tabs and line breaks).
>
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory. Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
You need to give something more descriptive than just the name of the
file you're editing in the Subject: line of this commit message.
Otherwise people scanning "shortlog" and similar output won't have
even a general idea of what kind of change your commit is making.
Please formally resubmit this with a proper commit header line.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 4:53 ` David Miller
@ 2010-09-17 5:05 ` Dan Rosenberg
2010-09-17 5:27 ` David Miller
2010-09-17 5:31 ` [PATCH v3] " Eric Dumazet
0 siblings, 2 replies; 10+ messages in thread
From: Dan Rosenberg @ 2010-09-17 5:05 UTC (permalink / raw)
To: David Miller; +Cc: grundler, linux-kernel, netdev, kyle, jeffm, security
Now with descriptive title, as requested.
This was previously reported as a security issue due to leakage of
uninitialized stack memory. Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
--- linux-2.6.35.4.orig/drivers/net/tulip/de4x5.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/tulip/de4x5.c 2010-09-14 21:26:52.499474207 -0400
@@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, stru
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j;
- if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 5:05 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Dan Rosenberg
@ 2010-09-17 5:27 ` David Miller
2010-09-17 5:30 ` [PATCH v4] " Dan Rosenberg
2010-09-17 5:31 ` [PATCH v3] " Eric Dumazet
1 sibling, 1 reply; 10+ messages in thread
From: David Miller @ 2010-09-17 5:27 UTC (permalink / raw)
To: drosenberg; +Cc: grundler, linux-kernel, netdev, kyle, jeffm, security
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Fri, 17 Sep 2010 01:05:44 -0400
> Now with descriptive title, as requested.
>
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory. Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
Tab et al. damaged by your email client.
This is getting tiring for me, I guess it's getting tiring for
you too? :-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 5:27 ` David Miller
@ 2010-09-17 5:30 ` Dan Rosenberg
2010-09-17 5:34 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Dan Rosenberg @ 2010-09-17 5:30 UTC (permalink / raw)
To: David Miller; +Cc: grundler, linux-kernel, netdev, kyle, jeffm, security
Tiring doesn't begin to describe it. Formatting undamaged.
This was previously reported as a security issue due to leakage of
uninitialized stack memory. Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
--- linux-2.6.35.4.orig/drivers/net/tulip/de4x5.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/tulip/de4x5.c 2010-09-14 21:26:52.499474207 -0400
@@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, stru
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j;
- if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 5:05 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Dan Rosenberg
2010-09-17 5:27 ` David Miller
@ 2010-09-17 5:31 ` Eric Dumazet
1 sibling, 0 replies; 10+ messages in thread
From: Eric Dumazet @ 2010-09-17 5:31 UTC (permalink / raw)
To: Dan Rosenberg
Cc: David Miller, grundler, linux-kernel, netdev, kyle, jeffm, security
Le vendredi 17 septembre 2010 à 01:05 -0400, Dan Rosenberg a écrit :
> Now with descriptive title, as requested.
>
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory. Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
>
> --- linux-2.6.35.4.orig/drivers/net/tulip/de4x5.c 2010-08-26 19:47:12.000000000 -0400
> +++ linux-2.6.35.4/drivers/net/tulip/de4x5.c 2010-09-14 21:26:52.499474207 -0400
> @@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, stru
> tmp.lval[6] = inl(DE4X5_STRR); j+=4;
> tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
> ioc->len = j;
> - if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
> + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
> break;
>
> #define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
>
While you are at it
if (copy_to_user(ioc->data, tmp.lval, ioc->len))
return -EFAULT;
Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 5:30 ` [PATCH v4] " Dan Rosenberg
@ 2010-09-17 5:34 ` David Miller
2010-09-17 6:36 ` [Security] " Willy Tarreau
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2010-09-17 5:34 UTC (permalink / raw)
To: drosenberg; +Cc: grundler, linux-kernel, netdev, kyle, jeffm, security
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Fri, 17 Sep 2010 01:30:36 -0400
> Tiring doesn't begin to describe it. Formatting undamaged.
:-) Thanks.
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory. Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 5:34 ` David Miller
@ 2010-09-17 6:36 ` Willy Tarreau
2010-09-17 6:37 ` Willy Tarreau
2010-09-17 6:53 ` David Miller
0 siblings, 2 replies; 10+ messages in thread
From: Willy Tarreau @ 2010-09-17 6:36 UTC (permalink / raw)
To: David Miller
Cc: drosenberg, security, grundler, netdev, jeffm, linux-kernel, kyle
On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote:
> From: Dan Rosenberg <drosenberg@vsecurity.com>
> Date: Fri, 17 Sep 2010 01:30:36 -0400
>
> > Tiring doesn't begin to describe it. Formatting undamaged.
>
> :-) Thanks.
>
> > This was previously reported as a security issue due to leakage of
> > uninitialized stack memory. Jeff Mahoney pointed out that this is
> > incorrect since the copied data is from a union (rather than a struct).
> > Therefore, this patch is only under consideration for the sake of
> > correctness, and is not security relevant.
> >
> > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> > Acked-by: Grant Grundler <grundler@parisc-linux.org>
>
> Applied.
David, just for the record, as was already reported on the list, this
fix is finally more a cleanup than a security fix because "tmp" is a
union and not a struct, so tmp.addr == tmp.lval.
Regards,
Willy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 6:36 ` [Security] " Willy Tarreau
@ 2010-09-17 6:37 ` Willy Tarreau
2010-09-17 6:53 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: Willy Tarreau @ 2010-09-17 6:37 UTC (permalink / raw)
To: David Miller
Cc: security, grundler, netdev, drosenberg, jeffm, linux-kernel, kyle
On Fri, Sep 17, 2010 at 08:36:02AM +0200, Willy Tarreau wrote:
> On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote:
> > From: Dan Rosenberg <drosenberg@vsecurity.com>
> > Date: Fri, 17 Sep 2010 01:30:36 -0400
> >
> > > Tiring doesn't begin to describe it. Formatting undamaged.
> >
> > :-) Thanks.
> >
> > > This was previously reported as a security issue due to leakage of
> > > uninitialized stack memory. Jeff Mahoney pointed out that this is
> > > incorrect since the copied data is from a union (rather than a struct).
> > > Therefore, this patch is only under consideration for the sake of
> > > correctness, and is not security relevant.
> > >
> > > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> > > Acked-by: Grant Grundler <grundler@parisc-linux.org>
> >
> > Applied.
>
> David, just for the record, as was already reported on the list, this
> fix is finally more a cleanup than a security fix because "tmp" is a
> union and not a struct, so tmp.addr == tmp.lval.
sorry, that was already explained in the commit message, next time
I'll read it fully before replying :-(
Willy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
2010-09-17 6:36 ` [Security] " Willy Tarreau
2010-09-17 6:37 ` Willy Tarreau
@ 2010-09-17 6:53 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: David Miller @ 2010-09-17 6:53 UTC (permalink / raw)
To: w; +Cc: drosenberg, security, grundler, netdev, jeffm, linux-kernel, kyle
From: Willy Tarreau <w@1wt.eu>
Date: Fri, 17 Sep 2010 08:36:02 +0200
> On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote:
>> From: Dan Rosenberg <drosenberg@vsecurity.com>
>> Date: Fri, 17 Sep 2010 01:30:36 -0400
>>
>> > Tiring doesn't begin to describe it. Formatting undamaged.
>>
>> :-) Thanks.
>>
>> > This was previously reported as a security issue due to leakage of
>> > uninitialized stack memory. Jeff Mahoney pointed out that this is
>> > incorrect since the copied data is from a union (rather than a struct).
>> > Therefore, this patch is only under consideration for the sake of
>> > correctness, and is not security relevant.
>> >
>> > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
>> > Acked-by: Grant Grundler <grundler@parisc-linux.org>
>>
>> Applied.
>
> David, just for the record, as was already reported on the list, this
> fix is finally more a cleanup than a security fix because "tmp" is a
> union and not a struct, so tmp.addr == tmp.lval.
I can read, thanks :-)
That's why I applied it to net-next-2.6 and not net-2.6
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-09-17 6:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-15 21:43 [PATCH v2] drivers/net/tulip/de4x5.c Dan Rosenberg
2010-09-17 4:53 ` David Miller
2010-09-17 5:05 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Dan Rosenberg
2010-09-17 5:27 ` David Miller
2010-09-17 5:30 ` [PATCH v4] " Dan Rosenberg
2010-09-17 5:34 ` David Miller
2010-09-17 6:36 ` [Security] " Willy Tarreau
2010-09-17 6:37 ` Willy Tarreau
2010-09-17 6:53 ` David Miller
2010-09-17 5:31 ` [PATCH v3] " Eric Dumazet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.