* [PATCH] hid: 3m: Output proper orientation range
@ 2010-09-19 8:56 Henrik Rydberg
2010-09-19 23:23 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Henrik Rydberg @ 2010-09-19 8:56 UTC (permalink / raw)
To: Jiri Kosina
Cc: Dmitry Torokhov, Stephane Chatty, linux-input, linux-kernel,
Henrik Rydberg
The range of orientation values for height/width devices should
be [0, 1], but is currently set to [1, 1]. Having min == max also
breaks uinput device setup. Fixed with this patch.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/hid/hid-3m-pct.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
index cd4b125..860d47c 100644
--- a/drivers/hid/hid-3m-pct.c
+++ b/drivers/hid/hid-3m-pct.c
@@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi,
input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR,
f1, f2, df / SN_WIDTH, 0);
input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
- 1, 1, 0, 0);
+ 0, 1, 0, 0);
return 1;
case HID_DG_CONTACTID:
field->logical_maximum = MAX_TRKID;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: 3m: Output proper orientation range
2010-09-19 8:56 [PATCH] hid: 3m: Output proper orientation range Henrik Rydberg
@ 2010-09-19 23:23 ` Dmitry Torokhov
2010-09-21 14:15 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2010-09-19 23:23 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Jiri Kosina, Stephane Chatty, linux-input, linux-kernel
On Sun, Sep 19, 2010 at 10:56:23AM +0200, Henrik Rydberg wrote:
> The range of orientation values for height/width devices should
> be [0, 1], but is currently set to [1, 1]. Having min == max also
> breaks uinput device setup. Fixed with this patch.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Makes sense.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
> ---
> drivers/hid/hid-3m-pct.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
> index cd4b125..860d47c 100644
> --- a/drivers/hid/hid-3m-pct.c
> +++ b/drivers/hid/hid-3m-pct.c
> @@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR,
> f1, f2, df / SN_WIDTH, 0);
> input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
> - 1, 1, 0, 0);
> + 0, 1, 0, 0);
> return 1;
> case HID_DG_CONTACTID:
> field->logical_maximum = MAX_TRKID;
> --
> 1.7.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: 3m: Output proper orientation range
2010-09-19 23:23 ` Dmitry Torokhov
@ 2010-09-21 14:15 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2010-09-21 14:15 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Henrik Rydberg, Stephane Chatty, linux-input, linux-kernel
On Sun, 19 Sep 2010, Dmitry Torokhov wrote:
> > The range of orientation values for height/width devices should
> > be [0, 1], but is currently set to [1, 1]. Having min == max also
> > breaks uinput device setup. Fixed with this patch.
> >
> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
>
> Makes sense.
>
> Acked-by: Dmitry Torokhov <dtor@mail.ru>
Applied, thank you.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-21 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-19 8:56 [PATCH] hid: 3m: Output proper orientation range Henrik Rydberg
2010-09-19 23:23 ` Dmitry Torokhov
2010-09-21 14:15 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.