From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: RE: Description of Voice call history plugin patch
Date: Tue, 21 Sep 2010 11:37:44 +0900 [thread overview]
Message-ID: <1285036664.20811.46.camel@localhost.localdomain> (raw)
In-Reply-To: <E1A1564674E5754FB00AB9AC949D5E3260C826DE47@rrsmsx501.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1955 bytes --]
Hi Raji,
just a friendly reminder here to not do top posting. We are not allowing
this on an open source mailing list. It is a good way of actually
getting ignored ;)
> What is the call history agent idea? Can you explain clearly?
It is like the SIM Toolkit agent, the PIN agent in BlueZ. Read the
documentation and the examples. It is really simple.
In the end an agent is a callback interface inside the UI or an
application outside of oFono. It is were oFono asks for further
information or were it relays information to. In this case the call
history information.
The agent design has the advantage the oFono knows when an agent is
present and when not. So until no agent is present it can spool the
history to disk. And once an agent becomes available replay it to the
agent.
> When the client is up, is the history plug-in sends data instead of any signal? How about acknowledgement for data delivery especially when we are sending data cached on disk?
The agent are like callbacks. They are D-Bus method calls. The
acknowledgment is implicit here with the method return or error in case
of problems.
> If we forefeit the memory mapped idea, is the plugin writing & reading directly from the file?
I personally would just write to the file. However if you wanna do
memory mapped file in round-robin fashion, then that works as well.
However in case of round-robin files you need to think about the memory
layout of your file.
> I will send out a simple algorithm once I understand what you are proprosing and once we are on the same page I will implement that and send you the patch.
Send a D-Bus API document first. See the SIM Toolkit API for an example.
> Can I send the patch with is developer tested code? Does it need to be tested by QA?
You can even send non-working or non-complete code for review at any
time. Just mark them as RFC (request for comments).
Regards
Marcel
prev parent reply other threads:[~2010-09-21 2:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 0:13 Description of Voice call history plugin patch Rajyalakshmi Bommaraju
2010-09-17 0:13 ` [PATCH] plugins: Adding implementation for persisting voice call history Rajyalakshmi Bommaraju
2010-09-17 1:14 ` Marcel Holtmann
2010-09-17 3:17 ` Description of Voice call history plugin patch Denis Kenzior
2010-09-17 6:32 ` Bommaraju, Rajyalakshmi
2010-09-17 8:07 ` Marcel Holtmann
2010-09-17 8:16 ` Marcel Holtmann
2010-09-17 18:00 ` Bommaraju, Rajyalakshmi
2010-09-17 23:41 ` Marcel Holtmann
2010-09-20 18:52 ` Bommaraju, Rajyalakshmi
2010-09-21 2:37 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285036664.20811.46.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.