All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-26  1:05 Kyuho Choi
  2010-09-27  2:58   ` Kyungmin Park
  0 siblings, 1 reply; 16+ messages in thread
From: Kyuho Choi @ 2010-09-26  1:05 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc
  Cc: ben-linux, kgene.kim, Kyuho Choi, Hyunchul Ko

This patch adds to support Torbreck board of aESOP community using
Samsung S5PV210 SoC.

Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
---
 arch/arm/mach-s5pv210/Kconfig         |   18 +++++
 arch/arm/mach-s5pv210/Makefile        |    1 +
 arch/arm/mach-s5pv210/mach-torbreck.c |  133 +++++++++++++++++++++++++++++++++
 3 files changed, 152 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index d3a3895..c5ec466 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -139,6 +139,24 @@ config MACH_SMDKV210
 	help
 	  Machine support for Samsung SMDKV210
 
+config MACH_TORBRECK
+	bool "Torbreck"
+	select CPU_S5PV210
+	select ARCH_SPARSEMEM_ENABLE
+	select S3C_DEV_HSMMC
+	select S3C_DEV_HSMMC1
+	select S3C_DEV_HSMMC2
+	select S3C_DEV_HSMMC3
+	select S3C_DEV_I2C1
+	select S3C_DEV_I2C2
+	select S3C_DEV_RTC
+	select S3C_DEV_WDT
+	select S5PV210_SETUP_I2C1
+	select S5PV210_SETUP_I2C2
+	select S5PV210_SETUP_SDHCI
+	help
+	  Machine support for aESOP Torbreck
+
 endmenu
 
 endif
diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile
index 05048c5..927c2b7 100644
--- a/arch/arm/mach-s5pv210/Makefile
+++ b/arch/arm/mach-s5pv210/Makefile
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)	+= mach-aquila.o
 obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
 obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
+obj-$(CONFIG_MACH_TORBRECK)	+= mach-torbreck.o
 
 # device support
 
diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-s5pv210/mach-torbreck.c
new file mode 100644
index 0000000..3142250
--- /dev/null
+++ b/arch/arm/mach-s5pv210/mach-torbreck.c
@@ -0,0 +1,133 @@
+/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
+ *
+ * Copyright (c) 2010 aESOP Community
+ *		http://www.aesop.or.kr/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+#include <plat/iic.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define TORBRECK_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
+				 S3C2410_UCON_RXILEVEL |	\
+				 S3C2410_UCON_TXIRQMODE |	\
+				 S3C2410_UCON_RXIRQMODE |	\
+				 S3C2410_UCON_RXFIFO_TOI |	\
+				 S3C2443_UCON_RXERR_IRQEN)
+
+#define TORBRECK_ULCON_DEFAULT	S3C2410_LCON_CS8
+
+#define TORBRECK_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
+				 S5PV210_UFCON_TXTRIG4 |	\
+				 S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+	[0] = {
+		.hwport		= 0,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[1] = {
+		.hwport		= 1,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[2] = {
+		.hwport		= 2,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[3] = {
+		.hwport		= 3,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+};
+
+static struct platform_device *torbreck_devices[] __initdata = {
+	&s5pv210_device_iis0,
+	&s3c_device_cfcon,
+	&s3c_device_hsmmc0,
+	&s3c_device_hsmmc1,
+	&s3c_device_hsmmc2,
+	&s3c_device_hsmmc3,
+	&s3c_device_i2c0,
+	&s3c_device_i2c1,
+	&s3c_device_i2c2,
+	&s3c_device_rtc,
+	&s3c_device_wdt,
+};
+
+static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
+	/* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
+	/* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
+	/* To Be Updated */
+};
+
+static void __init torbreck_map_io(void)
+{
+	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+	s3c24xx_init_clocks(24000000);
+	s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));
+}
+
+static void __init torbreck_machine_init(void)
+{
+	s3c_i2c0_set_platdata(NULL);
+	s3c_i2c1_set_platdata(NULL);
+	s3c_i2c2_set_platdata(NULL);
+	i2c_register_board_info(0, torbreck_i2c_devs0,
+			ARRAY_SIZE(torbreck_i2c_devs0));
+	i2c_register_board_info(1, torbreck_i2c_devs1,
+			ARRAY_SIZE(torbreck_i2c_devs1));
+	i2c_register_board_info(2, torbreck_i2c_devs2,
+			ARRAY_SIZE(torbreck_i2c_devs2));
+
+	platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));
+}
+
+MACHINE_START(TORBRECK, "TORBRECK")
+	/* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
+	.phys_io	= S3C_PA_UART & 0xfff00000,
+	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+	.boot_params	= S5P_PA_SDRAM + 0x100,
+	.init_irq	= s5pv210_init_irq,
+	.map_io		= torbreck_map_io,
+	.init_machine	= torbreck_machine_init,
+	.timer		= &s3c24xx_timer,
+MACHINE_END
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-26  1:05 [PATCH] ARM: S5PV210: Add Torbreck board support Kyuho Choi
@ 2010-09-27  2:58   ` Kyungmin Park
  0 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-27  2:58 UTC (permalink / raw)
  To: Kyuho Choi
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux, kgene.kim, Hyunchul Ko

Hi,

Looks good to me except minor fixup.

Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
> This patch adds to support Torbreck board of aESOP community using
> Samsung S5PV210 SoC.
>
> Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> ---
>  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
>  arch/arm/mach-s5pv210/Makefile        |    1 +
>  arch/arm/mach-s5pv210/mach-torbreck.c |  133 +++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
>
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index d3a3895..c5ec466 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -139,6 +139,24 @@ config MACH_SMDKV210
>        help
>          Machine support for Samsung SMDKV210
>
> +config MACH_TORBRECK
> +       bool "Torbreck"
> +       select CPU_S5PV210
> +       select ARCH_SPARSEMEM_ENABLE
> +       select S3C_DEV_HSMMC
> +       select S3C_DEV_HSMMC1
> +       select S3C_DEV_HSMMC2
> +       select S3C_DEV_HSMMC3
> +       select S3C_DEV_I2C1
> +       select S3C_DEV_I2C2
> +       select S3C_DEV_RTC
> +       select S3C_DEV_WDT
> +       select S5PV210_SETUP_I2C1
> +       select S5PV210_SETUP_I2C2
> +       select S5PV210_SETUP_SDHCI
> +       help
> +         Machine support for aESOP Torbreck
Just question. Does it TDROID board?
> +
>  endmenu
>
>  endif
> diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile
> index 05048c5..927c2b7 100644
> --- a/arch/arm/mach-s5pv210/Makefile
> +++ b/arch/arm/mach-s5pv210/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)     += mach-aquila.o
>  obj-$(CONFIG_MACH_SMDKV210)    += mach-smdkv210.o
>  obj-$(CONFIG_MACH_SMDKC110)    += mach-smdkc110.o
>  obj-$(CONFIG_MACH_GONI)                += mach-goni.o
> +obj-$(CONFIG_MACH_TORBRECK)    += mach-torbreck.o
>
>  # device support
>
> diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-s5pv210/mach-torbreck.c
> new file mode 100644
> index 0000000..3142250
> --- /dev/null
> +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> @@ -0,0 +1,133 @@
> +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> + *
> + * Copyright (c) 2010 aESOP Community
> + *             http://www.aesop.or.kr/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/serial_core.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/map.h>
> +#include <asm/setup.h>
> +#include <asm/mach-types.h>
> +
> +#include <mach/map.h>
> +#include <mach/regs-clock.h>
> +
> +#include <plat/regs-serial.h>
> +#include <plat/s5pv210.h>
> +#include <plat/devs.h>
> +#include <plat/cpu.h>
> +#include <plat/iic.h>
> +
> +/* Following are default values for UCON, ULCON and UFCON UART registers */
> +#define TORBRECK_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
> +                                S3C2410_UCON_RXILEVEL |        \
> +                                S3C2410_UCON_TXIRQMODE |       \
> +                                S3C2410_UCON_RXIRQMODE |       \
> +                                S3C2410_UCON_RXFIFO_TOI |      \
> +                                S3C2443_UCON_RXERR_IRQEN)
> +
> +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
> +
> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
> +                                S5PV210_UFCON_TXTRIG4 |        \
> +                                S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.
> +
> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> +       [0] = {
> +               .hwport         = 0,
> +               .flags          = 0,
There's no code for flags, please remove it all.
> +               .ucon           = TORBRECK_UCON_DEFAULT,
> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> +       },
> +       [1] = {
> +               .hwport         = 1,
> +               .flags          = 0,
> +               .ucon           = TORBRECK_UCON_DEFAULT,
> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> +       },
> +       [2] = {
> +               .hwport         = 2,
> +               .flags          = 0,
> +               .ucon           = TORBRECK_UCON_DEFAULT,
> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> +       },
> +       [3] = {
> +               .hwport         = 3,
> +               .flags          = 0,
> +               .ucon           = TORBRECK_UCON_DEFAULT,
> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> +       },
> +};
> +
> +static struct platform_device *torbreck_devices[] __initdata = {
> +       &s5pv210_device_iis0,
> +       &s3c_device_cfcon,
> +       &s3c_device_hsmmc0,
> +       &s3c_device_hsmmc1,
> +       &s3c_device_hsmmc2,
> +       &s3c_device_hsmmc3,
> +       &s3c_device_i2c0,
> +       &s3c_device_i2c1,
> +       &s3c_device_i2c2,
> +       &s3c_device_rtc,
> +       &s3c_device_wdt,
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> +       /* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> +       /* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> +       /* To Be Updated */
> +};
> +
> +static void __init torbreck_map_io(void)
> +{
> +       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> +       s3c24xx_init_clocks(24000000);
> +       s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));
> +}
> +
> +static void __init torbreck_machine_init(void)
> +{
> +       s3c_i2c0_set_platdata(NULL);
> +       s3c_i2c1_set_platdata(NULL);
> +       s3c_i2c2_set_platdata(NULL);
> +       i2c_register_board_info(0, torbreck_i2c_devs0,
> +                       ARRAY_SIZE(torbreck_i2c_devs0));
> +       i2c_register_board_info(1, torbreck_i2c_devs1,
> +                       ARRAY_SIZE(torbreck_i2c_devs1));
> +       i2c_register_board_info(2, torbreck_i2c_devs2,
> +                       ARRAY_SIZE(torbreck_i2c_devs2));
> +
> +       platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));
> +}
> +
> +MACHINE_START(TORBRECK, "TORBRECK")
> +       /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> +       .phys_io        = S3C_PA_UART & 0xfff00000,
> +       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> +       .boot_params    = S5P_PA_SDRAM + 0x100,
> +       .init_irq       = s5pv210_init_irq,
> +       .map_io         = torbreck_map_io,
> +       .init_machine   = torbreck_machine_init,
> +       .timer          = &s3c24xx_timer,
> +MACHINE_END
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-27  2:58   ` Kyungmin Park
  0 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-27  2:58 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Looks good to me except minor fixup.

Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
> This patch adds to support Torbreck board of aESOP community using
> Samsung S5PV210 SoC.
>
> Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> ---
> ?arch/arm/mach-s5pv210/Kconfig ? ? ? ? | ? 18 +++++
> ?arch/arm/mach-s5pv210/Makefile ? ? ? ?| ? ?1 +
> ?arch/arm/mach-s5pv210/mach-torbreck.c | ?133 +++++++++++++++++++++++++++++++++
> ?3 files changed, 152 insertions(+), 0 deletions(-)
> ?create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
>
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index d3a3895..c5ec466 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -139,6 +139,24 @@ config MACH_SMDKV210
> ? ? ? ?help
> ? ? ? ? ?Machine support for Samsung SMDKV210
>
> +config MACH_TORBRECK
> + ? ? ? bool "Torbreck"
> + ? ? ? select CPU_S5PV210
> + ? ? ? select ARCH_SPARSEMEM_ENABLE
> + ? ? ? select S3C_DEV_HSMMC
> + ? ? ? select S3C_DEV_HSMMC1
> + ? ? ? select S3C_DEV_HSMMC2
> + ? ? ? select S3C_DEV_HSMMC3
> + ? ? ? select S3C_DEV_I2C1
> + ? ? ? select S3C_DEV_I2C2
> + ? ? ? select S3C_DEV_RTC
> + ? ? ? select S3C_DEV_WDT
> + ? ? ? select S5PV210_SETUP_I2C1
> + ? ? ? select S5PV210_SETUP_I2C2
> + ? ? ? select S5PV210_SETUP_SDHCI
> + ? ? ? help
> + ? ? ? ? Machine support for aESOP Torbreck
Just question. Does it TDROID board?
> +
> ?endmenu
>
> ?endif
> diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile
> index 05048c5..927c2b7 100644
> --- a/arch/arm/mach-s5pv210/Makefile
> +++ b/arch/arm/mach-s5pv210/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA) ? ? += mach-aquila.o
> ?obj-$(CONFIG_MACH_SMDKV210) ? ?+= mach-smdkv210.o
> ?obj-$(CONFIG_MACH_SMDKC110) ? ?+= mach-smdkc110.o
> ?obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ? ?+= mach-goni.o
> +obj-$(CONFIG_MACH_TORBRECK) ? ?+= mach-torbreck.o
>
> ?# device support
>
> diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-s5pv210/mach-torbreck.c
> new file mode 100644
> index 0000000..3142250
> --- /dev/null
> +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> @@ -0,0 +1,133 @@
> +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> + *
> + * Copyright (c) 2010 aESOP Community
> + * ? ? ? ? ? ? http://www.aesop.or.kr/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/serial_core.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/map.h>
> +#include <asm/setup.h>
> +#include <asm/mach-types.h>
> +
> +#include <mach/map.h>
> +#include <mach/regs-clock.h>
> +
> +#include <plat/regs-serial.h>
> +#include <plat/s5pv210.h>
> +#include <plat/devs.h>
> +#include <plat/cpu.h>
> +#include <plat/iic.h>
> +
> +/* Following are default values for UCON, ULCON and UFCON UART registers */
> +#define TORBRECK_UCON_DEFAULT ?(S3C2410_UCON_TXILEVEL | ? ? ? ?\
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
> +
> +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
> +
> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.
> +
> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> + ? ? ? [0] = {
> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
There's no code for flags, please remove it all.
> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> + ? ? ? },
> + ? ? ? [1] = {
> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> + ? ? ? },
> + ? ? ? [2] = {
> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> + ? ? ? },
> + ? ? ? [3] = {
> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> + ? ? ? },
> +};
> +
> +static struct platform_device *torbreck_devices[] __initdata = {
> + ? ? ? &s5pv210_device_iis0,
> + ? ? ? &s3c_device_cfcon,
> + ? ? ? &s3c_device_hsmmc0,
> + ? ? ? &s3c_device_hsmmc1,
> + ? ? ? &s3c_device_hsmmc2,
> + ? ? ? &s3c_device_hsmmc3,
> + ? ? ? &s3c_device_i2c0,
> + ? ? ? &s3c_device_i2c1,
> + ? ? ? &s3c_device_i2c2,
> + ? ? ? &s3c_device_rtc,
> + ? ? ? &s3c_device_wdt,
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> + ? ? ? /* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> + ? ? ? /* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> + ? ? ? /* To Be Updated */
> +};
> +
> +static void __init torbreck_map_io(void)
> +{
> + ? ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> + ? ? ? s3c24xx_init_clocks(24000000);
> + ? ? ? s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));
> +}
> +
> +static void __init torbreck_machine_init(void)
> +{
> + ? ? ? s3c_i2c0_set_platdata(NULL);
> + ? ? ? s3c_i2c1_set_platdata(NULL);
> + ? ? ? s3c_i2c2_set_platdata(NULL);
> + ? ? ? i2c_register_board_info(0, torbreck_i2c_devs0,
> + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs0));
> + ? ? ? i2c_register_board_info(1, torbreck_i2c_devs1,
> + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs1));
> + ? ? ? i2c_register_board_info(2, torbreck_i2c_devs2,
> + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs2));
> +
> + ? ? ? platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));
> +}
> +
> +MACHINE_START(TORBRECK, "TORBRECK")
> + ? ? ? /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> + ? ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
> + ? ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> + ? ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
> + ? ? ? .init_irq ? ? ? = s5pv210_init_irq,
> + ? ? ? .map_io ? ? ? ? = torbreck_map_io,
> + ? ? ? .init_machine ? = torbreck_machine_init,
> + ? ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
> +MACHINE_END
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-27  2:58   ` Kyungmin Park
@ 2010-09-27 10:10     ` 최규호
  -1 siblings, 0 replies; 16+ messages in thread
From: 최규호 @ 2010-09-27 10:10 UTC (permalink / raw)
  To: Kyungmin Park
  Cc: kgene.kim, Hyunchul Ko, linux-samsung-soc, ben-linux, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 8131 bytes --]

Hi,
Thank you for your interesting.

On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org>wrote:

> Hi,
>
> Looks good to me except minor fixup.
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
> > This patch adds to support Torbreck board of aESOP community using
> > Samsung S5PV210 SoC.
> >
> > Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> > Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> > ---
> >  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
> >  arch/arm/mach-s5pv210/Makefile        |    1 +
> >  arch/arm/mach-s5pv210/mach-torbreck.c |  133
> +++++++++++++++++++++++++++++++++
> >  3 files changed, 152 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
> >
> > diff --git a/arch/arm/mach-s5pv210/Kconfig
> b/arch/arm/mach-s5pv210/Kconfig
> > index d3a3895..c5ec466 100644
> > --- a/arch/arm/mach-s5pv210/Kconfig
> > +++ b/arch/arm/mach-s5pv210/Kconfig
> > @@ -139,6 +139,24 @@ config MACH_SMDKV210
> >        help
> >          Machine support for Samsung SMDKV210
> >
> > +config MACH_TORBRECK
> > +       bool "Torbreck"
> > +       select CPU_S5PV210
> > +       select ARCH_SPARSEMEM_ENABLE
> > +       select S3C_DEV_HSMMC
> > +       select S3C_DEV_HSMMC1
> > +       select S3C_DEV_HSMMC2
> > +       select S3C_DEV_HSMMC3
> > +       select S3C_DEV_I2C1
> > +       select S3C_DEV_I2C2
> > +       select S3C_DEV_RTC
> > +       select S3C_DEV_WDT
> > +       select S5PV210_SETUP_I2C1
> > +       select S5PV210_SETUP_I2C2
> > +       select S5PV210_SETUP_SDHCI
> > +       help
> > +         Machine support for aESOP Torbreck
> Just question. Does it TDROID board?
>

No, Torbreck is aESOP community's co-work board. It's not TDORID.


>  > +
> >  endmenu
> >
> >  endif
> > diff --git a/arch/arm/mach-s5pv210/Makefile
> b/arch/arm/mach-s5pv210/Makefile
> > index 05048c5..927c2b7 100644
> > --- a/arch/arm/mach-s5pv210/Makefile
> > +++ b/arch/arm/mach-s5pv210/Makefile
> > @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)     += mach-aquila.o
> >  obj-$(CONFIG_MACH_SMDKV210)    += mach-smdkv210.o
> >  obj-$(CONFIG_MACH_SMDKC110)    += mach-smdkc110.o
> >  obj-$(CONFIG_MACH_GONI)                += mach-goni.o
> > +obj-$(CONFIG_MACH_TORBRECK)    += mach-torbreck.o
> >
> >  # device support
> >
> > diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c
> b/arch/arm/mach-s5pv210/mach-torbreck.c
> > new file mode 100644
> > index 0000000..3142250
> > --- /dev/null
> > +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> > @@ -0,0 +1,133 @@
> > +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> > + *
> > + * Copyright (c) 2010 aESOP Community
> > + *             http://www.aesop.or.kr/
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > +*/
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/types.h>
> > +#include <linux/i2c.h>
> > +#include <linux/init.h>
> > +#include <linux/serial_core.h>
> > +
> > +#include <asm/mach/arch.h>
> > +#include <asm/mach/map.h>
> > +#include <asm/setup.h>
> > +#include <asm/mach-types.h>
> > +
> > +#include <mach/map.h>
> > +#include <mach/regs-clock.h>
> > +
> > +#include <plat/regs-serial.h>
> > +#include <plat/s5pv210.h>
> > +#include <plat/devs.h>
> > +#include <plat/cpu.h>
> > +#include <plat/iic.h>
> > +
> > +/* Following are default values for UCON, ULCON and UFCON UART registers
> */
> > +#define TORBRECK_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
> > +                                S3C2410_UCON_RXILEVEL |        \
> > +                                S3C2410_UCON_TXIRQMODE |       \
> > +                                S3C2410_UCON_RXIRQMODE |       \
> > +                                S3C2410_UCON_RXFIFO_TOI |      \
> > +                                S3C2443_UCON_RXERR_IRQEN)
> > +
> > +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
> > +
> > +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
> > +                                S5PV210_UFCON_TXTRIG4 |        \
> > +                                S5PV210_UFCON_RXTRIG4)
>
> Any reason to use TRIG4? just use the full trigger e.g., 256.
>

Okay, I'll fix it.


> > +
> > +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> > +       [0] = {
> > +               .hwport         = 0,
> > +               .flags          = 0,
> There's no code for flags, please remove it all.
>

Okay, I'll remove it.


> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>  > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [1] = {
> > +               .hwport         = 1,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [2] = {
> > +               .hwport         = 2,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [3] = {
> > +               .hwport         = 3,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +};
> > +
> > +static struct platform_device *torbreck_devices[] __initdata = {
> > +       &s5pv210_device_iis0,
> > +       &s3c_device_cfcon,
> > +       &s3c_device_hsmmc0,
> > +       &s3c_device_hsmmc1,
> > +       &s3c_device_hsmmc2,
> > +       &s3c_device_hsmmc3,
> > +       &s3c_device_i2c0,
> > +       &s3c_device_i2c1,
> > +       &s3c_device_i2c2,
> > +       &s3c_device_rtc,
> > +       &s3c_device_wdt,
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static void __init torbreck_map_io(void)
> > +{
> > +       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> > +       s3c24xx_init_clocks(24000000);
> > +       s3c24xx_init_uarts(torbreck_uartcfgs,
> ARRAY_SIZE(torbreck_uartcfgs));
> > +}
> > +
> > +static void __init torbreck_machine_init(void)
> > +{
> > +       s3c_i2c0_set_platdata(NULL);
> > +       s3c_i2c1_set_platdata(NULL);
> > +       s3c_i2c2_set_platdata(NULL);
> > +       i2c_register_board_info(0, torbreck_i2c_devs0,
> > +                       ARRAY_SIZE(torbreck_i2c_devs0));
> > +       i2c_register_board_info(1, torbreck_i2c_devs1,
> > +                       ARRAY_SIZE(torbreck_i2c_devs1));
> > +       i2c_register_board_info(2, torbreck_i2c_devs2,
> > +                       ARRAY_SIZE(torbreck_i2c_devs2));
> > +
> > +       platform_add_devices(torbreck_devices,
> ARRAY_SIZE(torbreck_devices));
> > +}
> > +
> > +MACHINE_START(TORBRECK, "TORBRECK")
> > +       /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> > +       .phys_io        = S3C_PA_UART & 0xfff00000,
> > +       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> > +       .boot_params    = S5P_PA_SDRAM + 0x100,
> > +       .init_irq       = s5pv210_init_irq,
> > +       .map_io         = torbreck_map_io,
> > +       .init_machine   = torbreck_machine_init,
> > +       .timer          = &s3c24xx_timer,
> > +MACHINE_END
> > --
> > 1.5.6.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
>

Thanks,
Kyuho Choi

[-- Attachment #1.2: Type: text/html, Size: 11309 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-27 10:10     ` 최규호
  0 siblings, 0 replies; 16+ messages in thread
From: 최규호 @ 2010-09-27 10:10 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,
Thank you for your interesting.

On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org>wrote:

> Hi,
>
> Looks good to me except minor fixup.
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
> > This patch adds to support Torbreck board of aESOP community using
> > Samsung S5PV210 SoC.
> >
> > Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> > Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> > ---
> >  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
> >  arch/arm/mach-s5pv210/Makefile        |    1 +
> >  arch/arm/mach-s5pv210/mach-torbreck.c |  133
> +++++++++++++++++++++++++++++++++
> >  3 files changed, 152 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
> >
> > diff --git a/arch/arm/mach-s5pv210/Kconfig
> b/arch/arm/mach-s5pv210/Kconfig
> > index d3a3895..c5ec466 100644
> > --- a/arch/arm/mach-s5pv210/Kconfig
> > +++ b/arch/arm/mach-s5pv210/Kconfig
> > @@ -139,6 +139,24 @@ config MACH_SMDKV210
> >        help
> >          Machine support for Samsung SMDKV210
> >
> > +config MACH_TORBRECK
> > +       bool "Torbreck"
> > +       select CPU_S5PV210
> > +       select ARCH_SPARSEMEM_ENABLE
> > +       select S3C_DEV_HSMMC
> > +       select S3C_DEV_HSMMC1
> > +       select S3C_DEV_HSMMC2
> > +       select S3C_DEV_HSMMC3
> > +       select S3C_DEV_I2C1
> > +       select S3C_DEV_I2C2
> > +       select S3C_DEV_RTC
> > +       select S3C_DEV_WDT
> > +       select S5PV210_SETUP_I2C1
> > +       select S5PV210_SETUP_I2C2
> > +       select S5PV210_SETUP_SDHCI
> > +       help
> > +         Machine support for aESOP Torbreck
> Just question. Does it TDROID board?
>

No, Torbreck is aESOP community's co-work board. It's not TDORID.


>  > +
> >  endmenu
> >
> >  endif
> > diff --git a/arch/arm/mach-s5pv210/Makefile
> b/arch/arm/mach-s5pv210/Makefile
> > index 05048c5..927c2b7 100644
> > --- a/arch/arm/mach-s5pv210/Makefile
> > +++ b/arch/arm/mach-s5pv210/Makefile
> > @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)     += mach-aquila.o
> >  obj-$(CONFIG_MACH_SMDKV210)    += mach-smdkv210.o
> >  obj-$(CONFIG_MACH_SMDKC110)    += mach-smdkc110.o
> >  obj-$(CONFIG_MACH_GONI)                += mach-goni.o
> > +obj-$(CONFIG_MACH_TORBRECK)    += mach-torbreck.o
> >
> >  # device support
> >
> > diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c
> b/arch/arm/mach-s5pv210/mach-torbreck.c
> > new file mode 100644
> > index 0000000..3142250
> > --- /dev/null
> > +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> > @@ -0,0 +1,133 @@
> > +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> > + *
> > + * Copyright (c) 2010 aESOP Community
> > + *             http://www.aesop.or.kr/
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > +*/
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/types.h>
> > +#include <linux/i2c.h>
> > +#include <linux/init.h>
> > +#include <linux/serial_core.h>
> > +
> > +#include <asm/mach/arch.h>
> > +#include <asm/mach/map.h>
> > +#include <asm/setup.h>
> > +#include <asm/mach-types.h>
> > +
> > +#include <mach/map.h>
> > +#include <mach/regs-clock.h>
> > +
> > +#include <plat/regs-serial.h>
> > +#include <plat/s5pv210.h>
> > +#include <plat/devs.h>
> > +#include <plat/cpu.h>
> > +#include <plat/iic.h>
> > +
> > +/* Following are default values for UCON, ULCON and UFCON UART registers
> */
> > +#define TORBRECK_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
> > +                                S3C2410_UCON_RXILEVEL |        \
> > +                                S3C2410_UCON_TXIRQMODE |       \
> > +                                S3C2410_UCON_RXIRQMODE |       \
> > +                                S3C2410_UCON_RXFIFO_TOI |      \
> > +                                S3C2443_UCON_RXERR_IRQEN)
> > +
> > +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
> > +
> > +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
> > +                                S5PV210_UFCON_TXTRIG4 |        \
> > +                                S5PV210_UFCON_RXTRIG4)
>
> Any reason to use TRIG4? just use the full trigger e.g., 256.
>

Okay, I'll fix it.


> > +
> > +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> > +       [0] = {
> > +               .hwport         = 0,
> > +               .flags          = 0,
> There's no code for flags, please remove it all.
>

Okay, I'll remove it.


> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>  > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [1] = {
> > +               .hwport         = 1,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [2] = {
> > +               .hwport         = 2,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +       [3] = {
> > +               .hwport         = 3,
> > +               .flags          = 0,
> > +               .ucon           = TORBRECK_UCON_DEFAULT,
> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> > +       },
> > +};
> > +
> > +static struct platform_device *torbreck_devices[] __initdata = {
> > +       &s5pv210_device_iis0,
> > +       &s3c_device_cfcon,
> > +       &s3c_device_hsmmc0,
> > +       &s3c_device_hsmmc1,
> > +       &s3c_device_hsmmc2,
> > +       &s3c_device_hsmmc3,
> > +       &s3c_device_i2c0,
> > +       &s3c_device_i2c1,
> > +       &s3c_device_i2c2,
> > +       &s3c_device_rtc,
> > +       &s3c_device_wdt,
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> > +       /* To Be Updated */
> > +};
> > +
> > +static void __init torbreck_map_io(void)
> > +{
> > +       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> > +       s3c24xx_init_clocks(24000000);
> > +       s3c24xx_init_uarts(torbreck_uartcfgs,
> ARRAY_SIZE(torbreck_uartcfgs));
> > +}
> > +
> > +static void __init torbreck_machine_init(void)
> > +{
> > +       s3c_i2c0_set_platdata(NULL);
> > +       s3c_i2c1_set_platdata(NULL);
> > +       s3c_i2c2_set_platdata(NULL);
> > +       i2c_register_board_info(0, torbreck_i2c_devs0,
> > +                       ARRAY_SIZE(torbreck_i2c_devs0));
> > +       i2c_register_board_info(1, torbreck_i2c_devs1,
> > +                       ARRAY_SIZE(torbreck_i2c_devs1));
> > +       i2c_register_board_info(2, torbreck_i2c_devs2,
> > +                       ARRAY_SIZE(torbreck_i2c_devs2));
> > +
> > +       platform_add_devices(torbreck_devices,
> ARRAY_SIZE(torbreck_devices));
> > +}
> > +
> > +MACHINE_START(TORBRECK, "TORBRECK")
> > +       /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> > +       .phys_io        = S3C_PA_UART & 0xfff00000,
> > +       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> > +       .boot_params    = S5P_PA_SDRAM + 0x100,
> > +       .init_irq       = s5pv210_init_irq,
> > +       .map_io         = torbreck_map_io,
> > +       .init_machine   = torbreck_machine_init,
> > +       .timer          = &s3c24xx_timer,
> > +MACHINE_END
> > --
> > 1.5.6.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
>

Thanks,
Kyuho Choi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100927/f6649004/attachment-0001.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-27 10:10     ` 최규호
@ 2010-09-27 10:39       ` Kyungmin Park
  -1 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-27 10:39 UTC (permalink / raw)
  To: 최규호
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux, kgene.kim, Hyunchul Ko

On Mon, Sep 27, 2010 at 7:10 PM, 최규호 <chlrbgh0@gmail.com> wrote:
> Hi,
> Thank you for your interesting.
>
> On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org>
> wrote:
>>
>> Hi,
>>
>> Looks good to me except minor fixup.
>>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
>> > This patch adds to support Torbreck board of aESOP community using
>> > Samsung S5PV210 SoC.
>> >
>> > Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
>> > Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
>> > ---
>> >  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
>> >  arch/arm/mach-s5pv210/Makefile        |    1 +
>> >  arch/arm/mach-s5pv210/mach-torbreck.c |  133
>> > +++++++++++++++++++++++++++++++++
>> >  3 files changed, 152 insertions(+), 0 deletions(-)
>> >  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
>> >
>> > diff --git a/arch/arm/mach-s5pv210/Kconfig
>> > b/arch/arm/mach-s5pv210/Kconfig
>> > index d3a3895..c5ec466 100644
>> > --- a/arch/arm/mach-s5pv210/Kconfig
>> > +++ b/arch/arm/mach-s5pv210/Kconfig
>> > @@ -139,6 +139,24 @@ config MACH_SMDKV210
>> >        help
>> >          Machine support for Samsung SMDKV210
>> >
>> > +config MACH_TORBRECK
>> > +       bool "Torbreck"
>> > +       select CPU_S5PV210
>> > +       select ARCH_SPARSEMEM_ENABLE
>> > +       select S3C_DEV_HSMMC
>> > +       select S3C_DEV_HSMMC1
>> > +       select S3C_DEV_HSMMC2
>> > +       select S3C_DEV_HSMMC3
>> > +       select S3C_DEV_I2C1
>> > +       select S3C_DEV_I2C2
>> > +       select S3C_DEV_RTC
>> > +       select S3C_DEV_WDT
>> > +       select S5PV210_SETUP_I2C1
>> > +       select S5PV210_SETUP_I2C2
>> > +       select S5PV210_SETUP_SDHCI
>> > +       help
>> > +         Machine support for aESOP Torbreck
>> Just question. Does it TDROID board?
>
>
> No, Torbreck is aESOP community's co-work board. It's not TDORID.
Then can I get the schematics or information for this board?
e.g., LCD resolution. SD/MMC configuration USB, and so on.

Thank you,
Kyungmin Park
>
>>
>> > +
>> >  endmenu
>> >
>> >  endif
>> > diff --git a/arch/arm/mach-s5pv210/Makefile
>> > b/arch/arm/mach-s5pv210/Makefile
>> > index 05048c5..927c2b7 100644
>> > --- a/arch/arm/mach-s5pv210/Makefile
>> > +++ b/arch/arm/mach-s5pv210/Makefile
>> > @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)     += mach-aquila.o
>> >  obj-$(CONFIG_MACH_SMDKV210)    += mach-smdkv210.o
>> >  obj-$(CONFIG_MACH_SMDKC110)    += mach-smdkc110.o
>> >  obj-$(CONFIG_MACH_GONI)                += mach-goni.o
>> > +obj-$(CONFIG_MACH_TORBRECK)    += mach-torbreck.o
>> >
>> >  # device support
>> >
>> > diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c
>> > b/arch/arm/mach-s5pv210/mach-torbreck.c
>> > new file mode 100644
>> > index 0000000..3142250
>> > --- /dev/null
>> > +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
>> > @@ -0,0 +1,133 @@
>> > +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
>> > + *
>> > + * Copyright (c) 2010 aESOP Community
>> > + *             http://www.aesop.or.kr/
>> > + *
>> > + * This program is free software; you can redistribute it and/or modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation.
>> > +*/
>> > +
>> > +#include <linux/kernel.h>
>> > +#include <linux/types.h>
>> > +#include <linux/i2c.h>
>> > +#include <linux/init.h>
>> > +#include <linux/serial_core.h>
>> > +
>> > +#include <asm/mach/arch.h>
>> > +#include <asm/mach/map.h>
>> > +#include <asm/setup.h>
>> > +#include <asm/mach-types.h>
>> > +
>> > +#include <mach/map.h>
>> > +#include <mach/regs-clock.h>
>> > +
>> > +#include <plat/regs-serial.h>
>> > +#include <plat/s5pv210.h>
>> > +#include <plat/devs.h>
>> > +#include <plat/cpu.h>
>> > +#include <plat/iic.h>
>> > +
>> > +/* Following are default values for UCON, ULCON and UFCON UART
>> > registers */
>> > +#define TORBRECK_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
>> > +                                S3C2410_UCON_RXILEVEL |        \
>> > +                                S3C2410_UCON_TXIRQMODE |       \
>> > +                                S3C2410_UCON_RXIRQMODE |       \
>> > +                                S3C2410_UCON_RXFIFO_TOI |      \
>> > +                                S3C2443_UCON_RXERR_IRQEN)
>> > +
>> > +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
>> > +
>> > +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
>> > +                                S5PV210_UFCON_TXTRIG4 |        \
>> > +                                S5PV210_UFCON_RXTRIG4)
>>
>> Any reason to use TRIG4? just use the full trigger e.g., 256.
>
>
> Okay, I'll fix it.
>
>>
>> > +
>> > +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>> > +       [0] = {
>> > +               .hwport         = 0,
>> > +               .flags          = 0,
>> There's no code for flags, please remove it all.
>
>
> Okay, I'll remove it.
>
>>
>> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> > +       },
>> > +       [1] = {
>> > +               .hwport         = 1,
>> > +               .flags          = 0,
>> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> > +       },
>> > +       [2] = {
>> > +               .hwport         = 2,
>> > +               .flags          = 0,
>> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> > +       },
>> > +       [3] = {
>> > +               .hwport         = 3,
>> > +               .flags          = 0,
>> > +               .ucon           = TORBRECK_UCON_DEFAULT,
>> > +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> > +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> > +       },
>> > +};
>> > +
>> > +static struct platform_device *torbreck_devices[] __initdata = {
>> > +       &s5pv210_device_iis0,
>> > +       &s3c_device_cfcon,
>> > +       &s3c_device_hsmmc0,
>> > +       &s3c_device_hsmmc1,
>> > +       &s3c_device_hsmmc2,
>> > +       &s3c_device_hsmmc3,
>> > +       &s3c_device_i2c0,
>> > +       &s3c_device_i2c1,
>> > +       &s3c_device_i2c2,
>> > +       &s3c_device_rtc,
>> > +       &s3c_device_wdt,
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
>> > +       /* To Be Updated */
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
>> > +       /* To Be Updated */
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
>> > +       /* To Be Updated */
>> > +};
>> > +
>> > +static void __init torbreck_map_io(void)
>> > +{
>> > +       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
>> > +       s3c24xx_init_clocks(24000000);
>> > +       s3c24xx_init_uarts(torbreck_uartcfgs,
>> > ARRAY_SIZE(torbreck_uartcfgs));
>> > +}
>> > +
>> > +static void __init torbreck_machine_init(void)
>> > +{
>> > +       s3c_i2c0_set_platdata(NULL);
>> > +       s3c_i2c1_set_platdata(NULL);
>> > +       s3c_i2c2_set_platdata(NULL);
>> > +       i2c_register_board_info(0, torbreck_i2c_devs0,
>> > +                       ARRAY_SIZE(torbreck_i2c_devs0));
>> > +       i2c_register_board_info(1, torbreck_i2c_devs1,
>> > +                       ARRAY_SIZE(torbreck_i2c_devs1));
>> > +       i2c_register_board_info(2, torbreck_i2c_devs2,
>> > +                       ARRAY_SIZE(torbreck_i2c_devs2));
>> > +
>> > +       platform_add_devices(torbreck_devices,
>> > ARRAY_SIZE(torbreck_devices));
>> > +}
>> > +
>> > +MACHINE_START(TORBRECK, "TORBRECK")
>> > +       /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
>> > +       .phys_io        = S3C_PA_UART & 0xfff00000,
>> > +       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
>> > +       .boot_params    = S5P_PA_SDRAM + 0x100,
>> > +       .init_irq       = s5pv210_init_irq,
>> > +       .map_io         = torbreck_map_io,
>> > +       .init_machine   = torbreck_machine_init,
>> > +       .timer          = &s3c24xx_timer,
>> > +MACHINE_END
>> > --
>> > 1.5.6.3
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>> > linux-samsung-soc" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> >
>
> Thanks,
> Kyuho Choi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-27 10:39       ` Kyungmin Park
  0 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-27 10:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 27, 2010 at 7:10 PM, ??? <chlrbgh0@gmail.com> wrote:
> Hi,
> Thank you for your interesting.
>
> On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org>
> wrote:
>>
>> Hi,
>>
>> Looks good to me except minor fixup.
>>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <chlrbgh0@gmail.com> wrote:
>> > This patch adds to support Torbreck board of aESOP community using
>> > Samsung S5PV210 SoC.
>> >
>> > Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
>> > Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
>> > ---
>> > ?arch/arm/mach-s5pv210/Kconfig ? ? ? ? | ? 18 +++++
>> > ?arch/arm/mach-s5pv210/Makefile ? ? ? ?| ? ?1 +
>> > ?arch/arm/mach-s5pv210/mach-torbreck.c | ?133
>> > +++++++++++++++++++++++++++++++++
>> > ?3 files changed, 152 insertions(+), 0 deletions(-)
>> > ?create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
>> >
>> > diff --git a/arch/arm/mach-s5pv210/Kconfig
>> > b/arch/arm/mach-s5pv210/Kconfig
>> > index d3a3895..c5ec466 100644
>> > --- a/arch/arm/mach-s5pv210/Kconfig
>> > +++ b/arch/arm/mach-s5pv210/Kconfig
>> > @@ -139,6 +139,24 @@ config MACH_SMDKV210
>> > ? ? ? ?help
>> > ? ? ? ? ?Machine support for Samsung SMDKV210
>> >
>> > +config MACH_TORBRECK
>> > + ? ? ? bool "Torbreck"
>> > + ? ? ? select CPU_S5PV210
>> > + ? ? ? select ARCH_SPARSEMEM_ENABLE
>> > + ? ? ? select S3C_DEV_HSMMC
>> > + ? ? ? select S3C_DEV_HSMMC1
>> > + ? ? ? select S3C_DEV_HSMMC2
>> > + ? ? ? select S3C_DEV_HSMMC3
>> > + ? ? ? select S3C_DEV_I2C1
>> > + ? ? ? select S3C_DEV_I2C2
>> > + ? ? ? select S3C_DEV_RTC
>> > + ? ? ? select S3C_DEV_WDT
>> > + ? ? ? select S5PV210_SETUP_I2C1
>> > + ? ? ? select S5PV210_SETUP_I2C2
>> > + ? ? ? select S5PV210_SETUP_SDHCI
>> > + ? ? ? help
>> > + ? ? ? ? Machine support for aESOP Torbreck
>> Just question. Does it TDROID board?
>
>
> No, Torbreck is aESOP community's co-work board. It's not?TDORID.
Then can I get the schematics or information for this board?
e.g., LCD resolution. SD/MMC configuration USB, and so on.

Thank you,
Kyungmin Park
>
>>
>> > +
>> > ?endmenu
>> >
>> > ?endif
>> > diff --git a/arch/arm/mach-s5pv210/Makefile
>> > b/arch/arm/mach-s5pv210/Makefile
>> > index 05048c5..927c2b7 100644
>> > --- a/arch/arm/mach-s5pv210/Makefile
>> > +++ b/arch/arm/mach-s5pv210/Makefile
>> > @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA) ? ? += mach-aquila.o
>> > ?obj-$(CONFIG_MACH_SMDKV210) ? ?+= mach-smdkv210.o
>> > ?obj-$(CONFIG_MACH_SMDKC110) ? ?+= mach-smdkc110.o
>> > ?obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ? ?+= mach-goni.o
>> > +obj-$(CONFIG_MACH_TORBRECK) ? ?+= mach-torbreck.o
>> >
>> > ?# device support
>> >
>> > diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c
>> > b/arch/arm/mach-s5pv210/mach-torbreck.c
>> > new file mode 100644
>> > index 0000000..3142250
>> > --- /dev/null
>> > +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
>> > @@ -0,0 +1,133 @@
>> > +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
>> > + *
>> > + * Copyright (c) 2010 aESOP Community
>> > + * ? ? ? ? ? ? http://www.aesop.or.kr/
>> > + *
>> > + * This program is free software; you can redistribute it and/or modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation.
>> > +*/
>> > +
>> > +#include <linux/kernel.h>
>> > +#include <linux/types.h>
>> > +#include <linux/i2c.h>
>> > +#include <linux/init.h>
>> > +#include <linux/serial_core.h>
>> > +
>> > +#include <asm/mach/arch.h>
>> > +#include <asm/mach/map.h>
>> > +#include <asm/setup.h>
>> > +#include <asm/mach-types.h>
>> > +
>> > +#include <mach/map.h>
>> > +#include <mach/regs-clock.h>
>> > +
>> > +#include <plat/regs-serial.h>
>> > +#include <plat/s5pv210.h>
>> > +#include <plat/devs.h>
>> > +#include <plat/cpu.h>
>> > +#include <plat/iic.h>
>> > +
>> > +/* Following are default values for UCON, ULCON and UFCON UART
>> > registers */
>> > +#define TORBRECK_UCON_DEFAULT ?(S3C2410_UCON_TXILEVEL | ? ? ? ?\
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
>> > +
>> > +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
>> > +
>> > +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)
>>
>> Any reason to use TRIG4? just use the full trigger e.g., 256.
>
>
> Okay, I'll fix it.
>
>>
>> > +
>> > +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>> > + ? ? ? [0] = {
>> > + ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
>> > + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>> There's no code for flags, please remove it all.
>
>
> Okay, I'll remove it.
>
>>
>> > + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>> > + ? ? ? },
>> > + ? ? ? [1] = {
>> > + ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
>> > + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>> > + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>> > + ? ? ? },
>> > + ? ? ? [2] = {
>> > + ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
>> > + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>> > + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>> > + ? ? ? },
>> > + ? ? ? [3] = {
>> > + ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
>> > + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>> > + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>> > + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>> > + ? ? ? },
>> > +};
>> > +
>> > +static struct platform_device *torbreck_devices[] __initdata = {
>> > + ? ? ? &s5pv210_device_iis0,
>> > + ? ? ? &s3c_device_cfcon,
>> > + ? ? ? &s3c_device_hsmmc0,
>> > + ? ? ? &s3c_device_hsmmc1,
>> > + ? ? ? &s3c_device_hsmmc2,
>> > + ? ? ? &s3c_device_hsmmc3,
>> > + ? ? ? &s3c_device_i2c0,
>> > + ? ? ? &s3c_device_i2c1,
>> > + ? ? ? &s3c_device_i2c2,
>> > + ? ? ? &s3c_device_rtc,
>> > + ? ? ? &s3c_device_wdt,
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
>> > + ? ? ? /* To Be Updated */
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
>> > + ? ? ? /* To Be Updated */
>> > +};
>> > +
>> > +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
>> > + ? ? ? /* To Be Updated */
>> > +};
>> > +
>> > +static void __init torbreck_map_io(void)
>> > +{
>> > + ? ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
>> > + ? ? ? s3c24xx_init_clocks(24000000);
>> > + ? ? ? s3c24xx_init_uarts(torbreck_uartcfgs,
>> > ARRAY_SIZE(torbreck_uartcfgs));
>> > +}
>> > +
>> > +static void __init torbreck_machine_init(void)
>> > +{
>> > + ? ? ? s3c_i2c0_set_platdata(NULL);
>> > + ? ? ? s3c_i2c1_set_platdata(NULL);
>> > + ? ? ? s3c_i2c2_set_platdata(NULL);
>> > + ? ? ? i2c_register_board_info(0, torbreck_i2c_devs0,
>> > + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs0));
>> > + ? ? ? i2c_register_board_info(1, torbreck_i2c_devs1,
>> > + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs1));
>> > + ? ? ? i2c_register_board_info(2, torbreck_i2c_devs2,
>> > + ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs2));
>> > +
>> > + ? ? ? platform_add_devices(torbreck_devices,
>> > ARRAY_SIZE(torbreck_devices));
>> > +}
>> > +
>> > +MACHINE_START(TORBRECK, "TORBRECK")
>> > + ? ? ? /* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
>> > + ? ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
>> > + ? ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
>> > + ? ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
>> > + ? ? ? .init_irq ? ? ? = s5pv210_init_irq,
>> > + ? ? ? .map_io ? ? ? ? = torbreck_map_io,
>> > + ? ? ? .init_machine ? = torbreck_machine_init,
>> > + ? ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
>> > +MACHINE_END
>> > --
>> > 1.5.6.3
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>> > linux-samsung-soc" in
>> > the body of a message to majordomo at vger.kernel.org
>> > More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>> >
>
> Thanks,
> Kyuho Choi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-27 10:10     ` 최규호
@ 2010-09-28  5:55       ` Kukjin Kim
  -1 siblings, 0 replies; 16+ messages in thread
From: Kukjin Kim @ 2010-09-28  5:55 UTC (permalink / raw)
  To: '최규호', 'Kyungmin Park'
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux, 'Hyunchul Ko'

최규호 wrote:
Hi, 

Welcome to Linux mainline ;-)
I have some comments about your patches.

Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
And make sure it's text type.

>Hi,
>Thank you for your interesting.
>On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:

(snip)

>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
>> +                                S5PV210_UFCON_TXTRIG4 |        \
>> +                                S5PV210_UFCON_RXTRIG4)
>Any reason to use TRIG4? just use the full trigger e.g., 256.
> 
>Okay, I'll fix it.
> 
Hmm...Kyungmin, any reason to use full trigger here?

It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
It means the maximum value is not best condition...only depends on your situation/condition.

>> +
>> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>> +       [0] = {
>> +               .hwport         = 0,
>> +               .flags          = 0,
>There's no code for flags, please remove it all.
> 
>Okay, I'll remove it.
> 
I think no need to modify it.
Actually I said many times about this...

And as Ben Dooks said in other patch, the format will be changed soon.

>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [1] = {
>> +               .hwport         = 1,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [2] = {
>> +               .hwport         = 2,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [3] = {
>> +               .hwport         = 3,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +};
>> +

(snip)

>> --
>> 1.5.6.3
>>
If possible, please use later version git.
It doesn't mean latest git is best...
This is just private opinion. :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-28  5:55       ` Kukjin Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Kukjin Kim @ 2010-09-28  5:55 UTC (permalink / raw)
  To: linux-arm-kernel

??? wrote:
Hi, 

Welcome to Linux mainline ;-)
I have some comments about your patches.

Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
And make sure it's text type.

>Hi,
>Thank you for your interesting.
>On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:

(snip)

>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
>> +                                S5PV210_UFCON_TXTRIG4 |        \
>> +                                S5PV210_UFCON_RXTRIG4)
>Any reason to use TRIG4? just use the full trigger e.g., 256.
> 
>Okay, I'll fix it.
> 
Hmm...Kyungmin, any reason to use full trigger here?

It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
It means the maximum value is not best condition...only depends on your situation/condition.

>> +
>> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>> +       [0] = {
>> +               .hwport         = 0,
>> +               .flags          = 0,
>There's no code for flags, please remove it all.
> 
>Okay, I'll remove it.
> 
I think no need to modify it.
Actually I said many times about this...

And as Ben Dooks said in other patch, the format will be changed soon.

>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [1] = {
>> +               .hwport         = 1,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [2] = {
>> +               .hwport         = 2,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +       [3] = {
>> +               .hwport         = 3,
>> +               .flags          = 0,
>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>> +       },
>> +};
>> +

(snip)

>> --
>> 1.5.6.3
>>
If possible, please use later version git.
It doesn't mean latest git is best...
This is just private opinion. :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-28  5:55       ` Kukjin Kim
@ 2010-09-28  6:12         ` Kyungmin Park
  -1 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-28  6:12 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: 최규호,
	linux-arm-kernel, linux-samsung-soc, ben-linux, Hyunchul Ko

On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> 최규호 wrote:
> Hi,
>
> Welcome to Linux mainline ;-)
> I have some comments about your patches.
>
> Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
> And make sure it's text type.
>
>>Hi,
>>Thank you for your interesting.
>>On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>
> (snip)
>
>>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
>>> +                                S5PV210_UFCON_TXTRIG4 |        \
>>> +                                S5PV210_UFCON_RXTRIG4)
>>Any reason to use TRIG4? just use the full trigger e.g., 256.
>>
>>Okay, I'll fix it.
>>
> Hmm...Kyungmin, any reason to use full trigger here?
>
> It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
> It means the maximum value is not best condition...only depends on your situation/condition.

So I ask ANY REASON to use TRIG4?
And my opinions,
First. it's not true for all UARTs. it's only valid on UART0.
Second, "the maximum value is not best condition" then why Spec said
"increase the FIFO size for performance".

>
>>> +
>>> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>>> +       [0] = {
>>> +               .hwport         = 0,
>>> +               .flags          = 0,
>>There's no code for flags, please remove it all.
>>
>>Okay, I'll remove it.
>>
> I think no need to modify it.
> Actually I said many times about this...
>
> And as Ben Dooks said in other patch, the format will be changed soon.

I always listen "will be changed" so until that time use the correct code.
Don't add the meaningless codes.

Thank you,
Kyungmin Park
>
>>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>>> +       },
>>> +       [1] = {
>>> +               .hwport         = 1,
>>> +               .flags          = 0,
>>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>>> +       },
>>> +       [2] = {
>>> +               .hwport         = 2,
>>> +               .flags          = 0,
>>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>>> +       },
>>> +       [3] = {
>>> +               .hwport         = 3,
>>> +               .flags          = 0,
>>> +               .ucon           = TORBRECK_UCON_DEFAULT,
>>> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
>>> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
>>> +       },
>>> +};
>>> +
>
> (snip)
>
>>> --
>>> 1.5.6.3
>>>
> If possible, please use later version git.
> It doesn't mean latest git is best...
> This is just private opinion. :-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-28  6:12         ` Kyungmin Park
  0 siblings, 0 replies; 16+ messages in thread
From: Kyungmin Park @ 2010-09-28  6:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> ??? wrote:
> Hi,
>
> Welcome to Linux mainline ;-)
> I have some comments about your patches.
>
> Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
> And make sure it's text type.
>
>>Hi,
>>Thank you for your interesting.
>>On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>
> (snip)
>
>>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)
>>Any reason to use TRIG4? just use the full trigger e.g., 256.
>>
>>Okay, I'll fix it.
>>
> Hmm...Kyungmin, any reason to use full trigger here?
>
> It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
> It means the maximum value is not best condition...only depends on your situation/condition.

So I ask ANY REASON to use TRIG4?
And my opinions,
First. it's not true for all UARTs. it's only valid on UART0.
Second, "the maximum value is not best condition" then why Spec said
"increase the FIFO size for performance".

>
>>> +
>>> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
>>> + ? ? ? [0] = {
>>> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
>>> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>>There's no code for flags, please remove it all.
>>
>>Okay, I'll remove it.
>>
> I think no need to modify it.
> Actually I said many times about this...
>
> And as Ben Dooks said in other patch, the format will be changed soon.

I always listen "will be changed" so until that time use the correct code.
Don't add the meaningless codes.

Thank you,
Kyungmin Park
>
>>> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>>> + ? ? ? },
>>> + ? ? ? [1] = {
>>> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
>>> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>>> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>>> + ? ? ? },
>>> + ? ? ? [2] = {
>>> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
>>> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>>> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>>> + ? ? ? },
>>> + ? ? ? [3] = {
>>> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
>>> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
>>> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
>>> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
>>> + ? ? ? },
>>> +};
>>> +
>
> (snip)
>
>>> --
>>> 1.5.6.3
>>>
> If possible, please use later version git.
> It doesn't mean latest git is best...
> This is just private opinion. :-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-28  5:55       ` Kukjin Kim
@ 2010-09-28 11:30         ` 최규호
  -1 siblings, 0 replies; 16+ messages in thread
From: 최규호 @ 2010-09-28 11:30 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: Kyungmin Park, linux-arm-kernel, linux-samsung-soc, ben-linux,
	Hyunchul Ko

On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>
> 최규호 wrote:
> Hi,
>
> Welcome to Linux mainline ;-)
> I have some comments about your patches.
>
> Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
> And make sure it's text type.
>
> >Hi,
> >Thank you for your interesting.
> >On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>
> (snip)
>
> >> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
> >> +                                S5PV210_UFCON_TXTRIG4 |        \
> >> +                                S5PV210_UFCON_RXTRIG4)
> >Any reason to use TRIG4? just use the full trigger e.g., 256.
> >
> >Okay, I'll fix it.
> >
> Hmm...Kyungmin, any reason to use full trigger here?
>
> It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
> It means the maximum value is not best condition...only depends on your situation/condition.
>

Okay, if this is not a mandatory, I want to keep this original, I had no problem
with this setting when I tested.

> >> +
> >> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> >> +       [0] = {
> >> +               .hwport         = 0,
> >> +               .flags          = 0,
> >There's no code for flags, please remove it all.
> >
> >Okay, I'll remove it.
> >
> I think no need to modify it.
> Actually I said many times about this...
>
> And as Ben Dooks said in other patch, the format will be changed soon.
>

This also, I don't want to take _unknown_ side effects to modify this alone. :(
Actually, others(smdks, aquilla, goni) are also set this field. So, I hope this
also modify with Ben's other patch that you mentioned.

> >> +               .ucon           = TORBRECK_UCON_DEFAULT,
> >> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> >> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> >> +       },
> >> +       [1] = {
> >> +               .hwport         = 1,
> >> +               .flags          = 0,
> >> +               .ucon           = TORBRECK_UCON_DEFAULT,
> >> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> >> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> >> +       },
> >> +       [2] = {
> >> +               .hwport         = 2,
> >> +               .flags          = 0,
> >> +               .ucon           = TORBRECK_UCON_DEFAULT,
> >> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> >> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> >> +       },
> >> +       [3] = {
> >> +               .hwport         = 3,
> >> +               .flags          = 0,
> >> +               .ucon           = TORBRECK_UCON_DEFAULT,
> >> +               .ulcon          = TORBRECK_ULCON_DEFAULT,
> >> +               .ufcon          = TORBRECK_UFCON_DEFAULT,
> >> +       },
> >> +};
> >> +
>
> (snip)
>
> >> --
> >> 1.5.6.3
> >>
> If possible, please use later version git.
> It doesn't mean latest git is best...
> This is just private opinion. :-)

Yes. :-)

Thanks,
Kyuho Choi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-28 11:30         ` 최규호
  0 siblings, 0 replies; 16+ messages in thread
From: 최규호 @ 2010-09-28 11:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>
> ??? wrote:
> Hi,
>
> Welcome to Linux mainline ;-)
> I have some comments about your patches.
>
> Firstly could you please use English character in the representing name in e-mail client not Korean character :-)
> And make sure it's text type.
>
> >Hi,
> >Thank you for your interesting.
> >On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>
> (snip)
>
> >> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)
> >Any reason to use TRIG4? just use the full trigger e.g., 256.
> >
> >Okay, I'll fix it.
> >
> Hmm...Kyungmin, any reason to use full trigger here?
>
> It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board.
> It means the maximum value is not best condition...only depends on your situation/condition.
>

Okay, if this is not a mandatory, I want to keep this original, I had no problem
with this setting when I tested.

> >> +
> >> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> >> + ? ? ? [0] = {
> >> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
> >> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> >There's no code for flags, please remove it all.
> >
> >Okay, I'll remove it.
> >
> I think no need to modify it.
> Actually I said many times about this...
>
> And as Ben Dooks said in other patch, the format will be changed soon.
>

This also, I don't want to take _unknown_ side effects to modify this alone. :(
Actually, others(smdks, aquilla, goni) are also set this field. So, I hope this
also modify with Ben's other patch that you mentioned.

> >> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> >> + ? ? ? },
> >> + ? ? ? [1] = {
> >> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
> >> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> >> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> >> + ? ? ? },
> >> + ? ? ? [2] = {
> >> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
> >> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> >> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> >> + ? ? ? },
> >> + ? ? ? [3] = {
> >> + ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
> >> + ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
> >> + ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
> >> + ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
> >> + ? ? ? },
> >> +};
> >> +
>
> (snip)
>
> >> --
> >> 1.5.6.3
> >>
> If possible, please use later version git.
> It doesn't mean latest git is best...
> This is just private opinion. :-)

Yes. :-)

Thanks,
Kyuho Choi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH] ARM: S5PV210: Add Torbreck board support
  2010-09-26 16:32 Kyuho Choi
@ 2010-09-29 12:07   ` Kukjin Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Kukjin Kim @ 2010-09-29 12:07 UTC (permalink / raw)
  To: 'Kyuho Choi', linux-arm-kernel
  Cc: ben-linux, 'Hyunchul Ko', linux-samsung-soc

Kyuho Choi wrote:
> 
> This patch adds to support Torbreck board of aESOP community using
> Samsung S5PV210 SoC.
> 
> Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> ---
>  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
>  arch/arm/mach-s5pv210/Makefile        |    1 +
>  arch/arm/mach-s5pv210/mach-torbreck.c |  133
> +++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
> 
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index d3a3895..c5ec466 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -139,6 +139,24 @@ config MACH_SMDKV210
>  	help
>  	  Machine support for Samsung SMDKV210
> 
> +config MACH_TORBRECK
> +	bool "Torbreck"
> +	select CPU_S5PV210
> +	select ARCH_SPARSEMEM_ENABLE
> +	select S3C_DEV_HSMMC
> +	select S3C_DEV_HSMMC1
> +	select S3C_DEV_HSMMC2
> +	select S3C_DEV_HSMMC3
> +	select S3C_DEV_I2C1
> +	select S3C_DEV_I2C2
> +	select S3C_DEV_RTC
> +	select S3C_DEV_WDT
> +	select S5PV210_SETUP_I2C1
> +	select S5PV210_SETUP_I2C2
> +	select S5PV210_SETUP_SDHCI
> +	help
> +	  Machine support for aESOP Torbreck
> +
>  endmenu
> 
>  endif
> diff --git a/arch/arm/mach-s5pv210/Makefile
b/arch/arm/mach-s5pv210/Makefile
> index 05048c5..927c2b7 100644
> --- a/arch/arm/mach-s5pv210/Makefile
> +++ b/arch/arm/mach-s5pv210/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)	+= mach-aquila.o
>  obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
>  obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
>  obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
> +obj-$(CONFIG_MACH_TORBRECK)	+= mach-torbreck.o
> 
>  # device support
> 
> diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-
> s5pv210/mach-torbreck.c
> new file mode 100644
> index 0000000..3142250
> --- /dev/null
> +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> @@ -0,0 +1,133 @@
> +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> + *
> + * Copyright (c) 2010 aESOP Community
> + *		http://www.aesop.or.kr/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/serial_core.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/map.h>
> +#include <asm/setup.h>
> +#include <asm/mach-types.h>
> +
> +#include <mach/map.h>
> +#include <mach/regs-clock.h>
> +
> +#include <plat/regs-serial.h>
> +#include <plat/s5pv210.h>
> +#include <plat/devs.h>
> +#include <plat/cpu.h>
> +#include <plat/iic.h>
> +
> +/* Following are default values for UCON, ULCON and UFCON UART registers
*/
> +#define TORBRECK_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
> +				 S3C2410_UCON_RXILEVEL |	\
> +				 S3C2410_UCON_TXIRQMODE |	\
> +				 S3C2410_UCON_RXIRQMODE |	\
> +				 S3C2410_UCON_RXFIFO_TOI |	\
> +				 S3C2443_UCON_RXERR_IRQEN)
> +
> +#define TORBRECK_ULCON_DEFAULT	S3C2410_LCON_CS8
> +
> +#define TORBRECK_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
> +				 S5PV210_UFCON_TXTRIG4 |	\
> +				 S5PV210_UFCON_RXTRIG4)
> +
> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> +	[0] = {
> +		.hwport		= 0,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[1] = {
> +		.hwport		= 1,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[2] = {
> +		.hwport		= 2,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[3] = {
> +		.hwport		= 3,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +};
> +
> +static struct platform_device *torbreck_devices[] __initdata = {
> +	&s5pv210_device_iis0,
> +	&s3c_device_cfcon,
> +	&s3c_device_hsmmc0,
> +	&s3c_device_hsmmc1,
> +	&s3c_device_hsmmc2,
> +	&s3c_device_hsmmc3,
> +	&s3c_device_i2c0,
> +	&s3c_device_i2c1,
> +	&s3c_device_i2c2,
> +	&s3c_device_rtc,
> +	&s3c_device_wdt,
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static void __init torbreck_map_io(void)
> +{
> +	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> +	s3c24xx_init_clocks(24000000);
> +	s3c24xx_init_uarts(torbreck_uartcfgs,
ARRAY_SIZE(torbreck_uartcfgs));
> +}
> +
> +static void __init torbreck_machine_init(void)
> +{
> +	s3c_i2c0_set_platdata(NULL);
> +	s3c_i2c1_set_platdata(NULL);
> +	s3c_i2c2_set_platdata(NULL);
> +	i2c_register_board_info(0, torbreck_i2c_devs0,
> +			ARRAY_SIZE(torbreck_i2c_devs0));
> +	i2c_register_board_info(1, torbreck_i2c_devs1,
> +			ARRAY_SIZE(torbreck_i2c_devs1));
> +	i2c_register_board_info(2, torbreck_i2c_devs2,
> +			ARRAY_SIZE(torbreck_i2c_devs2));
> +
> +	platform_add_devices(torbreck_devices,
ARRAY_SIZE(torbreck_devices));
> +}
> +
> +MACHINE_START(TORBRECK, "TORBRECK")
> +	/* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> +	.phys_io	= S3C_PA_UART & 0xfff00000,
> +	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> +	.boot_params	= S5P_PA_SDRAM + 0x100,
> +	.init_irq	= s5pv210_init_irq,
> +	.map_io		= torbreck_map_io,
> +	.init_machine	= torbreck_machine_init,
> +	.timer		= &s3c24xx_timer,
> +MACHINE_END
> --

Ok...will apply this.

If needs bug fixes or any patches for your board, please don't hesitate to
send/submit your patch like this time.

As you know, there is default configuration, s5pv210_defconfig for S5PV210
SoC.
If you want to add your board to it, please send updated it after merging
your board number into mach-types in the mainline.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-29 12:07   ` Kukjin Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Kukjin Kim @ 2010-09-29 12:07 UTC (permalink / raw)
  To: linux-arm-kernel

Kyuho Choi wrote:
> 
> This patch adds to support Torbreck board of aESOP community using
> Samsung S5PV210 SoC.
> 
> Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
> Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
> ---
>  arch/arm/mach-s5pv210/Kconfig         |   18 +++++
>  arch/arm/mach-s5pv210/Makefile        |    1 +
>  arch/arm/mach-s5pv210/mach-torbreck.c |  133
> +++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
> 
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index d3a3895..c5ec466 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -139,6 +139,24 @@ config MACH_SMDKV210
>  	help
>  	  Machine support for Samsung SMDKV210
> 
> +config MACH_TORBRECK
> +	bool "Torbreck"
> +	select CPU_S5PV210
> +	select ARCH_SPARSEMEM_ENABLE
> +	select S3C_DEV_HSMMC
> +	select S3C_DEV_HSMMC1
> +	select S3C_DEV_HSMMC2
> +	select S3C_DEV_HSMMC3
> +	select S3C_DEV_I2C1
> +	select S3C_DEV_I2C2
> +	select S3C_DEV_RTC
> +	select S3C_DEV_WDT
> +	select S5PV210_SETUP_I2C1
> +	select S5PV210_SETUP_I2C2
> +	select S5PV210_SETUP_SDHCI
> +	help
> +	  Machine support for aESOP Torbreck
> +
>  endmenu
> 
>  endif
> diff --git a/arch/arm/mach-s5pv210/Makefile
b/arch/arm/mach-s5pv210/Makefile
> index 05048c5..927c2b7 100644
> --- a/arch/arm/mach-s5pv210/Makefile
> +++ b/arch/arm/mach-s5pv210/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)	+= mach-aquila.o
>  obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
>  obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
>  obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
> +obj-$(CONFIG_MACH_TORBRECK)	+= mach-torbreck.o
> 
>  # device support
> 
> diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-
> s5pv210/mach-torbreck.c
> new file mode 100644
> index 0000000..3142250
> --- /dev/null
> +++ b/arch/arm/mach-s5pv210/mach-torbreck.c
> @@ -0,0 +1,133 @@
> +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
> + *
> + * Copyright (c) 2010 aESOP Community
> + *		http://www.aesop.or.kr/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/serial_core.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/map.h>
> +#include <asm/setup.h>
> +#include <asm/mach-types.h>
> +
> +#include <mach/map.h>
> +#include <mach/regs-clock.h>
> +
> +#include <plat/regs-serial.h>
> +#include <plat/s5pv210.h>
> +#include <plat/devs.h>
> +#include <plat/cpu.h>
> +#include <plat/iic.h>
> +
> +/* Following are default values for UCON, ULCON and UFCON UART registers
*/
> +#define TORBRECK_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
> +				 S3C2410_UCON_RXILEVEL |	\
> +				 S3C2410_UCON_TXIRQMODE |	\
> +				 S3C2410_UCON_RXIRQMODE |	\
> +				 S3C2410_UCON_RXFIFO_TOI |	\
> +				 S3C2443_UCON_RXERR_IRQEN)
> +
> +#define TORBRECK_ULCON_DEFAULT	S3C2410_LCON_CS8
> +
> +#define TORBRECK_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
> +				 S5PV210_UFCON_TXTRIG4 |	\
> +				 S5PV210_UFCON_RXTRIG4)
> +
> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
> +	[0] = {
> +		.hwport		= 0,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[1] = {
> +		.hwport		= 1,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[2] = {
> +		.hwport		= 2,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +	[3] = {
> +		.hwport		= 3,
> +		.flags		= 0,
> +		.ucon		= TORBRECK_UCON_DEFAULT,
> +		.ulcon		= TORBRECK_ULCON_DEFAULT,
> +		.ufcon		= TORBRECK_UFCON_DEFAULT,
> +	},
> +};
> +
> +static struct platform_device *torbreck_devices[] __initdata = {
> +	&s5pv210_device_iis0,
> +	&s3c_device_cfcon,
> +	&s3c_device_hsmmc0,
> +	&s3c_device_hsmmc1,
> +	&s3c_device_hsmmc2,
> +	&s3c_device_hsmmc3,
> +	&s3c_device_i2c0,
> +	&s3c_device_i2c1,
> +	&s3c_device_i2c2,
> +	&s3c_device_rtc,
> +	&s3c_device_wdt,
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
> +	/* To Be Updated */
> +};
> +
> +static void __init torbreck_map_io(void)
> +{
> +	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> +	s3c24xx_init_clocks(24000000);
> +	s3c24xx_init_uarts(torbreck_uartcfgs,
ARRAY_SIZE(torbreck_uartcfgs));
> +}
> +
> +static void __init torbreck_machine_init(void)
> +{
> +	s3c_i2c0_set_platdata(NULL);
> +	s3c_i2c1_set_platdata(NULL);
> +	s3c_i2c2_set_platdata(NULL);
> +	i2c_register_board_info(0, torbreck_i2c_devs0,
> +			ARRAY_SIZE(torbreck_i2c_devs0));
> +	i2c_register_board_info(1, torbreck_i2c_devs1,
> +			ARRAY_SIZE(torbreck_i2c_devs1));
> +	i2c_register_board_info(2, torbreck_i2c_devs2,
> +			ARRAY_SIZE(torbreck_i2c_devs2));
> +
> +	platform_add_devices(torbreck_devices,
ARRAY_SIZE(torbreck_devices));
> +}
> +
> +MACHINE_START(TORBRECK, "TORBRECK")
> +	/* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
> +	.phys_io	= S3C_PA_UART & 0xfff00000,
> +	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> +	.boot_params	= S5P_PA_SDRAM + 0x100,
> +	.init_irq	= s5pv210_init_irq,
> +	.map_io		= torbreck_map_io,
> +	.init_machine	= torbreck_machine_init,
> +	.timer		= &s3c24xx_timer,
> +MACHINE_END
> --

Ok...will apply this.

If needs bug fixes or any patches for your board, please don't hesitate to
send/submit your patch like this time.

As you know, there is default configuration, s5pv210_defconfig for S5PV210
SoC.
If you want to add your board to it, please send updated it after merging
your board number into mach-types in the mainline.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: S5PV210: Add Torbreck board support
@ 2010-09-26 16:32 Kyuho Choi
  2010-09-29 12:07   ` Kukjin Kim
  0 siblings, 1 reply; 16+ messages in thread
From: Kyuho Choi @ 2010-09-26 16:32 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds to support Torbreck board of aESOP community using
Samsung S5PV210 SoC.

Signed-off-by: Kyuho Choi <chlrbgh0@gmail.com>
Signed-off-by: Hyunchul Ko <ghcstop@gmail.com>
---
 arch/arm/mach-s5pv210/Kconfig         |   18 +++++
 arch/arm/mach-s5pv210/Makefile        |    1 +
 arch/arm/mach-s5pv210/mach-torbreck.c |  133 +++++++++++++++++++++++++++++++++
 3 files changed, 152 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index d3a3895..c5ec466 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -139,6 +139,24 @@ config MACH_SMDKV210
 	help
 	  Machine support for Samsung SMDKV210
 
+config MACH_TORBRECK
+	bool "Torbreck"
+	select CPU_S5PV210
+	select ARCH_SPARSEMEM_ENABLE
+	select S3C_DEV_HSMMC
+	select S3C_DEV_HSMMC1
+	select S3C_DEV_HSMMC2
+	select S3C_DEV_HSMMC3
+	select S3C_DEV_I2C1
+	select S3C_DEV_I2C2
+	select S3C_DEV_RTC
+	select S3C_DEV_WDT
+	select S5PV210_SETUP_I2C1
+	select S5PV210_SETUP_I2C2
+	select S5PV210_SETUP_SDHCI
+	help
+	  Machine support for aESOP Torbreck
+
 endmenu
 
 endif
diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile
index 05048c5..927c2b7 100644
--- a/arch/arm/mach-s5pv210/Makefile
+++ b/arch/arm/mach-s5pv210/Makefile
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)	+= mach-aquila.o
 obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
 obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
+obj-$(CONFIG_MACH_TORBRECK)	+= mach-torbreck.o
 
 # device support
 
diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-s5pv210/mach-torbreck.c
new file mode 100644
index 0000000..3142250
--- /dev/null
+++ b/arch/arm/mach-s5pv210/mach-torbreck.c
@@ -0,0 +1,133 @@
+/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
+ *
+ * Copyright (c) 2010 aESOP Community
+ *		http://www.aesop.or.kr/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+#include <plat/iic.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define TORBRECK_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
+				 S3C2410_UCON_RXILEVEL |	\
+				 S3C2410_UCON_TXIRQMODE |	\
+				 S3C2410_UCON_RXIRQMODE |	\
+				 S3C2410_UCON_RXFIFO_TOI |	\
+				 S3C2443_UCON_RXERR_IRQEN)
+
+#define TORBRECK_ULCON_DEFAULT	S3C2410_LCON_CS8
+
+#define TORBRECK_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
+				 S5PV210_UFCON_TXTRIG4 |	\
+				 S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+	[0] = {
+		.hwport		= 0,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[1] = {
+		.hwport		= 1,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[2] = {
+		.hwport		= 2,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+	[3] = {
+		.hwport		= 3,
+		.flags		= 0,
+		.ucon		= TORBRECK_UCON_DEFAULT,
+		.ulcon		= TORBRECK_ULCON_DEFAULT,
+		.ufcon		= TORBRECK_UFCON_DEFAULT,
+	},
+};
+
+static struct platform_device *torbreck_devices[] __initdata = {
+	&s5pv210_device_iis0,
+	&s3c_device_cfcon,
+	&s3c_device_hsmmc0,
+	&s3c_device_hsmmc1,
+	&s3c_device_hsmmc2,
+	&s3c_device_hsmmc3,
+	&s3c_device_i2c0,
+	&s3c_device_i2c1,
+	&s3c_device_i2c2,
+	&s3c_device_rtc,
+	&s3c_device_wdt,
+};
+
+static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
+	/* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
+	/* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
+	/* To Be Updated */
+};
+
+static void __init torbreck_map_io(void)
+{
+	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+	s3c24xx_init_clocks(24000000);
+	s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));
+}
+
+static void __init torbreck_machine_init(void)
+{
+	s3c_i2c0_set_platdata(NULL);
+	s3c_i2c1_set_platdata(NULL);
+	s3c_i2c2_set_platdata(NULL);
+	i2c_register_board_info(0, torbreck_i2c_devs0,
+			ARRAY_SIZE(torbreck_i2c_devs0));
+	i2c_register_board_info(1, torbreck_i2c_devs1,
+			ARRAY_SIZE(torbreck_i2c_devs1));
+	i2c_register_board_info(2, torbreck_i2c_devs2,
+			ARRAY_SIZE(torbreck_i2c_devs2));
+
+	platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));
+}
+
+MACHINE_START(TORBRECK, "TORBRECK")
+	/* Maintainer: Hyunchul Ko <ghcstop@gmail.com> */
+	.phys_io	= S3C_PA_UART & 0xfff00000,
+	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+	.boot_params	= S5P_PA_SDRAM + 0x100,
+	.init_irq	= s5pv210_init_irq,
+	.map_io		= torbreck_map_io,
+	.init_machine	= torbreck_machine_init,
+	.timer		= &s3c24xx_timer,
+MACHINE_END
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2010-09-29 12:07 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-26  1:05 [PATCH] ARM: S5PV210: Add Torbreck board support Kyuho Choi
2010-09-27  2:58 ` Kyungmin Park
2010-09-27  2:58   ` Kyungmin Park
2010-09-27 10:10   ` 최규호
2010-09-27 10:10     ` 최규호
2010-09-27 10:39     ` Kyungmin Park
2010-09-27 10:39       ` Kyungmin Park
2010-09-28  5:55     ` Kukjin Kim
2010-09-28  5:55       ` Kukjin Kim
2010-09-28  6:12       ` Kyungmin Park
2010-09-28  6:12         ` Kyungmin Park
2010-09-28 11:30       ` 최규호
2010-09-28 11:30         ` 최규호
2010-09-26 16:32 Kyuho Choi
2010-09-29 12:07 ` Kukjin Kim
2010-09-29 12:07   ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.