* [PATCH] ath9k: Fix potential use-after-free.
@ 2010-10-13 19:01 ` greearb at candelatech.com
0 siblings, 0 replies; 3+ messages in thread
From: greearb @ 2010-10-13 19:01 UTC (permalink / raw)
To: linux-wireless, ath9k-devel; +Cc: Ben Greear
From: Ben Greear <greearb@candelatech.com>
The ath_debug_stat_tx references bf->bf_mpdu, which
is the skb consumed by ath_tx_complete. So, call
the ath_debug_stat_tx method first.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 942be55... 6d41d47... M drivers/net/wireless/ath/ath9k/xmit.c
drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 942be55..6d41d47 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1926,8 +1926,8 @@ static void ath_tx_complete_buf(struct ath_softc *sc, struct ath_buf *bf,
else
complete(&sc->paprd_complete);
} else {
- ath_tx_complete(sc, skb, bf->aphy, tx_flags);
ath_debug_stat_tx(sc, txq, bf, ts);
+ ath_tx_complete(sc, skb, bf->aphy, tx_flags);
}
/*
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix potential use-after-free.
@ 2010-10-13 19:01 ` greearb at candelatech.com
0 siblings, 0 replies; 3+ messages in thread
From: greearb at candelatech.com @ 2010-10-13 19:01 UTC (permalink / raw)
To: ath9k-devel
From: Ben Greear <greearb@candelatech.com>
The ath_debug_stat_tx references bf->bf_mpdu, which
is the skb consumed by ath_tx_complete. So, call
the ath_debug_stat_tx method first.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 942be55... 6d41d47... M drivers/net/wireless/ath/ath9k/xmit.c
drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 942be55..6d41d47 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1926,8 +1926,8 @@ static void ath_tx_complete_buf(struct ath_softc *sc, struct ath_buf *bf,
else
complete(&sc->paprd_complete);
} else {
- ath_tx_complete(sc, skb, bf->aphy, tx_flags);
ath_debug_stat_tx(sc, txq, bf, ts);
+ ath_tx_complete(sc, skb, bf->aphy, tx_flags);
}
/*
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix potential use-after-free.
2010-10-13 19:01 ` [ath9k-devel] " greearb at candelatech.com
(?)
@ 2010-10-13 20:23 ` Peter Stuge
-1 siblings, 0 replies; 3+ messages in thread
From: Peter Stuge @ 2010-10-13 20:23 UTC (permalink / raw)
To: ath9k-devel
greearb at candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The ath_debug_stat_tx references bf->bf_mpdu, which
> is the skb consumed by ath_tx_complete. So, call
> the ath_debug_stat_tx method first.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Acked-by: Peter Stuge <peter@stuge.se>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-13 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-13 19:01 [PATCH] ath9k: Fix potential use-after-free greearb
2010-10-13 19:01 ` [ath9k-devel] " greearb at candelatech.com
2010-10-13 20:23 ` Peter Stuge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.