All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] mtd: OneNAND: fix bufferram management.
@ 2010-10-23 13:43 Enric Balletbo i Serra
  2010-10-23 13:43 ` [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes Enric Balletbo i Serra
  0 siblings, 1 reply; 6+ messages in thread
From: Enric Balletbo i Serra @ 2010-10-23 13:43 UTC (permalink / raw)
  To: linux-omap, linux-mtd, kyungmin.park, dwmw2, Artem.Bityutskiy,
	adrian.hunter, m.szyprowski


Hello,

Have a look at this patch, I've some problems with latest kernel from mainline
and a JFFS2 filesystem, the kernel reports various errors like

Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0, calculated 0x564fc9e8

Applying this patch solves the issue, but I  only have tested on IGEP v2 board with
a OneNAND from Numonyx. Please test with other OneNAND devices and point me if I'm
in the correct way to solve this issue. Thanks.

Cheers,
  Enric

$ git diff --stat origin/master
 drivers/mtd/onenand/onenand_base.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.
  2010-10-23 13:43 [PATCH 0/1] mtd: OneNAND: fix bufferram management Enric Balletbo i Serra
@ 2010-10-23 13:43 ` Enric Balletbo i Serra
  2010-10-26  9:36     ` Artem Bityutskiy
  0 siblings, 1 reply; 6+ messages in thread
From: Enric Balletbo i Serra @ 2010-10-23 13:43 UTC (permalink / raw)
  To: linux-omap, linux-mtd, kyungmin.park, dwmw2, Artem.Bityutskiy,
	adrian.hunter, m.szyprowski
  Cc: Enric Balletbo i Serra

This patch adds code that I think was lost when it was applied the commit
  5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support

Test case:
 1. Stress a jffs2 filesystem using
    bonnie++ -u 0:0 -s 32 -m 16 -r 16
 2. dmesg shows various 'Header CRC failed' errors like:
    Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0,
    calculated 0x564fc9e8

Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y

Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
---
 drivers/mtd/onenand/onenand_base.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index a2bb520..53aa13e 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -1964,6 +1964,10 @@ static int onenand_write_ops_nolock(struct mtd_info *mtd, loff_t to,
 
 			/* In partial page write we don't update bufferram */
 			onenand_update_bufferram(mtd, to, !ret && !subpage);
+			ONENAND_SET_BUFFERRAM1(this);
+			onenand_update_bufferram(mtd, to + this->writesize,
+				!ret && !subpage);
+
 			if (ret) {
 				printk(KERN_ERR "%s: write failed %d\n",
 					__func__, ret);
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.
  2010-10-23 13:43 ` [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes Enric Balletbo i Serra
@ 2010-10-26  9:36     ` Artem Bityutskiy
  0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2010-10-26  9:36 UTC (permalink / raw)
  To: Enric Balletbo i Serra, kyungmin.park
  Cc: linux-omap, linux-mtd, dwmw2, adrian.hunter, m.szyprowski

On Sat, 2010-10-23 at 15:43 +0200, Enric Balletbo i Serra wrote:
> This patch adds code that I think was lost when it was applied the commit
>   5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support
> 
> Test case:
>  1. Stress a jffs2 filesystem using
>     bonnie++ -u 0:0 -s 32 -m 16 -r 16
>  2. dmesg shows various 'Header CRC failed' errors like:
>     Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0,
>     calculated 0x564fc9e8
> 
> Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
> with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y
> 
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>

Kyungmin, would be nice to have your ack/nack.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.
@ 2010-10-26  9:36     ` Artem Bityutskiy
  0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2010-10-26  9:36 UTC (permalink / raw)
  To: Enric Balletbo i Serra, kyungmin.park
  Cc: m.szyprowski, dwmw2, linux-omap, linux-mtd, adrian.hunter

On Sat, 2010-10-23 at 15:43 +0200, Enric Balletbo i Serra wrote:
> This patch adds code that I think was lost when it was applied the commit
>   5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support
> 
> Test case:
>  1. Stress a jffs2 filesystem using
>     bonnie++ -u 0:0 -s 32 -m 16 -r 16
>  2. dmesg shows various 'Header CRC failed' errors like:
>     Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0,
>     calculated 0x564fc9e8
> 
> Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
> with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y
> 
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>

Kyungmin, would be nice to have your ack/nack.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.
  2010-10-26  9:36     ` Artem Bityutskiy
@ 2010-10-26 10:29       ` Kyungmin Park
  -1 siblings, 0 replies; 6+ messages in thread
From: Kyungmin Park @ 2010-10-26 10:29 UTC (permalink / raw)
  To: Artem.Bityutskiy
  Cc: Enric Balletbo i Serra, linux-omap, linux-mtd, dwmw2,
	adrian.hunter, m.szyprowski

On Tue, Oct 26, 2010 at 6:36 PM, Artem Bityutskiy
<Artem.Bityutskiy@nokia.com> wrote:
> On Sat, 2010-10-23 at 15:43 +0200, Enric Balletbo i Serra wrote:
>> This patch adds code that I think was lost when it was applied the commit
>>   5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support
>>
>> Test case:
>>  1. Stress a jffs2 filesystem using
>>     bonnie++ -u 0:0 -s 32 -m 16 -r 16
>>  2. dmesg shows various 'Header CRC failed' errors like:
>>     Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0,
>>     calculated 0x564fc9e8
>>
>> Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
>> with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
>
> Kyungmin, would be nice to have your ack/nack.
Sorry for late reply

One more check, it seems to use the invalidate instead of update bufferram.
In case of 2X PROGRAM, it always uses the BUFFERRAM0 so invalidate
another bufferram.

Don't set the bufferram index.

Thank you,
Kyungmin Park
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.
@ 2010-10-26 10:29       ` Kyungmin Park
  0 siblings, 0 replies; 6+ messages in thread
From: Kyungmin Park @ 2010-10-26 10:29 UTC (permalink / raw)
  To: Artem.Bityutskiy
  Cc: Enric Balletbo i Serra, adrian.hunter, linux-mtd, linux-omap,
	dwmw2, m.szyprowski

On Tue, Oct 26, 2010 at 6:36 PM, Artem Bityutskiy
<Artem.Bityutskiy@nokia.com> wrote:
> On Sat, 2010-10-23 at 15:43 +0200, Enric Balletbo i Serra wrote:
>> This patch adds code that I think was lost when it was applied the commit
>>   5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support
>>
>> Test case:
>>  1. Stress a jffs2 filesystem using
>>     bonnie++ -u 0:0 -s 32 -m 16 -r 16
>>  2. dmesg shows various 'Header CRC failed' errors like:
>>     Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0,
>>     calculated 0x564fc9e8
>>
>> Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
>> with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
>
> Kyungmin, would be nice to have your ack/nack.
Sorry for late reply

One more check, it seems to use the invalidate instead of update bufferram.
In case of 2X PROGRAM, it always uses the BUFFERRAM0 so invalidate
another bufferram.

Don't set the bufferram index.

Thank you,
Kyungmin Park
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-26 10:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-23 13:43 [PATCH 0/1] mtd: OneNAND: fix bufferram management Enric Balletbo i Serra
2010-10-23 13:43 ` [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes Enric Balletbo i Serra
2010-10-26  9:36   ` Artem Bityutskiy
2010-10-26  9:36     ` Artem Bityutskiy
2010-10-26 10:29     ` Kyungmin Park
2010-10-26 10:29       ` Kyungmin Park

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.