* [PATCH 4/8] staging: dream: fix information leak to userland
@ 2010-10-28 20:01 ` Vasiliy Kulikov
0 siblings, 0 replies; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-10-28 20:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Tejun Heo, Arnd Bergmann, devel, linux-kernel
Structure msm_audio_stats is copied to userland with some fields unitialized.
It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
drivers/staging/dream/qdsp5/audio_in.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dream/qdsp5/audio_in.c b/drivers/staging/dream/qdsp5/audio_in.c
index b51fa09..a14f7ce 100644
--- a/drivers/staging/dream/qdsp5/audio_in.c
+++ b/drivers/staging/dream/qdsp5/audio_in.c
@@ -612,6 +612,7 @@ static long audio_in_ioctl(struct file *file,
if (cmd == AUDIO_GET_STATS) {
struct msm_audio_stats stats;
+ memset(&stats, 0, sizeof(stats));
stats.byte_count = atomic_read(&audio->in_bytes);
if (copy_to_user((void *) arg, &stats, sizeof(stats)))
return -EFAULT;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 4/8] staging: dream: fix information leak to userland
@ 2010-10-28 20:01 ` Vasiliy Kulikov
0 siblings, 0 replies; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-10-28 20:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Tejun Heo, Arnd Bergmann, devel, linux-kernel
Structure msm_audio_stats is copied to userland with some fields unitialized.
It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
drivers/staging/dream/qdsp5/audio_in.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dream/qdsp5/audio_in.c b/drivers/staging/dream/qdsp5/audio_in.c
index b51fa09..a14f7ce 100644
--- a/drivers/staging/dream/qdsp5/audio_in.c
+++ b/drivers/staging/dream/qdsp5/audio_in.c
@@ -612,6 +612,7 @@ static long audio_in_ioctl(struct file *file,
if (cmd = AUDIO_GET_STATS) {
struct msm_audio_stats stats;
+ memset(&stats, 0, sizeof(stats));
stats.byte_count = atomic_read(&audio->in_bytes);
if (copy_to_user((void *) arg, &stats, sizeof(stats)))
return -EFAULT;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-28 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-28 20:01 [PATCH 4/8] staging: dream: fix information leak to userland Vasiliy Kulikov
2010-10-28 20:01 ` Vasiliy Kulikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.