From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Keir Fraser <keir@xen.org>
Cc: KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Fix ia64 tools build
Date: Fri, 29 Oct 2010 14:12:21 +0100 [thread overview]
Message-ID: <1288357941.13236.212.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <C8F03C83.89B8%keir@xen.org>
On Fri, 2010-10-29 at 08:55 +0100, Keir Fraser wrote:
> On 29/10/2010 08:39, "KUWAMURA Shin'ya" <kuwa@jp.fujitsu.com> wrote:
>
> > Ping?
> >
> > This patch is still required for ia64 tools.
> >
> > Best regards,
>
> I think it would ne neater to have your own
> tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from
> Xen's acenv.h (e.g., dependent on __XEN_TOOLS__). Or revert the bits of c/s
> 22066 that broke the ia64 build in the first place -- possibly the changes
> were based on a false assumption?
Yeah, I thought it was unused. I may have confused it with
tools/libxc/ia64/acpi/platform/aclinux.h which is in fact just a symlink
to xen/include/acpi/platform/aclinux.h.
Note that tools/libxc is now licensed as LGPL so before simply
reinstating the old file it probably needs to be confirmed that it is ok
to license that way. (that said the contents of the file don't seem
particularly exciting, a cleanroom rewrite based on compiling and
observing the errors would be pretty trivial)
> Cc'ing the author of that patch, Ian
> Campbell. In any case, ifdef'ing the bulk of aclinux.h is just gross, I
> don't like that fix.
Why do we even need what appears to be a simplistic OS abstraction layer
in the tools first place?
Ian.
next prev parent reply other threads:[~2010-10-29 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 4:43 [PATCH] Fix ia64 tools build KUWAMURA Shin'ya
2010-10-29 7:39 ` KUWAMURA Shin'ya
2010-10-29 7:55 ` Keir Fraser
2010-10-29 13:12 ` Ian Campbell [this message]
2010-11-01 8:39 ` KUWAMURA Shin'ya
2010-11-01 9:21 ` Keir Fraser
2010-11-01 9:28 ` Ian Campbell
2010-11-01 9:48 ` Keir Fraser
2010-11-02 0:43 ` KUWAMURA Shin'ya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288357941.13236.212.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu.citrix.com \
--cc=keir@xen.org \
--cc=kuwa@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.