All of lore.kernel.org
 help / color / mirror / Atom feed
From: "KUWAMURA Shin'ya" <kuwa@jp.fujitsu.com>
To: keir@xen.org, Ian.Campbell@eu.citrix.com
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fix ia64 tools build
Date: Mon, 01 Nov 2010 17:39:56 +0900 (JST)	[thread overview]
Message-ID: <20101101.173956.27861895.kuwa@jp.fujitsu.com> (raw)
In-Reply-To: <C8F03C83.89B8%keir@xen.org>

[-- Attachment #1: Type: Text/Plain, Size: 565 bytes --]

Hi Keir and Ian,

>>>>> On Fri, 29 Oct 2010 08:55:31 +0100
>>>>> keir@xen.org(Keir Fraser)  said:
> 
> I think it would ne neater to have your own
> tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from
> Xen's acenv.h (e.g., dependent on __XEN_TOOLS__).

I created a patch for Keir's first advice.

This patch introduces ac_ia64_tools.h and it only defines identifiers
in order to avoid compilation errors.

Because all identifiers can be easily led from the error message, 
it is trivial.

Any comments?

Best regards,
-- 
  KUWAMURA Shin'ya

[-- Attachment #2: fix-ia64-tools-aclinux-v2.patch --]
[-- Type: Text/X-Patch, Size: 1105 bytes --]

diff -r bbffb400f507 tools/libxc/ia64/ac_ia64_tools.h
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/tools/libxc/ia64/ac_ia64_tools.h	Mon Nov 01 17:15:10 2010 +0900
@@ -0,0 +1,17 @@
+#ifndef AC_IA64_TOOLS_H
+#define AC_IA64_TOOLS_H
+
+#define ACPI_MACHINE_WIDTH 64
+#define COMPILER_DEPENDENT_UINT64 unsigned long long
+#define COMPILER_DEPENDENT_INT64 long long
+typedef unsigned long long u64;
+typedef long long s64;
+typedef unsigned u32;
+typedef int s32;
+typedef unsigned char u8;
+typedef unsigned short u16;
+#define __iomem
+#define asmlinkage
+#define CONFIG_ACPI_BOOT
+
+#endif /* AC_IA64_TOOLS_H */
diff -r bbffb400f507 xen/include/acpi/platform/acenv.h
--- a/xen/include/acpi/platform/acenv.h	Mon Nov 01 15:35:03 2010 +0900
+++ b/xen/include/acpi/platform/acenv.h	Mon Nov 01 17:15:10 2010 +0900
@@ -136,7 +136,9 @@
 
 /*! [Begin] no source code translation */
 
-#if 1/*defined(_LINUX) || defined(__linux__)*/
+#if defined(__XEN_TOOLS__) && defined(__ia64__)
+#include "ac_ia64_tools.h"
+#elif 1 /*defined(_LINUX) || defined(__linux__)*/
 #include "aclinux.h"
 
 #elif defined(_AED_EFI)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

  parent reply	other threads:[~2010-11-01  8:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-02  4:43 [PATCH] Fix ia64 tools build KUWAMURA Shin'ya
2010-10-29  7:39 ` KUWAMURA Shin'ya
2010-10-29  7:55   ` Keir Fraser
2010-10-29 13:12     ` Ian Campbell
2010-11-01  8:39     ` KUWAMURA Shin'ya [this message]
2010-11-01  9:21       ` Keir Fraser
2010-11-01  9:28         ` Ian Campbell
2010-11-01  9:48           ` Keir Fraser
2010-11-02  0:43             ` KUWAMURA Shin'ya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101101.173956.27861895.kuwa@jp.fujitsu.com \
    --to=kuwa@jp.fujitsu.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.