All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Peter@alsa-project.org,
	Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH] ASoC: tpa6130a2: Fix unbalanced regulator disables
Date: Sat, 30 Oct 2010 17:38:27 +0100	[thread overview]
Message-ID: <1288456707.3286.51.camel@odin> (raw)
In-Reply-To: <20101028183326.GB14076@sirena.org.uk>

On Thu, 2010-10-28 at 19:33 +0100, Mark Brown wrote:
> On Thu, Oct 28, 2010 at 02:05:40PM +0300, Jarkko Nikula wrote:
> > This driver has unbalanced regulator_disable when doing module loading and
> > unloading. This is because tpa6130a2_probe followed by tpa6130a2_remove
> > calls twice tpa6130a2_power(0). Fix this by implementing a state checking
> > in tpa6130a2_power.
> > 
> > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> > Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-10-30 16:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-28 11:05 [PATCH] ASoC: tpa6130a2: Fix unbalanced regulator disables Jarkko Nikula
2010-10-28 12:43 ` Peter Ujfalusi
2010-10-28 18:33 ` Mark Brown
2010-10-30 16:38   ` Liam Girdwood [this message]
2010-11-03 14:00 ` Takashi Iwai
2010-11-03 14:29   ` Jarkko Nikula
2010-11-03 14:39   ` [PATCH] ASoC: tpa6130a2: Get rid of compile warning from tpa6130a2_power Jarkko Nikula
2010-11-03 14:55     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288456707.3286.51.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=Peter@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.