Re: [PATCH] ASoC: tpa6130a2: Get rid of compile warning from tpa6130a2_power

From: Takashi Iwai <tiwai@suse.de>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: tpa6130a2: Get rid of compile warning from tpa6130a2_power
Date: Wed, 03 Nov 2010 15:55:19 +0100	[thread overview]
Message-ID: <s5hhbfyqwx4.wl%tiwai@suse.de> (raw)
In-Reply-To: <1288795140-18563-1-git-send-email-jhnikula@gmail.com>

At Wed,  3 Nov 2010 16:39:00 +0200,
Jarkko Nikula wrote:
> 
> Patch "ASoC: tpa6130a2: Fix unbalanced regulator disables" introduced a
> compiler warning "‘ret’ may be used uninitialized in this function".
> Initialize ret to zero to get rid of it and making sure that the function
> does not return any random error code when the code is falling through.
> 
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>

Thanks!

Applied now directly to sound git tree as I'm going to send a pull
request soon later.

Mark, Liam, please pull back to your trees later on.

Takashi

> ---
>  sound/soc/codecs/tpa6130a2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
> index 83b5631..ee4fb20 100644
> --- a/sound/soc/codecs/tpa6130a2.c
> +++ b/sound/soc/codecs/tpa6130a2.c
> @@ -119,7 +119,7 @@ static int tpa6130a2_power(int power)
>  {
>  	struct	tpa6130a2_data *data;
>  	u8	val;
> -	int	ret;
> +	int	ret = 0;
>  
>  	BUG_ON(tpa6130a2_client == NULL);
>  	data = i2c_get_clientdata(tpa6130a2_client);
> -- 
> 1.7.2.3
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel