* [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails
@ 2010-11-01 9:25 Axel Lin
2010-11-01 13:13 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-11-01 9:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Mauro Carvalho Chehab, Hans Verkuil, linux-media
If the adapter does not support I2C_FUNC_SMBUS_WRITE_BYTE,
return -EIO instead of 0.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/media/video/tea6415c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c
index 3e99cea..19621ed 100644
--- a/drivers/media/video/tea6415c.c
+++ b/drivers/media/video/tea6415c.c
@@ -148,7 +148,7 @@ static int tea6415c_probe(struct i2c_client *client,
/* let's see whether this adapter can support what we need */
if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE))
- return 0;
+ return -EIO;
v4l_info(client, "chip found @ 0x%x (%s)\n",
client->addr << 1, client->adapter->name);
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails
2010-11-01 9:25 [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails Axel Lin
@ 2010-11-01 13:13 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2010-11-01 13:13 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Mauro Carvalho Chehab, linux-media
On Monday, November 01, 2010 10:25:39 Axel Lin wrote:
> If the adapter does not support I2C_FUNC_SMBUS_WRITE_BYTE,
> return -EIO instead of 0.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> ---
> drivers/media/video/tea6415c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c
> index 3e99cea..19621ed 100644
> --- a/drivers/media/video/tea6415c.c
> +++ b/drivers/media/video/tea6415c.c
> @@ -148,7 +148,7 @@ static int tea6415c_probe(struct i2c_client *client,
>
> /* let's see whether this adapter can support what we need */
> if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE))
> - return 0;
> + return -EIO;
>
> v4l_info(client, "chip found @ 0x%x (%s)\n",
> client->addr << 1, client->adapter->name);
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-01 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-01 9:25 [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails Axel Lin
2010-11-01 13:13 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.