* [PATCH] rndis_wlan: avoid uninitialized var warning in rndis_wlan_craft_connected_bss
@ 2010-11-16 21:49 John W. Linville
2010-11-16 23:49 ` Jussi Kivilinna
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2010-11-16 21:49 UTC (permalink / raw)
To: linux-wireless; +Cc: Jussi Kivilinna, John W. Linville
CC [M] drivers/net/wireless/rndis_wlan.o
drivers/net/wireless/rndis_wlan.c: In function ‘rndis_wlan_craft_connected_bss’:
drivers/net/wireless/rndis_wlan.c:2542:2: warning: ‘ret’ may be used uninitialized in this function
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/rndis_wlan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 8a77ff6..ee08bca 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -2536,7 +2536,7 @@ static void rndis_wlan_craft_connected_bss(struct usbnet *usbdev, u8 *bssid,
/* Get signal quality, in case of error use rssi=0 and ignore error. */
len = sizeof(rssi);
rssi = 0;
- rndis_query_oid(usbdev, OID_802_11_RSSI, &rssi, &len);
+ ret = rndis_query_oid(usbdev, OID_802_11_RSSI, &rssi, &len);
signal = level_to_qual(le32_to_cpu(rssi));
netdev_dbg(usbdev->net, "%s(): OID_802_11_RSSI -> %d, "
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rndis_wlan: avoid uninitialized var warning in rndis_wlan_craft_connected_bss
2010-11-16 21:49 [PATCH] rndis_wlan: avoid uninitialized var warning in rndis_wlan_craft_connected_bss John W. Linville
@ 2010-11-16 23:49 ` Jussi Kivilinna
0 siblings, 0 replies; 2+ messages in thread
From: Jussi Kivilinna @ 2010-11-16 23:49 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
Quoting "John W. Linville" <linville@tuxdriver.com>:
> CC [M] drivers/net/wireless/rndis_wlan.o
> drivers/net/wireless/rndis_wlan.c: In function
> ‘rndis_wlan_craft_connected_bss’:
> drivers/net/wireless/rndis_wlan.c:2542:2: warning: ‘ret’ may be used
> uninitialized in this function
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Ah.. yes, netdev_dbg needs the return value. Thanks.
Acked-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-16 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-16 21:49 [PATCH] rndis_wlan: avoid uninitialized var warning in rndis_wlan_craft_connected_bss John W. Linville
2010-11-16 23:49 ` Jussi Kivilinna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.