Unpack hierarchy - jethro vs. krogoth

Unpack hierarchy - jethro vs. krogoth

[colin.helliwell]

Is there a change to recipe parsing and/or variables between jethro and
krogoth?
I'm migrating from the former to the latter and have hit a patch failure.
Looking at the unpacked source, jethro has the relevant file at
    build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/
whereas krogoth has it at
    build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/driver/

Indeed, all the sources have been unpacked under an additional 'driver'
directory level .e.g.
    src/driver/*  ->  3.0.2-r0/driver/driver/
    src/config/*  ->  3.0.2-r0/driver/config/
instead of 
    src/driver/*  ->  3.0.2-r0/driver/
    src/config/*  ->  3.0.2-r0/config/


The recipe includes
SRC_URI = "file://driver/*.c \
           file://driver/*.h \
           file://Makefile \
           file://COPYING \
          "
FILESEXTRAPATHS_prepend := "${BSPDIR}/../Apps/MyDriver/src:"
S = "${WORKDIR}"

As I say, it works on jethro...!

Re: Unpack hierarchy - jethro vs. krogoth

[Colin Helliwell]

> On 28 March 2017 at 11:33 colin.helliwell@ln-systems.com wrote:
> 
> Is there a change to recipe parsing and/or variables between jethro and
> krogoth?
> I'm migrating from the former to the latter and have hit a patch failure.
> Looking at the unpacked source, jethro has the relevant file at
>  build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/
> whereas krogoth has it at
>  build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/driver/
> 
> Indeed, all the sources have been unpacked under an additional 'driver'
> directory level .e.g.
>  src/driver/* -> 3.0.2-r0/driver/driver/
>  src/config/* -> 3.0.2-r0/driver/config/
> instead of
>  src/driver/* -> 3.0.2-r0/driver/
>  src/config/* -> 3.0.2-r0/config/
> 
> The recipe includes
> SRC_URI = "file://driver/*.c \
>  file://driver/*.h \
>  file://Makefile \
>  file://COPYING \
>  "
> FILESEXTRAPATHS_prepend := "${BSPDIR}/../Apps/MyDriver/src:"
> S = "${WORKDIR}"
> 
> As I say, it works on jethro...!
> 

Can't spot a reason, even in the bbclass's, why it's unpacking differently. 
log.do_unpack reports:
DEBUG: Searching for driver/*.c in paths:
....
DEBUG: Searching for driver/*.c in path: /home/colin/100051-krogoth/fsl-community-bsp/../Apps/MyDriver/src/.
NOTE: Unpacking /home/colin/100051-krogoth/fsl-community-bsp/../Apps/MyDriver/src/. to /home/colin/100051-krogoth/fsl-community-bsp/build/tmp/work/wg2xx_tx6s-poky-linux-gnueabi/linmux/3.0.2-r0/

which suggests it should've ended up in the 'right' place?

Re: Unpack hierarchy - jethro vs. krogoth

[Andre McCurdy]

On Tue, Mar 28, 2017 at 3:33 AM,  <colin.helliwell@ln-systems.com> wrote:
> Is there a change to recipe parsing and/or variables between jethro and
> krogoth?
> I'm migrating from the former to the latter and have hit a patch failure.
> Looking at the unpacked source, jethro has the relevant file at
>     build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/
> whereas krogoth has it at
>     build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/driver/
>
> Indeed, all the sources have been unpacked under an additional 'driver'
> directory level .e.g.
>     src/driver/*  ->  3.0.2-r0/driver/driver/
>     src/config/*  ->  3.0.2-r0/driver/config/
> instead of
>     src/driver/*  ->  3.0.2-r0/driver/
>     src/config/*  ->  3.0.2-r0/config/
>
>
> The recipe includes
> SRC_URI = "file://driver/*.c \
>            file://driver/*.h \
>            file://Makefile \
>            file://COPYING \
>           "
> FILESEXTRAPATHS_prepend := "${BSPDIR}/../Apps/MyDriver/src:"
> S = "${WORKDIR}"
>
> As I say, it works on jethro...!

There were some changes in bitbake's handling of file:// SRC_URI entries:

  http://git.openembedded.org/bitbake/commit/?id=e659a3b0c2771679057ee3e13cd42e6c62383ff2

Is the behaviour more consistent if you remove one of the
"file://driver/*.[ch]" entries from SRC_URI? Or if you replace both
with a single entry to copy entire driver directory (ie
"file://driver") and avoid using wildcards?

> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: Unpack hierarchy - jethro vs. krogoth

[Colin Helliwell]

> On 29 March 2017 at 00:05 Andre McCurdy <armccurdy@gmail.com> wrote:
> 
> On Tue, Mar 28, 2017 at 3:33 AM, <colin.helliwell@ln-systems.com> wrote:
> 
> > Is there a change to recipe parsing and/or variables between jethro and
> > krogoth?
> > I'm migrating from the former to the latter and have hit a patch failure.
> > Looking at the unpacked source, jethro has the relevant file at
> >  build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/
> > whereas krogoth has it at
> >  build/tmp/work/XXX-poky-linux-gnueabi/linmux/3.0.2-r0/driver/driver/
> > 
> > Indeed, all the sources have been unpacked under an additional 'driver'
> > directory level .e.g.
> >  src/driver/* -> 3.0.2-r0/driver/driver/
> >  src/config/* -> 3.0.2-r0/driver/config/
> > instead of
> >  src/driver/* -> 3.0.2-r0/driver/
> >  src/config/* -> 3.0.2-r0/config/
> > 
> > The recipe includes
> > SRC_URI = "file://driver/*.c \
> >  file://driver/*.h \
> >  file://Makefile \
> >  file://COPYING \
> >  "
> > FILESEXTRAPATHS_prepend := "${BSPDIR}/../Apps/MyDriver/src:"
> > S = "${WORKDIR}"
> > 
> > As I say, it works on jethro...!
> 
> There were some changes in bitbake's handling of file:// SRC_URI entries:
> 
> http://git.openembedded.org/bitbake/commit/?id=e659a3b0c2771679057ee3e13cd42e6c62383ff2
> 
> Is the behaviour more consistent if you remove one of the
> "file://driver/*.[ch]" entries from SRC_URI? 

> Or if you replace both
> with a single entry to copy entire driver directory (ie
> "file://driver") and avoid using wildcards?

Yep - that worked. Thanks!