* [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver
@ 2010-11-18 10:42 Sjur Braendeland
2010-11-18 17:29 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Sjur Braendeland @ 2010-11-18 10:42 UTC (permalink / raw)
To: David Miller, netdev; +Cc: Kim Lilliestierna XX
From: Kim Lilliestierna XX <kim.xx.lilliestierna@stericsson.com>
Rearrange pr_fmt as __func__ is a variable and not a constant
---
drivers/net/caif/caif_shm_u5500.c | 2 +-
drivers/net/caif/caif_shmcore.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/caif/caif_shm_u5500.c b/drivers/net/caif/caif_shm_u5500.c
index 1cd90da..7c1f7b9 100644
--- a/drivers/net/caif/caif_shm_u5500.c
+++ b/drivers/net/caif/caif_shm_u5500.c
@@ -5,7 +5,7 @@
* License terms: GNU General Public License (GPL) version 2
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ":" __func__ "():" fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
#include <linux/version.h>
#include <linux/init.h>
diff --git a/drivers/net/caif/caif_shmcore.c b/drivers/net/caif/caif_shmcore.c
index 19f9c06..e4ee8c2 100644
--- a/drivers/net/caif/caif_shmcore.c
+++ b/drivers/net/caif/caif_shmcore.c
@@ -6,7 +6,7 @@
* License terms: GNU General Public License (GPL) version 2
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ":" __func__ "():" fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
#include <linux/spinlock.h>
#include <linux/sched.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver
2010-11-18 10:42 [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver Sjur Braendeland
@ 2010-11-18 17:29 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-11-18 17:29 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, kim.xx.lilliestierna
From: Sjur Braendeland <sjur.brandeland@stericsson.com>
Date: Thu, 18 Nov 2010 11:42:16 +0100
> From: Kim Lilliestierna XX <kim.xx.lilliestierna@stericsson.com>
>
> Rearrange pr_fmt as __func__ is a variable and not a constant
Just remove the __func__ thing, it's just noise.
Also, you didn't include a proper "Signed-off-by: " tag in your
commit message.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver
2010-11-30 19:11 sjur.brandeland
@ 2010-12-08 16:40 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-12-08 16:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, kim.xx.lilliestierna
From: sjur.brandeland@stericsson.com
Date: Tue, 30 Nov 2010 20:11:22 +0100
> From: Kim Lilliestierna XX <kim.xx.lilliestierna@stericsson.com>
>
> Rearrange pr_fmt so it compiles.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver
@ 2010-11-30 19:11 sjur.brandeland
2010-12-08 16:40 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: sjur.brandeland @ 2010-11-30 19:11 UTC (permalink / raw)
To: netdev, David Miller; +Cc: Kim Lilliestierna XX, Sjur Braendeland
From: Kim Lilliestierna XX <kim.xx.lilliestierna@stericsson.com>
Rearrange pr_fmt so it compiles.
Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
---
drivers/net/caif/caif_shm_u5500.c | 2 +-
drivers/net/caif/caif_shmcore.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/caif/caif_shm_u5500.c b/drivers/net/caif/caif_shm_u5500.c
index 1cd90da..32b1c6f 100644
--- a/drivers/net/caif/caif_shm_u5500.c
+++ b/drivers/net/caif/caif_shm_u5500.c
@@ -5,7 +5,7 @@
* License terms: GNU General Public License (GPL) version 2
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ":" __func__ "():" fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ":" fmt
#include <linux/version.h>
#include <linux/init.h>
diff --git a/drivers/net/caif/caif_shmcore.c b/drivers/net/caif/caif_shmcore.c
index 19f9c06..8051116 100644
--- a/drivers/net/caif/caif_shmcore.c
+++ b/drivers/net/caif/caif_shmcore.c
@@ -6,7 +6,7 @@
* License terms: GNU General Public License (GPL) version 2
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ":" __func__ "():" fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ":" fmt
#include <linux/spinlock.h>
#include <linux/sched.h>
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-08 16:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-18 10:42 [PATCH net-2.6] CAIF: Fix U5500 compile error for shared memory driver Sjur Braendeland
2010-11-18 17:29 ` David Miller
2010-11-30 19:11 sjur.brandeland
2010-12-08 16:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.