All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] build: Update glib version in configure.ac
@ 2010-11-18 12:03 George Matveev
  0 siblings, 0 replies; 7+ messages in thread
From: George Matveev @ 2010-11-18 12:03 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6aeab7c..c0f4217 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,8 +67,8 @@ AC_CHECK_LIB(c, signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
 			AC_MSG_ERROR(dynamic linking loader is required))
 
-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
-				AC_MSG_ERROR(GLib >= 2.16 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.22, dummy=yes,
+				AC_MSG_ERROR(GLib >= 2.22 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] build: Update glib version in configure.ac
  2010-11-19  9:18 George Matveev
@ 2010-11-22 11:13 ` Denis Kenzior
  0 siblings, 0 replies; 7+ messages in thread
From: Denis Kenzior @ 2010-11-22 11:13 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

Hi George,

On 11/19/2010 03:18 AM, George Matveev wrote:
> function g_mkstemp_full in src/storage.c
> requires glib version 2.22 or higher
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] build: Update glib version in configure.ac
@ 2010-11-19  9:25 George Matveev
  0 siblings, 0 replies; 7+ messages in thread
From: George Matveev @ 2010-11-19  9:25 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi Marcel,

you are right.
I've just corrected that and resubmitted the patch, please review.

Best regards,
George

--------------------------- Ursprungligt brev ----------------------------
Ärende: Re: [PATCH] 	build: Update glib version in configure.ac
Från:   "Marcel Holtmann" <marcel@holtmann.org>
Datum:  Fr, 2010-11-19, 08:01 am
Till:   ofono(a)ofono.org
--------------------------------------------------------------------------

Hi George,

> function g_mkstemp_full in src/storage.c
> requires glib version 2.22 or higher
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

patch looks good, but your subject line has a ^I character in it and I
prefer not to figure out what git does with it. So please fix this
first.

Regards

Marcel


_______________________________________________
ofono mailing list
ofono(a)ofono.org
http://lists.ofono.org/listinfo/ofono



^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] build: Update glib version in configure.ac
@ 2010-11-19  9:18 George Matveev
  2010-11-22 11:13 ` Denis Kenzior
  0 siblings, 1 reply; 7+ messages in thread
From: George Matveev @ 2010-11-19  9:18 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6aeab7c..c0f4217 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,8 +67,8 @@ AC_CHECK_LIB(c, signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
 			AC_MSG_ERROR(dynamic linking loader is required))
 
-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
-				AC_MSG_ERROR(GLib >= 2.16 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.22, dummy=yes,
+				AC_MSG_ERROR(GLib >= 2.22 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH]  build: Update glib version in configure.ac
  2010-11-18 19:21 George Matveev
@ 2010-11-19  7:01 ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2010-11-19  7:01 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi George,

> function g_mkstemp_full in src/storage.c
> requires glib version 2.22 or higher
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

patch looks good, but your subject line has a ^I character in it and I
prefer not to figure out what git does with it. So please fix this
first.

Regards

Marcel



^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH]  build: Update glib version in configure.ac
@ 2010-11-18 19:21 George Matveev
  2010-11-19  7:01 ` Marcel Holtmann
  0 siblings, 1 reply; 7+ messages in thread
From: George Matveev @ 2010-11-18 19:21 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6aeab7c..c0f4217 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,8 +67,8 @@ AC_CHECK_LIB(c, signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
 			AC_MSG_ERROR(dynamic linking loader is required))
 
-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
-				AC_MSG_ERROR(GLib >= 2.16 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.22, dummy=yes,
+				AC_MSG_ERROR(GLib >= 2.22 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] build: Update glib version in configure.ac
@ 2010-11-18 12:13 George Matveev
  0 siblings, 0 replies; 7+ messages in thread
From: George Matveev @ 2010-11-18 12:13 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6aeab7c..c0f4217 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,8 +67,8 @@ AC_CHECK_LIB(c, signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
 			AC_MSG_ERROR(dynamic linking loader is required))
 
-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
-				AC_MSG_ERROR(GLib >= 2.16 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.22, dummy=yes,
+				AC_MSG_ERROR(GLib >= 2.22 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-22 11:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-18 12:03 [PATCH] build: Update glib version in configure.ac George Matveev
2010-11-18 12:13 George Matveev
2010-11-18 19:21 George Matveev
2010-11-19  7:01 ` Marcel Holtmann
2010-11-19  9:18 George Matveev
2010-11-22 11:13 ` Denis Kenzior
2010-11-19  9:25 George Matveev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.