All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iwlwifi: fix modular 3945 only build
@ 2010-11-18 20:08 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2010-11-18 20:08 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, Randy Dunlap, Wey-Yi W Guy

From: Johannes Berg <johannes.berg@intel.com>

If only 3945 is selected, and is a module, build
fails because iwl-legacy.c won't be compiled. Fix
this by adding it to the build correctly.

This doesn't happen for 4965 because it is a bool
option, not tristate, since it's built into the
AGN module.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 drivers/net/wireless/iwlwifi/Makefile |    4 ++++
 1 file changed, 4 insertions(+)

--- wireless-testing.orig/drivers/net/wireless/iwlwifi/Makefile	2010-11-18 12:04:47.000000000 -0800
+++ wireless-testing/drivers/net/wireless/iwlwifi/Makefile	2010-11-18 12:05:27.000000000 -0800
@@ -7,6 +7,10 @@ iwlcore-$(CONFIG_IWL4965) += iwl-legacy.
 iwlcore-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o
 iwlcore-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o
 
+# If 3945 is selected only, iwl-legacy.o will be added
+# to iwlcore-m above, but it needs to be built in.
+iwlcore-objs += $(iwlcore-m)
+
 CFLAGS_iwl-devtrace.o := -I$(src)
 
 # AGN



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-11-18 20:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-18 20:08 [PATCH] iwlwifi: fix modular 3945 only build Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.