* [PATCH] Disable frame buffer compression on ironlake
@ 2010-11-19 2:00 Alex,Shi
2010-11-19 8:47 ` Chris Wilson
2010-11-19 10:05 ` Chris Wilson
0 siblings, 2 replies; 4+ messages in thread
From: Alex,Shi @ 2010-11-19 2:00 UTC (permalink / raw)
To: intel-gfx
Open fbc will cause about 1 Watts power increase on ironlake
for bltk-office/player benchmark. So just disable it and left
code here to waiting for better solution.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 80745f8..029af7a 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -150,7 +150,7 @@ static const struct intel_device_info intel_ironlake_d_info = {
static const struct intel_device_info intel_ironlake_m_info = {
.gen = 5, .is_mobile = 1,
- .need_gfx_hws = 1, .has_fbc = 1, .has_rc6 = 1, .has_hotplug = 1,
+ .need_gfx_hws = 1, .has_fbc = 0, .has_rc6 = 1, .has_hotplug = 1,
.has_bsd_ring = 1,
};
--
1.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Disable frame buffer compression on ironlake
2010-11-19 2:00 [PATCH] Disable frame buffer compression on ironlake Alex,Shi
@ 2010-11-19 8:47 ` Chris Wilson
2010-11-19 19:36 ` Jesse Barnes
2010-11-19 10:05 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2010-11-19 8:47 UTC (permalink / raw)
To: Alex,Shi, intel-gfx
On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" <alex.shi@intel.com> wrote:
> Open fbc will cause about 1 Watts power increase on ironlake
> for bltk-office/player benchmark. So just disable it and left
> code here to waiting for better solution.
FBC is disabled through the chicken bits, so I am really curious to know
where the power saving is coming from. I just want to verify that we have
not made a fundamental mistake in our FBC logic that is consuming more
power than is necessary across all platforms.
In terms of code clarity, we should leave a note as to why we explicitly
disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Disable frame buffer compression on ironlake
2010-11-19 2:00 [PATCH] Disable frame buffer compression on ironlake Alex,Shi
2010-11-19 8:47 ` Chris Wilson
@ 2010-11-19 10:05 ` Chris Wilson
1 sibling, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2010-11-19 10:05 UTC (permalink / raw)
To: Alex,Shi, intel-gfx
On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" <alex.shi@intel.com> wrote:
> Open fbc will cause about 1 Watts power increase on ironlake
> for bltk-office/player benchmark. So just disable it and left
> code here to waiting for better solution.
I applied a slightly modified patch to -fixes, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Disable frame buffer compression on ironlake
2010-11-19 8:47 ` Chris Wilson
@ 2010-11-19 19:36 ` Jesse Barnes
0 siblings, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2010-11-19 19:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, 19 Nov 2010 08:47:27 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" <alex.shi@intel.com> wrote:
> > Open fbc will cause about 1 Watts power increase on ironlake
> > for bltk-office/player benchmark. So just disable it and left
> > code here to waiting for better solution.
>
> FBC is disabled through the chicken bits, so I am really curious to know
> where the power saving is coming from. I just want to verify that we have
> not made a fundamental mistake in our FBC logic that is consuming more
> power than is necessary across all platforms.
>
> In terms of code clarity, we should leave a note as to why we explicitly
> disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */
Did we disable the whole thing with chicken bits? I thought we only
disabled some aspects of FBC that were known buggy. AFAIK it should
generally work on ILK. You can assign the bug to me, I'll take a look.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-19 19:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-19 2:00 [PATCH] Disable frame buffer compression on ironlake Alex,Shi
2010-11-19 8:47 ` Chris Wilson
2010-11-19 19:36 ` Jesse Barnes
2010-11-19 10:05 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.