* [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
@ 2010-12-03 9:25 Axel Lin
2010-12-03 12:01 ` Liam Girdwood
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Axel Lin @ 2010-12-03 9:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Arnaud Patard, Liam Girdwood, Mark Brown, alsa-devel
In alc5623_i2c_probe(),
the default case for checking alc5623->id behaves the same as case 0x23.
However, In alc5623_probe() the default case for checking alc5623->id
becomes to be the same as case 0x21.
This makes the meaning of default case inconsistent.
Since we have checked codec id in alc5623_i2c_probe() by comparing
vid2 with id->driver_data, it is not possible to run into the default case now.
In case we may add more supported devices to alc5623_i2c_table in the future,
this patch changes the default case return -EINVAL to let people know that
they should not run into this case. They should also add a new case accordingly
for the new id.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Or alternatively, we can simply remove the default cases.
Axel
sound/soc/codecs/alc5623.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
index 9783e7e..4f377c9 100644
--- a/sound/soc/codecs/alc5623.c
+++ b/sound/soc/codecs/alc5623.c
@@ -925,7 +925,6 @@ static int alc5623_probe(struct snd_soc_codec *codec)
}
switch (alc5623->id) {
- default:
case 0x21:
snd_soc_add_controls(codec, rt5621_vol_snd_controls,
ARRAY_SIZE(rt5621_vol_snd_controls));
@@ -938,6 +937,8 @@ static int alc5623_probe(struct snd_soc_codec *codec)
snd_soc_add_controls(codec, alc5623_vol_snd_controls,
ARRAY_SIZE(alc5623_vol_snd_controls));
break;
+ default:
+ return -EINVAL;
}
snd_soc_add_controls(codec, alc5623_snd_controls,
@@ -950,7 +951,6 @@ static int alc5623_probe(struct snd_soc_codec *codec)
snd_soc_dapm_add_routes(dapm, intercon, ARRAY_SIZE(intercon));
switch (alc5623->id) {
- default:
case 0x21:
case 0x22:
snd_soc_dapm_new_controls(dapm, alc5623_dapm_amp_widgets,
@@ -962,6 +962,8 @@ static int alc5623_probe(struct snd_soc_codec *codec)
snd_soc_dapm_add_routes(dapm, intercon_spk,
ARRAY_SIZE(intercon_spk));
break;
+ default:
+ return -EINVAL;
}
return ret;
@@ -1039,10 +1041,12 @@ static int alc5623_i2c_probe(struct i2c_client *client,
case 0x22:
alc5623_dai.name = "alc5622-hifi";
break;
- default:
case 0x23:
alc5623_dai.name = "alc5623-hifi";
break;
+ default:
+ kfree(alc5623);
+ return -EINVAL;
}
i2c_set_clientdata(client, alc5623);
--
1.7.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
@ 2010-12-03 12:01 ` Liam Girdwood
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-12-03 12:01 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Arnaud Patard, Mark Brown, alsa-devel
On Fri, 2010-12-03 at 17:25 +0800, Axel Lin wrote:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
@ 2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Arnaud Patard @ 2010-12-03 12:21 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel
Axel Lin <axel.lin@gmail.com> writes:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.
oh, yeah. makes sense. Thanks for noticing.
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
@ 2010-12-03 12:21 ` Arnaud Patard
0 siblings, 0 replies; 6+ messages in thread
From: Arnaud Patard @ 2010-12-03 12:21 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, linux-kernel, Liam Girdwood
Axel Lin <axel.lin@gmail.com> writes:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.
oh, yeah. makes sense. Thanks for noticing.
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
@ 2010-12-03 12:25 ` Mark Brown
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-12-03 12:25 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Arnaud Patard, Liam Girdwood, alsa-devel
On Fri, Dec 03, 2010 at 05:25:57PM +0800, Axel Lin wrote:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
@ 2010-12-03 12:25 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-12-03 12:25 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Arnaud Patard, Liam Girdwood
On Fri, Dec 03, 2010 at 05:25:57PM +0800, Axel Lin wrote:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-03 12:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
2010-12-03 12:01 ` Liam Girdwood
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown
2010-12-03 12:25 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.