* [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
@ 2010-12-03 12:06 sudarshan.bisht
2010-12-06 12:51 ` Clemens Ladisch
0 siblings, 1 reply; 5+ messages in thread
From: sudarshan.bisht @ 2010-12-03 12:06 UTC (permalink / raw)
To: alsa-devel
From: Sudarshan <sudarshan.bisht@nokia.com>
Coverity Static Analysis helps developers find hard-to-spot,
yet potentially crash-causing defects early in the development phase,
reducing the cost,time, and risk of software errors.
* First patch here is just a cosmetic one as it removes
tabs and trailing whitespaces from the code.
* Second patch has got fixes for some minor issues/defects
reported by Coverity tool and these fixes can prevent memory
leaks and crashes in some cases. It also has some whitespaces
and tabs removal differences, please ignore them.
Sudarshan (1):
alsa-lib: Removed trailing whitespaces as per pulseaudio coding
guidelines.
bisht (1):
alsa-lib: Coverity tool has picked some minor issues in alsa-lib
source code, fixed them.
aserver/aserver.c | 1813 +++++++-------
modules/mixer/simple/sbase.c | 837 ++++----
modules/mixer/simple/sbasedl.c | 126 +-
src/alisp/alisp.c | 4 +-
src/alisp/alisp_snd.c | 1493 ++++++------
src/conf.c | 5117 ++++++++++++++++++++--------------------
src/control/control_hw.c | 597 +++---
src/control/control_shm.c | 1019 ++++----
src/control/setup.c | 3 +-
src/hwdep/hwdep.c | 496 ++--
src/mixer/mixer.c | 962 ++++----
src/mixer/simple_abst.c | 1 +
src/mixer/simple_none.c | 15 +-
src/pcm/pcm.c | 4812 +++++++++++++++++++-------------------
src/pcm/pcm_file.c | 1452 ++++++------
src/pcm/pcm_hooks.c | 937 ++++----
src/pcm/pcm_ladspa.c | 2284 +++++++++---------
src/pcm/pcm_local.h | 3 +-
src/pcm/pcm_meter.c | 1634 +++++++-------
src/pcm/pcm_rate.c | 2166 +++++++++---------
src/pcm/pcm_share.c | 10 +-
src/pcm/pcm_shm.c | 1329 ++++++------
src/pcm/pcm_simple.c | 404 ++--
src/rawmidi/rawmidi.c | 2 +-
src/rawmidi/rawmidi_virt.c | 8 +-
25 files changed, 13782 insertions(+), 13742 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
2010-12-03 12:06 [PATCH 0/2] Fixed issues/defects reported by Coverity tool sudarshan.bisht
@ 2010-12-06 12:51 ` Clemens Ladisch
2010-12-07 10:40 ` Sudarshan Bisht
2010-12-07 10:59 ` Sudarshan Bisht
0 siblings, 2 replies; 5+ messages in thread
From: Clemens Ladisch @ 2010-12-06 12:51 UTC (permalink / raw)
To: sudarshan.bisht; +Cc: alsa-devel
sudarshan.bisht@nokia.com wrote:
> Sudarshan (1):
> alsa-lib: Removed trailing whitespaces as per pulseaudio coding
> guidelines.
>
> bisht (1):
> alsa-lib: Coverity tool has picked some minor issues in alsa-lib
> source code, fixed them.
Apparently, your patches were too big and got stuck in some spam filter.
Try to compress them, or put them somewhere on the web.
Regards,
Clemens
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
2010-12-06 12:51 ` Clemens Ladisch
@ 2010-12-07 10:40 ` Sudarshan Bisht
2010-12-07 10:59 ` Sudarshan Bisht
1 sibling, 0 replies; 5+ messages in thread
From: Sudarshan Bisht @ 2010-12-07 10:40 UTC (permalink / raw)
To: ext Clemens Ladisch; +Cc: alsa-devel
Thanks for notifying this,
I will compress them and send once again.
Best Regards,
Sudarshan Bisht
On Mon, 2010-12-06 at 13:51 +0100, ext Clemens Ladisch wrote:
> sudarshan.bisht@nokia.com wrote:
> > Sudarshan (1):
> > alsa-lib: Removed trailing whitespaces as per pulseaudio coding
> > guidelines.
> >
> > bisht (1):
> > alsa-lib: Coverity tool has picked some minor issues in alsa-lib
> > source code, fixed them.
>
> Apparently, your patches were too big and got stuck in some spam filter.
>
> Try to compress them, or put them somewhere on the web.
>
>
> Regards,
> Clemens
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
2010-12-06 12:51 ` Clemens Ladisch
2010-12-07 10:40 ` Sudarshan Bisht
@ 2010-12-07 10:59 ` Sudarshan Bisht
2010-12-07 13:47 ` Clemens Ladisch
1 sibling, 1 reply; 5+ messages in thread
From: Sudarshan Bisht @ 2010-12-07 10:59 UTC (permalink / raw)
To: ext Clemens Ladisch; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Please find attached zipped patches.
On Mon, 2010-12-06 at 13:51 +0100, ext Clemens Ladisch wrote:
> sudarshan.bisht@nokia.com wrote:
> > Sudarshan (1):
> > alsa-lib: Removed trailing whitespaces as per pulseaudio coding
> > guidelines.
> >
> > bisht (1):
> > alsa-lib: Coverity tool has picked some minor issues in alsa-lib
> > source code, fixed them.
>
> Apparently, your patches were too big and got stuck in some spam filter.
>
> Try to compress them, or put them somewhere on the web.
>
>
> Regards,
> Clemens
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
[-- Attachment #2: 0000-cover-letter.patch --]
[-- Type: text/x-patch, Size: 2259 bytes --]
>From 5c01f696c0cbcc9b59ca9af32dd42f8efcaa34a0 Mon Sep 17 00:00:00 2001
From: Sudarshan <sudarshan.bisht@nokia.com>
Date: Fri, 3 Dec 2010 13:59:10 +0200
Subject: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
Coverity Static Analysis helps developers find hard-to-spot,
yet potentially crash-causing defects early in the development phase,
reducing the cost,time, and risk of software errors.
* First patch here is just a cosmetic one as it removes
tabs and trailing whitespaces from the code.
* Second patch has got fixes for some minor issues/defects
reported by Coverity tool and these fixes can prevent memory
leaks and crashes in some cases. It also has some whitespaces
and tabs removal differences, please ignore them.
Sudarshan (1):
alsa-lib: Removed trailing whitespaces as per pulseaudio coding
guidelines.
bisht (1):
alsa-lib: Coverity tool has picked some minor issues in alsa-lib
source code, fixed them.
aserver/aserver.c | 1813 +++++++-------
modules/mixer/simple/sbase.c | 837 ++++----
modules/mixer/simple/sbasedl.c | 126 +-
src/alisp/alisp.c | 4 +-
src/alisp/alisp_snd.c | 1493 ++++++------
src/conf.c | 5117 ++++++++++++++++++++--------------------
src/control/control_hw.c | 597 +++---
src/control/control_shm.c | 1019 ++++----
src/control/setup.c | 3 +-
src/hwdep/hwdep.c | 496 ++--
src/mixer/mixer.c | 962 ++++----
src/mixer/simple_abst.c | 1 +
src/mixer/simple_none.c | 15 +-
src/pcm/pcm.c | 4812 +++++++++++++++++++-------------------
src/pcm/pcm_file.c | 1452 ++++++------
src/pcm/pcm_hooks.c | 937 ++++----
src/pcm/pcm_ladspa.c | 2284 +++++++++---------
src/pcm/pcm_local.h | 3 +-
src/pcm/pcm_meter.c | 1634 +++++++-------
src/pcm/pcm_rate.c | 2166 +++++++++---------
src/pcm/pcm_share.c | 10 +-
src/pcm/pcm_shm.c | 1329 ++++++------
src/pcm/pcm_simple.c | 404 ++--
src/rawmidi/rawmidi.c | 2 +-
src/rawmidi/rawmidi_virt.c | 8 +-
25 files changed, 13782 insertions(+), 13742 deletions(-)
[-- Attachment #3: 0001-alsa-lib-Removed-trailing-whitespaces-as-per-pulseau.patch.gz --]
[-- Type: application/x-gzip, Size: 124228 bytes --]
[-- Attachment #4: 0002-alsa-lib-Coverity-tool-has-picked-some-minor-issues-.patch.gz --]
[-- Type: application/x-gzip, Size: 32720 bytes --]
[-- Attachment #5: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
2010-12-07 10:59 ` Sudarshan Bisht
@ 2010-12-07 13:47 ` Clemens Ladisch
0 siblings, 0 replies; 5+ messages in thread
From: Clemens Ladisch @ 2010-12-07 13:47 UTC (permalink / raw)
To: sudarshan.bisht; +Cc: alsa-devel
Sudarshan Bisht wrote:
> * First patch here is just a cosmetic one as it removes
> tabs and trailing whitespaces from the code.
The ALSA code uses kernel style, not PulseAudio; please don't remove
tabs.
> * Second patch has got fixes for some minor issues/defects
> reported by Coverity tool and these fixes can prevent memory
> leaks and crashes in some cases. It also has some whitespaces
> and tabs removal differences, please ignore them.
The whitespace stuff makes it hard to review the patches.
Please run diff with the -w parameter to ignore that.
Regards,
Clemens
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-07 13:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-03 12:06 [PATCH 0/2] Fixed issues/defects reported by Coverity tool sudarshan.bisht
2010-12-06 12:51 ` Clemens Ladisch
2010-12-07 10:40 ` Sudarshan Bisht
2010-12-07 10:59 ` Sudarshan Bisht
2010-12-07 13:47 ` Clemens Ladisch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.