* [PATCH 0/7] e1000e: cleanup
@ 2010-12-09 2:40 Asbjoern Sloth Toennesen
0 siblings, 0 replies; 6+ messages in thread
From: Asbjoern Sloth Toennesen @ 2010-12-09 2:40 UTC (permalink / raw)
To: Jeff Kirsher, Jeff Kirsher; +Cc: e1000-devel, netdev, linux-kernel
Hi,
This patchset fixes most checkstyle problems in e1000e.
Checkpatch summary:
pre: total: 221 errors, 129 warnings, 24520 lines checked
post: total: 2 errors, 34 warnings, 24533 lines checked
The two remaining errors are of the type "Macros with complex values
should be enclosed in parenthesis", with macros containing 3 comma
seperated values.
The remaining warnings are all caused by <20ms msleep usage, that should
be replaced with usleep_range calls.
This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
Asbjoern Sloth Toennesen (7):
e1000e: cleanup: fix spacing issues
e1000e: cleanup: fix bracket issues
e1000e: cleanup: simplify E1000_ALL_* defines
e1000e: cleanup: fix long lines
e1000e: cleanup: fix space issues in ich8_* structs
e1000e: cleanup: swap arguments to avoid checkpatch errors
e1000e: cleanup: fix copyright notices to preferred style
drivers/net/e1000e/82571.c | 70 +++++++-------
drivers/net/e1000e/defines.h | 110 ++++++++++++-----------
drivers/net/e1000e/e1000.h | 93 +++++++++++---------
drivers/net/e1000e/es2lan.c | 135 ++++++++++++++--------------
drivers/net/e1000e/ethtool.c | 75 ++++++++--------
drivers/net/e1000e/hw.h | 56 ++++++------
drivers/net/e1000e/ich8lan.c | 185 +++++++++++++++++++-------------------
drivers/net/e1000e/lib.c | 78 ++++++++--------
drivers/net/e1000e/netdev.c | 171 +++++++++++++++++------------------
drivers/net/e1000e/param.c | 60 +++++++------
drivers/net/e1000e/phy.c | 204 +++++++++++++++++++++---------------------
11 files changed, 625 insertions(+), 612 deletions(-)
--
1.7.2.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/7] e1000e: cleanup
2010-12-09 2:40 Asbjoern Sloth Toennesen
@ 2010-12-10 5:20 ` Kirsher, Jeffrey T
2010-12-10 5:20 ` Kirsher, Jeffrey T
1 sibling, 0 replies; 6+ messages in thread
From: Kirsher, Jeffrey T @ 2010-12-10 5:20 UTC (permalink / raw)
To: asbjorn; +Cc: e1000-devel, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]
On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> Hi,
>
> This patchset fixes most checkstyle problems in e1000e.
>
> Checkpatch summary:
> pre: total: 221 errors, 129 warnings, 24520 lines checked
> post: total: 2 errors, 34 warnings, 24533 lines checked
>
> The two remaining errors are of the type "Macros with complex values
> should be enclosed in parenthesis", with macros containing 3 comma
> seperated values.
>
> The remaining warnings are all caused by <20ms msleep usage, that should
> be replaced with usleep_range calls.
>
> This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
>
> Asbjoern Sloth Toennesen (7):
> e1000e: cleanup: fix spacing issues
> e1000e: cleanup: fix bracket issues
> e1000e: cleanup: simplify E1000_ALL_* defines
> e1000e: cleanup: fix long lines
> e1000e: cleanup: fix space issues in ich8_* structs
> e1000e: cleanup: swap arguments to avoid checkpatch errors
> e1000e: cleanup: fix copyright notices to preferred style
>
> drivers/net/e1000e/82571.c | 70 +++++++-------
> drivers/net/e1000e/defines.h | 110 ++++++++++++-----------
> drivers/net/e1000e/e1000.h | 93 +++++++++++---------
> drivers/net/e1000e/es2lan.c | 135 ++++++++++++++--------------
> drivers/net/e1000e/ethtool.c | 75 ++++++++--------
> drivers/net/e1000e/hw.h | 56 ++++++------
> drivers/net/e1000e/ich8lan.c | 185 +++++++++++++++++++-------------------
> drivers/net/e1000e/lib.c | 78 ++++++++--------
> drivers/net/e1000e/netdev.c | 171 +++++++++++++++++------------------
> drivers/net/e1000e/param.c | 60 +++++++------
> drivers/net/e1000e/phy.c | 204 +++++++++++++++++++++---------------------
> 11 files changed, 625 insertions(+), 612 deletions(-)
>
> --
> 1.7.2.3
>
We already have patches queued up internally and are under validation
for the changes in patches 1 through 5 along along with other patches
for e1000e. These patches will be posted shortly.
Patch 6 should be fixed in checkpatch.pl and from Florian's response, it
sounds like the fix is already out there.
Patch 7 does not resolve any warnings in checkpatch.pl and there is no
impending need to make this change.
So I won't be applying this series of patches.
Cheers,
Jeff
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 491 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/7] e1000e: cleanup
@ 2010-12-10 5:20 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 6+ messages in thread
From: Kirsher, Jeffrey T @ 2010-12-10 5:20 UTC (permalink / raw)
To: asbjorn; +Cc: e1000-devel, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]
On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> Hi,
>
> This patchset fixes most checkstyle problems in e1000e.
>
> Checkpatch summary:
> pre: total: 221 errors, 129 warnings, 24520 lines checked
> post: total: 2 errors, 34 warnings, 24533 lines checked
>
> The two remaining errors are of the type "Macros with complex values
> should be enclosed in parenthesis", with macros containing 3 comma
> seperated values.
>
> The remaining warnings are all caused by <20ms msleep usage, that should
> be replaced with usleep_range calls.
>
> This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
>
> Asbjoern Sloth Toennesen (7):
> e1000e: cleanup: fix spacing issues
> e1000e: cleanup: fix bracket issues
> e1000e: cleanup: simplify E1000_ALL_* defines
> e1000e: cleanup: fix long lines
> e1000e: cleanup: fix space issues in ich8_* structs
> e1000e: cleanup: swap arguments to avoid checkpatch errors
> e1000e: cleanup: fix copyright notices to preferred style
>
> drivers/net/e1000e/82571.c | 70 +++++++-------
> drivers/net/e1000e/defines.h | 110 ++++++++++++-----------
> drivers/net/e1000e/e1000.h | 93 +++++++++++---------
> drivers/net/e1000e/es2lan.c | 135 ++++++++++++++--------------
> drivers/net/e1000e/ethtool.c | 75 ++++++++--------
> drivers/net/e1000e/hw.h | 56 ++++++------
> drivers/net/e1000e/ich8lan.c | 185 +++++++++++++++++++-------------------
> drivers/net/e1000e/lib.c | 78 ++++++++--------
> drivers/net/e1000e/netdev.c | 171 +++++++++++++++++------------------
> drivers/net/e1000e/param.c | 60 +++++++------
> drivers/net/e1000e/phy.c | 204 +++++++++++++++++++++---------------------
> 11 files changed, 625 insertions(+), 612 deletions(-)
>
> --
> 1.7.2.3
>
We already have patches queued up internally and are under validation
for the changes in patches 1 through 5 along along with other patches
for e1000e. These patches will be posted shortly.
Patch 6 should be fixed in checkpatch.pl and from Florian's response, it
sounds like the fix is already out there.
Patch 7 does not resolve any warnings in checkpatch.pl and there is no
impending need to make this change.
So I won't be applying this series of patches.
Cheers,
Jeff
[-- Attachment #2: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/7] e1000e: cleanup
2010-12-09 2:40 Asbjoern Sloth Toennesen
@ 2010-12-09 3:37 ` Stephen Hemminger
2010-12-10 5:20 ` Kirsher, Jeffrey T
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2010-12-09 3:37 UTC (permalink / raw)
To: Asbjoern Sloth Toennesen; +Cc: Jeff Kirsher, e1000-devel, netdev, linux-kernel
On Thu, 9 Dec 2010 02:40:50 +0000
Asbjoern Sloth Toennesen <asbjorn@asbjorn.biz> wrote:
> Hi,
>
> This patchset fixes most checkstyle problems in e1000e.
>
> Checkpatch summary:
> pre: total: 221 errors, 129 warnings, 24520 lines checked
> post: total: 2 errors, 34 warnings, 24533 lines checked
IMHO these patches are in the why bother category, they deal only
with whitespace and things that checkpatch is too stupid to understand.
Checkpatch is a rough saw only appropriate to doing initial cutting
through crap drivers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/7] e1000e: cleanup
@ 2010-12-09 2:40 Asbjoern Sloth Toennesen
2010-12-09 3:37 ` Stephen Hemminger
2010-12-10 5:20 ` Kirsher, Jeffrey T
0 siblings, 2 replies; 6+ messages in thread
From: Asbjoern Sloth Toennesen @ 2010-12-09 2:40 UTC (permalink / raw)
To: Jeff Kirsher, Jeff Kirsher; +Cc: e1000-devel, netdev, linux-kernel
Hi,
This patchset fixes most checkstyle problems in e1000e.
Checkpatch summary:
pre: total: 221 errors, 129 warnings, 24520 lines checked
post: total: 2 errors, 34 warnings, 24533 lines checked
The two remaining errors are of the type "Macros with complex values
should be enclosed in parenthesis", with macros containing 3 comma
seperated values.
The remaining warnings are all caused by <20ms msleep usage, that should
be replaced with usleep_range calls.
This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
Asbjoern Sloth Toennesen (7):
e1000e: cleanup: fix spacing issues
e1000e: cleanup: fix bracket issues
e1000e: cleanup: simplify E1000_ALL_* defines
e1000e: cleanup: fix long lines
e1000e: cleanup: fix space issues in ich8_* structs
e1000e: cleanup: swap arguments to avoid checkpatch errors
e1000e: cleanup: fix copyright notices to preferred style
drivers/net/e1000e/82571.c | 70 +++++++-------
drivers/net/e1000e/defines.h | 110 ++++++++++++-----------
drivers/net/e1000e/e1000.h | 93 +++++++++++---------
drivers/net/e1000e/es2lan.c | 135 ++++++++++++++--------------
drivers/net/e1000e/ethtool.c | 75 ++++++++--------
drivers/net/e1000e/hw.h | 56 ++++++------
drivers/net/e1000e/ich8lan.c | 185 +++++++++++++++++++-------------------
drivers/net/e1000e/lib.c | 78 ++++++++--------
drivers/net/e1000e/netdev.c | 171 +++++++++++++++++------------------
drivers/net/e1000e/param.c | 60 +++++++------
drivers/net/e1000e/phy.c | 204 +++++++++++++++++++++---------------------
11 files changed, 625 insertions(+), 612 deletions(-)
--
1.7.2.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/7] e1000e: cleanup
@ 2010-12-09 2:40 Asbjoern Sloth Toennesen
0 siblings, 0 replies; 6+ messages in thread
From: Asbjoern Sloth Toennesen @ 2010-12-09 2:40 UTC (permalink / raw)
To: Jeff Kirsher, Jeff Kirsher; +Cc: e1000-devel, netdev, linux-kernel
Hi,
This patchset fixes most checkstyle problems in e1000e.
Checkpatch summary:
pre: total: 221 errors, 129 warnings, 24520 lines checked
post: total: 2 errors, 34 warnings, 24533 lines checked
The two remaining errors are of the type "Macros with complex values
should be enclosed in parenthesis", with macros containing 3 comma
seperated values.
The remaining warnings are all caused by <20ms msleep usage, that should
be replaced with usleep_range calls.
This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
Asbjoern Sloth Toennesen (7):
e1000e: cleanup: fix spacing issues
e1000e: cleanup: fix bracket issues
e1000e: cleanup: simplify E1000_ALL_* defines
e1000e: cleanup: fix long lines
e1000e: cleanup: fix space issues in ich8_* structs
e1000e: cleanup: swap arguments to avoid checkpatch errors
e1000e: cleanup: fix copyright notices to preferred style
drivers/net/e1000e/82571.c | 70 +++++++-------
drivers/net/e1000e/defines.h | 110 ++++++++++++-----------
drivers/net/e1000e/e1000.h | 93 +++++++++++---------
drivers/net/e1000e/es2lan.c | 135 ++++++++++++++--------------
drivers/net/e1000e/ethtool.c | 75 ++++++++--------
drivers/net/e1000e/hw.h | 56 ++++++------
drivers/net/e1000e/ich8lan.c | 185 +++++++++++++++++++-------------------
drivers/net/e1000e/lib.c | 78 ++++++++--------
drivers/net/e1000e/netdev.c | 171 +++++++++++++++++------------------
drivers/net/e1000e/param.c | 60 +++++++------
drivers/net/e1000e/phy.c | 204 +++++++++++++++++++++---------------------
11 files changed, 625 insertions(+), 612 deletions(-)
--
1.7.2.3
------------------------------------------------------------------------------
This SF Dev2Dev email is sponsored by:
WikiLeaks The End of the Free Internet
http://p.sf.net/sfu/therealnews-com
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-10 5:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09 2:40 [PATCH 0/7] e1000e: cleanup Asbjoern Sloth Toennesen
2010-12-09 2:40 Asbjoern Sloth Toennesen
2010-12-09 3:37 ` Stephen Hemminger
2010-12-10 5:20 ` Kirsher, Jeffrey T
2010-12-10 5:20 ` Kirsher, Jeffrey T
2010-12-09 2:40 Asbjoern Sloth Toennesen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.