* [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison
@ 2010-12-10 22:24 Andrew Kephart
2010-12-11 1:59 ` Paul Mundt
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Andrew Kephart @ 2010-12-10 22:24 UTC (permalink / raw)
To: linux-fbdev
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1132 bytes --]
Refresh rate nearness is not calculated or reset when nearest resolution
changes.
This patch resets the refresh rate differential measurement whenever a
new nearest resolution is discovered. This fixes two error cases;
first, wherein the first mode's refresh rate differential is never
calculated and second, when the closest refresh rate from a previous
nearest resolution is erroneously preserved.
-andrew
diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index c3a1825..7a61ba6 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
abs(cmode->yres - mode->yres);
if (diff > d) {
diff = d;
+ diff_refresh = abs(cmode->refresh - mode->refresh);
best = cmode;
} else if (diff = d) {
d = abs(cmode->refresh - mode->refresh);
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±ýöÝzÿâØ^nr¡ö¦zË\x1aëh¨èÚ&£ûàz¿äz¹Þú+Ê+zf£¢·h§~Ûiÿÿïêÿêçz_è®\x0fæj:+v¨þ)ߣøm
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison
2010-12-10 22:24 [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison Andrew Kephart
@ 2010-12-11 1:59 ` Paul Mundt
2010-12-13 15:46 ` Andrew Kephart
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Paul Mundt @ 2010-12-11 1:59 UTC (permalink / raw)
To: linux-fbdev
On Fri, Dec 10, 2010 at 04:24:48PM -0600, Andrew Kephart wrote:
> Refresh rate nearness is not calculated or reset when nearest resolution
> changes.
>
> This patch resets the refresh rate differential measurement whenever a
> new nearest resolution is discovered. This fixes two error cases;
> first, wherein the first mode's refresh rate differential is never
> calculated and second, when the closest refresh rate from a previous
> nearest resolution is erroneously preserved.
>
You're missing a signed-off-by tag.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison
2010-12-10 22:24 [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison Andrew Kephart
2010-12-11 1:59 ` Paul Mundt
@ 2010-12-13 15:46 ` Andrew Kephart
2010-12-14 9:05 ` Paul Mundt
2010-12-14 15:58 ` Andrew Kephart
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Kephart @ 2010-12-13 15:46 UTC (permalink / raw)
To: linux-fbdev
Refresh rate nearness is not calculated or reset when nearest resolution
changes.
This patch resets the refresh rate differential measurement whenever a
new nearest resolution is discovered. This fixes two error cases;
first, wherein the first mode's refresh rate differential is never
calculated and second, when the closest refresh rate from a previous
nearest resolution is erroneously preserved.
Signed-off-by: Andrew Kephart <andrew.kephart@alereon.com>
---
diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index c3a1825..7a61ba6 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
abs(cmode->yres - mode->yres);
if (diff > d) {
diff = d;
+ diff_refresh = abs(cmode->refresh -
mode->refresh);
best = cmode;
} else if (diff = d) {
d = abs(cmode->refresh - mode->refresh);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison
2010-12-10 22:24 [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison Andrew Kephart
2010-12-11 1:59 ` Paul Mundt
2010-12-13 15:46 ` Andrew Kephart
@ 2010-12-14 9:05 ` Paul Mundt
2010-12-14 15:58 ` Andrew Kephart
3 siblings, 0 replies; 5+ messages in thread
From: Paul Mundt @ 2010-12-14 9:05 UTC (permalink / raw)
To: linux-fbdev
On Mon, Dec 13, 2010 at 09:46:34AM -0600, Andrew Kephart wrote:
> Refresh rate nearness is not calculated or reset when nearest resolution
> changes.
>
> This patch resets the refresh rate differential measurement whenever a
> new nearest resolution is discovered. This fixes two error cases;
> first, wherein the first mode's refresh rate differential is never
> calculated and second, when the closest refresh rate from a previous
> nearest resolution is erroneously preserved.
>
> Signed-off-by: Andrew Kephart <andrew.kephart@alereon.com>
The patch itself is line-wrapped, so please check your mailer settings
for future patches. I've applied it by hand this time, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison
2010-12-10 22:24 [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison Andrew Kephart
` (2 preceding siblings ...)
2010-12-14 9:05 ` Paul Mundt
@ 2010-12-14 15:58 ` Andrew Kephart
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Kephart @ 2010-12-14 15:58 UTC (permalink / raw)
To: linux-fbdev
Paul,
Thanks, will do.
-andrew
On Tue, 2010-12-14 at 18:05 +0900, Paul Mundt wrote:
> The patch itself is line-wrapped, so please check your mailer settings
> for future patches. I've applied it by hand this time, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-14 15:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-10 22:24 [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison Andrew Kephart
2010-12-11 1:59 ` Paul Mundt
2010-12-13 15:46 ` Andrew Kephart
2010-12-14 9:05 ` Paul Mundt
2010-12-14 15:58 ` Andrew Kephart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.