All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: tidspbridge: remove code referred by OPT_ZERO_COPY_LOADER
@ 2010-12-20 21:23 Ernesto Ramos
  2010-12-24  7:43 ` Ramirez Luna, Omar
  0 siblings, 1 reply; 2+ messages in thread
From: Ernesto Ramos @ 2010-12-20 21:23 UTC (permalink / raw)
  To: linux-omap, linux-kernel
  Cc: omar.ramirez, ohad, felipe.contreras, Ernesto Ramos

Remove code referred by OPT_ZERO_COPY_LOADER since it is
not used.

Signed-off-by: Ernesto Ramos <ernesto@ti.com>
---
 drivers/staging/tidspbridge/dynload/cload.c |   60 +++++++++------------------
 1 files changed, 20 insertions(+), 40 deletions(-)

diff --git a/drivers/staging/tidspbridge/dynload/cload.c b/drivers/staging/tidspbridge/dynload/cload.c
index a5cdfa1..7713e76 100644
--- a/drivers/staging/tidspbridge/dynload/cload.c
+++ b/drivers/staging/tidspbridge/dynload/cload.c
@@ -1133,9 +1133,6 @@ static void dload_data(struct dload_state *dlthis)
 	u16 curr_sect;
 	struct doff_scnhdr_t *sptr = dlthis->sect_hdrs;
 	struct ldr_section_info *lptr = dlthis->ldr_sections;
-#ifdef OPT_ZERO_COPY_LOADER
-	bool zero_copy = false;
-#endif
 	u8 *dest;
 
 	struct {
@@ -1194,17 +1191,6 @@ static void dload_data(struct dload_state *dlthis)
 					return;
 				}
 				dest = ibuf.bufr;
-#ifdef OPT_ZERO_COPY_LOADER
-				zero_copy = false;
-				if (!dload_check_type(sptr, DLOAD_CINIT) {
-					dlthis->myio->writemem(dlthis->myio,
-							       &dest,
-							       lptr->load_addr +
-							       image_offset,
-							       lptr, 0);
-					zero_copy = (dest != ibuf.bufr);
-				}
-#endif
 				/* End of determination */
 
 				if (dlthis->strm->read_buffer(dlthis->strm,
@@ -1268,33 +1254,27 @@ static void dload_data(struct dload_state *dlthis)
 							    &ibuf.ipacket);
 						cinit_processed = true;
 					} else {
-#ifdef OPT_ZERO_COPY_LOADER
-						if (!zero_copy) {
-#endif
-							/* FIXME */
-							if (!dlthis->myio->
-							    writemem(dlthis->
-								myio,
-								ibuf.bufr,
-								lptr->
-								load_addr +
-								image_offset,
-								lptr,
-								BYTE_TO_HOST
-								(ibuf.
-								ipacket.
-								packet_size))) {
-								DL_ERROR
-								  ("Write to "
-								  FMT_UI32
-								  " failed",
-								  lptr->
-								  load_addr +
-								  image_offset);
-							}
-#ifdef OPT_ZERO_COPY_LOADER
+						/* FIXME */
+						if (!dlthis->myio->
+						    writemem(dlthis->
+							myio,
+							ibuf.bufr,
+							lptr->
+							load_addr +
+							image_offset,
+							lptr,
+							BYTE_TO_HOST
+							(ibuf.
+							ipacket.
+							packet_size))) {
+							DL_ERROR
+							  ("Write to "
+							  FMT_UI32
+							  " failed",
+							  lptr->
+							  load_addr +
+							  image_offset);
 						}
-#endif
 					}
 				}
 				image_offset +=
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: tidspbridge: remove code referred by OPT_ZERO_COPY_LOADER
  2010-12-20 21:23 [PATCH] staging: tidspbridge: remove code referred by OPT_ZERO_COPY_LOADER Ernesto Ramos
@ 2010-12-24  7:43 ` Ramirez Luna, Omar
  0 siblings, 0 replies; 2+ messages in thread
From: Ramirez Luna, Omar @ 2010-12-24  7:43 UTC (permalink / raw)
  To: Ernesto Ramos; +Cc: linux-omap, linux-kernel, ohad, felipe.contreras

Hi,

On Mon, Dec 20, 2010 at 3:23 PM, Ernesto Ramos <ernesto@ti.com> wrote:
> Remove code referred by OPT_ZERO_COPY_LOADER since it is
> not used.
>
> Signed-off-by: Ernesto Ramos <ernesto@ti.com>
> ---
>  drivers/staging/tidspbridge/dynload/cload.c |   60 +++++++++------------------
>  1 files changed, 20 insertions(+), 40 deletions(-)

Pushed to dspbridge.

Regards,

Omar

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-24  7:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-20 21:23 [PATCH] staging: tidspbridge: remove code referred by OPT_ZERO_COPY_LOADER Ernesto Ramos
2010-12-24  7:43 ` Ramirez Luna, Omar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.