From: Sebastian Herbszt <herbszt@gmx.de>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH] e1000: use pci_config_set_revision()
Date: Mon, 20 Dec 2010 22:31:55 +0100 [thread overview]
Message-ID: <1292880715$3178@local> (raw)
Use pci_config_set_revision().
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
diff --git a/hw/e1000.c b/hw/e1000.c
index af101bd..7bad51a 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1116,7 +1116,7 @@ static int pci_e1000_init(PCIDevice *pci_dev)
pci_config_set_device_id(pci_conf, E1000_DEVID);
/* TODO: we have no capabilities, so why is this bit set? */
pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
- pci_conf[PCI_REVISION_ID] = 0x03;
+ pci_config_set_revision(pci_conf, 0x03);
pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
/* TODO: RST# value should be 0, PCI spec 6.2.4 */
pci_conf[PCI_CACHE_LINE_SIZE] = 0x10;
reply other threads:[~2010-12-20 21:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1292880715$3178@local' \
--to=herbszt@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.