* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2010-12-29 11:01 ` Mika Westerberg
0 siblings, 0 replies; 16+ messages in thread
From: Mika Westerberg @ 2010-12-29 11:01 UTC (permalink / raw)
To: linux-omap; +Cc: linux-arm-kernel, tony, \"Mika Westerberg\"
In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
updating reg and l values. However, at the end of the function we
perform a write:
__raw_writel(l, reg);
So on OMAP2+ we end up writing 0 to the bank->base which is not
correct (typically this points to GPIO_REVISION register).
Fix this by returning immediately after call to
set_24xx_gpio_triggering().
Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
---
arch/arm/plat-omap/gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index c05c653..4dcb66f 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -867,7 +867,7 @@ static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
case METHOD_GPIO_24XX:
case METHOD_GPIO_44XX:
set_24xx_gpio_triggering(bank, gpio, trigger);
- break;
+ return 0;
#endif
default:
goto bad;
--
1.7.3.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2010-12-29 11:01 ` Mika Westerberg
0 siblings, 0 replies; 16+ messages in thread
From: Mika Westerberg @ 2010-12-29 11:01 UTC (permalink / raw)
To: linux-arm-kernel
In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
updating reg and l values. However, at the end of the function we
perform a write:
__raw_writel(l, reg);
So on OMAP2+ we end up writing 0 to the bank->base which is not
correct (typically this points to GPIO_REVISION register).
Fix this by returning immediately after call to
set_24xx_gpio_triggering().
Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
---
arch/arm/plat-omap/gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index c05c653..4dcb66f 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -867,7 +867,7 @@ static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
case METHOD_GPIO_24XX:
case METHOD_GPIO_44XX:
set_24xx_gpio_triggering(bank, gpio, trigger);
- break;
+ return 0;
#endif
default:
goto bad;
--
1.7.3.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2010-12-29 11:01 ` Mika Westerberg
@ 2011-01-04 17:52 ` Kevin Hilman
-1 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-04 17:52 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-omap, linux-arm-kernel, tony
Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
> In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> updating reg and l values. However, at the end of the function we
> perform a write:
>
> __raw_writel(l, reg);
>
> So on OMAP2+ we end up writing 0 to the bank->base which is not
> correct (typically this points to GPIO_REVISION register).
>
> Fix this by returning immediately after call to
> set_24xx_gpio_triggering().
>
> Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
Acked-by: Kevin Hilman <khilman@ti.com>
Tony, this should be added to omap-for-linus as it fixes a problem in
the recently merged GPIO omap_device/hwmod conversion.
Thanks,
Kevin
> ---
> arch/arm/plat-omap/gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index c05c653..4dcb66f 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -867,7 +867,7 @@ static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
> case METHOD_GPIO_24XX:
> case METHOD_GPIO_44XX:
> set_24xx_gpio_triggering(bank, gpio, trigger);
> - break;
> + return 0;
> #endif
> default:
> goto bad;
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-04 17:52 ` Kevin Hilman
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-04 17:52 UTC (permalink / raw)
To: linux-arm-kernel
Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
> In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> updating reg and l values. However, at the end of the function we
> perform a write:
>
> __raw_writel(l, reg);
>
> So on OMAP2+ we end up writing 0 to the bank->base which is not
> correct (typically this points to GPIO_REVISION register).
>
> Fix this by returning immediately after call to
> set_24xx_gpio_triggering().
>
> Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
Acked-by: Kevin Hilman <khilman@ti.com>
Tony, this should be added to omap-for-linus as it fixes a problem in
the recently merged GPIO omap_device/hwmod conversion.
Thanks,
Kevin
> ---
> arch/arm/plat-omap/gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index c05c653..4dcb66f 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -867,7 +867,7 @@ static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
> case METHOD_GPIO_24XX:
> case METHOD_GPIO_44XX:
> set_24xx_gpio_triggering(bank, gpio, trigger);
> - break;
> + return 0;
> #endif
> default:
> goto bad;
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-04 17:52 ` Kevin Hilman
@ 2011-01-04 22:45 ` Kevin Hilman
-1 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-04 22:45 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-omap, linux-arm-kernel, tony
On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>
> > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > updating reg and l values. However, at the end of the function we
> > perform a write:
> >
> > __raw_writel(l, reg);
> >
> > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > correct (typically this points to GPIO_REVISION register).
> >
> > Fix this by returning immediately after call to
> > set_24xx_gpio_triggering().
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Tony, this should be added to omap-for-linus as it fixes a problem in
> the recently merged GPIO omap_device/hwmod conversion.
On second thought, it's a bit late for the main 2.6.38 window, so will
queue this in my pm-fixes branch for the .38-rc cycle.
Kevin
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-04 22:45 ` Kevin Hilman
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-04 22:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>
> > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > updating reg and l values. However, at the end of the function we
> > perform a write:
> >
> > __raw_writel(l, reg);
> >
> > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > correct (typically this points to GPIO_REVISION register).
> >
> > Fix this by returning immediately after call to
> > set_24xx_gpio_triggering().
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Tony, this should be added to omap-for-linus as it fixes a problem in
> the recently merged GPIO omap_device/hwmod conversion.
On second thought, it's a bit late for the main 2.6.38 window, so will
queue this in my pm-fixes branch for the .38-rc cycle.
Kevin
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-04 22:45 ` Kevin Hilman
@ 2011-01-04 23:17 ` Tony Lindgren
-1 siblings, 0 replies; 16+ messages in thread
From: Tony Lindgren @ 2011-01-04 23:17 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Mika Westerberg, linux-omap, linux-arm-kernel
* Kevin Hilman <khilman@ti.com> [110104 14:45]:
> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
> >
> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > > updating reg and l values. However, at the end of the function we
> > > perform a write:
> > >
> > > __raw_writel(l, reg);
> > >
> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > > correct (typically this points to GPIO_REVISION register).
> > >
> > > Fix this by returning immediately after call to
> > > set_24xx_gpio_triggering().
> > >
> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
> >
> > Acked-by: Kevin Hilman <khilman@ti.com>
> >
> > Tony, this should be added to omap-for-linus as it fixes a problem in
> > the recently merged GPIO omap_device/hwmod conversion.
>
> On second thought, it's a bit late for the main 2.6.38 window, so will
> queue this in my pm-fixes branch for the .38-rc cycle.
Yeah let's not mess with omap-for-linus right now, but instead start
queueing up fixes for -rc1.
Tony
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-04 23:17 ` Tony Lindgren
0 siblings, 0 replies; 16+ messages in thread
From: Tony Lindgren @ 2011-01-04 23:17 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@ti.com> [110104 14:45]:
> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
> >
> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > > updating reg and l values. However, at the end of the function we
> > > perform a write:
> > >
> > > __raw_writel(l, reg);
> > >
> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > > correct (typically this points to GPIO_REVISION register).
> > >
> > > Fix this by returning immediately after call to
> > > set_24xx_gpio_triggering().
> > >
> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
> >
> > Acked-by: Kevin Hilman <khilman@ti.com>
> >
> > Tony, this should be added to omap-for-linus as it fixes a problem in
> > the recently merged GPIO omap_device/hwmod conversion.
>
> On second thought, it's a bit late for the main 2.6.38 window, so will
> queue this in my pm-fixes branch for the .38-rc cycle.
Yeah let's not mess with omap-for-linus right now, but instead start
queueing up fixes for -rc1.
Tony
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-04 23:17 ` Tony Lindgren
@ 2011-01-05 10:22 ` Varadarajan, Charulatha
-1 siblings, 0 replies; 16+ messages in thread
From: Varadarajan, Charulatha @ 2011-01-05 10:22 UTC (permalink / raw)
To: Tony Lindgren, Kevin Hilman; +Cc: Mika Westerberg, linux-omap, linux-arm-kernel
Kevin,
On Wed, Jan 5, 2011 at 04:47, Tony Lindgren <tony@atomide.com> wrote:
> * Kevin Hilman <khilman@ti.com> [110104 14:45]:
>> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
>> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>> >
>> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
>> > > updating reg and l values. However, at the end of the function we
>> > > perform a write:
>> > >
>> > > __raw_writel(l, reg);
>> > >
>> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
>> > > correct (typically this points to GPIO_REVISION register).
>> > >
>> > > Fix this by returning immediately after call to
>> > > set_24xx_gpio_triggering().
>> > >
>> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>> >
>> > Acked-by: Kevin Hilman <khilman@ti.com>
>> >
>> > Tony, this should be added to omap-for-linus as it fixes a problem in
>> > the recently merged GPIO omap_device/hwmod conversion.
One clarification - This problem should be existing since the following commit
92105bb70634abacc08bbe12bf6f888fbd7dad38
which was introduced on Sep 7, 2005
FYI, this part of the code remained untouched during GPIO omap_device/hwmod
conversion.
-V Charulatha
>>
>> On second thought, it's a bit late for the main 2.6.38 window, so will
>> queue this in my pm-fixes branch for the .38-rc cycle.
>
> Yeah let's not mess with omap-for-linus right now, but instead start
> queueing up fixes for -rc1.
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-05 10:22 ` Varadarajan, Charulatha
0 siblings, 0 replies; 16+ messages in thread
From: Varadarajan, Charulatha @ 2011-01-05 10:22 UTC (permalink / raw)
To: linux-arm-kernel
Kevin,
On Wed, Jan 5, 2011 at 04:47, Tony Lindgren <tony@atomide.com> wrote:
> * Kevin Hilman <khilman@ti.com> [110104 14:45]:
>> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
>> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>> >
>> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
>> > > updating reg and l values. However, at the end of the function we
>> > > perform a write:
>> > >
>> > > ? __raw_writel(l, reg);
>> > >
>> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
>> > > correct (typically this points to GPIO_REVISION register).
>> > >
>> > > Fix this by returning immediately after call to
>> > > set_24xx_gpio_triggering().
>> > >
>> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>> >
>> > Acked-by: Kevin Hilman <khilman@ti.com>
>> >
>> > Tony, this should be added to omap-for-linus as it fixes a problem in
>> > the recently merged GPIO omap_device/hwmod conversion.
One clarification - This problem should be existing since the following commit
92105bb70634abacc08bbe12bf6f888fbd7dad38
which was introduced on Sep 7, 2005
FYI, this part of the code remained untouched during GPIO omap_device/hwmod
conversion.
-V Charulatha
>>
>> On second thought, it's a bit late for the main 2.6.38 window, so will
>> queue this in my pm-fixes branch for the .38-rc cycle.
>
> Yeah let's not mess with omap-for-linus right now, but instead start
> queueing up fixes for -rc1.
>
> Tony
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-05 10:22 ` Varadarajan, Charulatha
@ 2011-01-05 16:54 ` Kevin Hilman
-1 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-05 16:54 UTC (permalink / raw)
To: Varadarajan, Charulatha
Cc: Tony Lindgren, Mika Westerberg, linux-omap, linux-arm-kernel
Hi Charu,
"Varadarajan, Charulatha" <charu@ti.com> writes:
> On Wed, Jan 5, 2011 at 04:47, Tony Lindgren <tony@atomide.com> wrote:
>> * Kevin Hilman <khilman@ti.com> [110104 14:45]:
>>> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
>>> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>>> >
>>> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
>>> > > updating reg and l values. However, at the end of the function we
>>> > > perform a write:
>>> > >
>>> > > __raw_writel(l, reg);
>>> > >
>>> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
>>> > > correct (typically this points to GPIO_REVISION register).
>>> > >
>>> > > Fix this by returning immediately after call to
>>> > > set_24xx_gpio_triggering().
>>> > >
>>> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>>> >
>>> > Acked-by: Kevin Hilman <khilman@ti.com>
>>> >
>>> > Tony, this should be added to omap-for-linus as it fixes a problem in
>>> > the recently merged GPIO omap_device/hwmod conversion.
>
> One clarification - This problem should be existing since the following commit
> 92105bb70634abacc08bbe12bf6f888fbd7dad38
> which was introduced on Sep 7, 2005
>
> FYI, this part of the code remained untouched during GPIO omap_device/hwmod
> conversion.
>
OK, thanks for the clarification.
I had assumed it was recent changes since the patch didn't apply
cleanly, but am glad to be wrong. :)
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-05 16:54 ` Kevin Hilman
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-05 16:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Charu,
"Varadarajan, Charulatha" <charu@ti.com> writes:
> On Wed, Jan 5, 2011 at 04:47, Tony Lindgren <tony@atomide.com> wrote:
>> * Kevin Hilman <khilman@ti.com> [110104 14:45]:
>>> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
>>> > Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>>> >
>>> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
>>> > > updating reg and l values. However, at the end of the function we
>>> > > perform a write:
>>> > >
>>> > > ? __raw_writel(l, reg);
>>> > >
>>> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
>>> > > correct (typically this points to GPIO_REVISION register).
>>> > >
>>> > > Fix this by returning immediately after call to
>>> > > set_24xx_gpio_triggering().
>>> > >
>>> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>>> >
>>> > Acked-by: Kevin Hilman <khilman@ti.com>
>>> >
>>> > Tony, this should be added to omap-for-linus as it fixes a problem in
>>> > the recently merged GPIO omap_device/hwmod conversion.
>
> One clarification - This problem should be existing since the following commit
> 92105bb70634abacc08bbe12bf6f888fbd7dad38
> which was introduced on Sep 7, 2005
>
> FYI, this part of the code remained untouched during GPIO omap_device/hwmod
> conversion.
>
OK, thanks for the clarification.
I had assumed it was recent changes since the patch didn't apply
cleanly, but am glad to be wrong. :)
Kevin
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-05 16:54 ` Kevin Hilman
@ 2011-01-06 18:12 ` Mika Westerberg
-1 siblings, 0 replies; 16+ messages in thread
From: Mika Westerberg @ 2011-01-06 18:12 UTC (permalink / raw)
To: Kevin Hilman
Cc: Varadarajan, Charulatha, Tony Lindgren, Mika Westerberg,
linux-omap, linux-arm-kernel
Hi Kevin,
On Wed, Jan 05, 2011 at 08:54:48AM -0800, Kevin Hilman wrote:
>
> I had assumed it was recent changes since the patch didn't apply
> cleanly, but am glad to be wrong. :)
The patch should apply cleanly on the latest mainline. Do you want me to
rebase it against some other tree and resend?
Thanks,
MW
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-06 18:12 ` Mika Westerberg
0 siblings, 0 replies; 16+ messages in thread
From: Mika Westerberg @ 2011-01-06 18:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kevin,
On Wed, Jan 05, 2011 at 08:54:48AM -0800, Kevin Hilman wrote:
>
> I had assumed it was recent changes since the patch didn't apply
> cleanly, but am glad to be wrong. :)
The patch should apply cleanly on the latest mainline. Do you want me to
rebase it against some other tree and resend?
Thanks,
MW
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
2011-01-06 18:12 ` Mika Westerberg
@ 2011-01-06 18:34 ` Kevin Hilman
-1 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-06 18:34 UTC (permalink / raw)
To: Mika Westerberg
Cc: Varadarajan, Charulatha, Tony Lindgren, Mika Westerberg,
linux-omap, linux-arm-kernel
Mika Westerberg <mika.westerberg@iki.fi> writes:
> Hi Kevin,
>
> On Wed, Jan 05, 2011 at 08:54:48AM -0800, Kevin Hilman wrote:
>>
>> I had assumed it was recent changes since the patch didn't apply
>> cleanly, but am glad to be wrong. :)
>
> The patch should apply cleanly on the latest mainline. Do you want me to
> rebase it against some other tree and resend?
No, it's fine. I'll be queueing it for .38-rc2 and it's in my
'fixes-for-tony' branch.
Kevin
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
@ 2011-01-06 18:34 ` Kevin Hilman
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2011-01-06 18:34 UTC (permalink / raw)
To: linux-arm-kernel
Mika Westerberg <mika.westerberg@iki.fi> writes:
> Hi Kevin,
>
> On Wed, Jan 05, 2011 at 08:54:48AM -0800, Kevin Hilman wrote:
>>
>> I had assumed it was recent changes since the patch didn't apply
>> cleanly, but am glad to be wrong. :)
>
> The patch should apply cleanly on the latest mainline. Do you want me to
> rebase it against some other tree and resend?
No, it's fine. I'll be queueing it for .38-rc2 and it's in my
'fixes-for-tony' branch.
Kevin
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2011-01-06 18:35 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-29 11:01 [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+ Mika Westerberg
2010-12-29 11:01 ` Mika Westerberg
2011-01-04 17:52 ` Kevin Hilman
2011-01-04 17:52 ` Kevin Hilman
2011-01-04 22:45 ` Kevin Hilman
2011-01-04 22:45 ` Kevin Hilman
2011-01-04 23:17 ` Tony Lindgren
2011-01-04 23:17 ` Tony Lindgren
2011-01-05 10:22 ` Varadarajan, Charulatha
2011-01-05 10:22 ` Varadarajan, Charulatha
2011-01-05 16:54 ` Kevin Hilman
2011-01-05 16:54 ` Kevin Hilman
2011-01-06 18:12 ` Mika Westerberg
2011-01-06 18:12 ` Mika Westerberg
2011-01-06 18:34 ` Kevin Hilman
2011-01-06 18:34 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.