From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: ath9k-devel@venema.h4ckr.net, Ben Greear <greearb@candelatech.com> Subject: [PATCH RESEND 05/11] ath9k: Ensure xmit makes progress. Date: Sun, 9 Jan 2011 23:11:47 -0800 [thread overview] Message-ID: <1294643513-18820-6-git-send-email-greearb@candelatech.com> (raw) In-Reply-To: <1294643513-18820-1-git-send-email-greearb@candelatech.com> From: Ben Greear <greearb@candelatech.com> If the txq->axq_q is empty, the code was breaking out of the tx_processq logic without checking to see if it should transmit other queued AMPDU frames (txq->axq_acq). This patches ensures ath_txq_schedule is called. This needs review. Signed-off-by: Ben Greear <greearb@candelatech.com> --- :100644 100644 c769037... 2248e47... M drivers/net/wireless/ath/ath9k/xmit.c drivers/net/wireless/ath/ath9k/xmit.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index c769037..2248e47 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c @@ -1999,6 +1999,8 @@ static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq) spin_lock_bh(&txq->axq_lock); if (list_empty(&txq->axq_q)) { txq->axq_link = NULL; + if (sc->sc_flags & SC_OP_TXAGGR) + ath_txq_schedule(sc, txq); spin_unlock_bh(&txq->axq_lock); break; } -- 1.7.2.3
WARNING: multiple messages have this Message-ID (diff)
From: greearb at candelatech.com <greearb@candelatech.com> To: ath9k-devel@lists.ath9k.org Subject: [ath9k-devel] [PATCH RESEND 05/11] ath9k: Ensure xmit makes progress. Date: Sun, 9 Jan 2011 23:11:47 -0800 [thread overview] Message-ID: <1294643513-18820-6-git-send-email-greearb@candelatech.com> (raw) In-Reply-To: <1294643513-18820-1-git-send-email-greearb@candelatech.com> From: Ben Greear <greearb@candelatech.com> If the txq->axq_q is empty, the code was breaking out of the tx_processq logic without checking to see if it should transmit other queued AMPDU frames (txq->axq_acq). This patches ensures ath_txq_schedule is called. This needs review. Signed-off-by: Ben Greear <greearb@candelatech.com> --- :100644 100644 c769037... 2248e47... M drivers/net/wireless/ath/ath9k/xmit.c drivers/net/wireless/ath/ath9k/xmit.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index c769037..2248e47 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c @@ -1999,6 +1999,8 @@ static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq) spin_lock_bh(&txq->axq_lock); if (list_empty(&txq->axq_q)) { txq->axq_link = NULL; + if (sc->sc_flags & SC_OP_TXAGGR) + ath_txq_schedule(sc, txq); spin_unlock_bh(&txq->axq_lock); break; } -- 1.7.2.3
next prev parent reply other threads:[~2011-01-10 7:12 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-10 7:11 ath9k: Resend all my pending patches greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 01/11] ath9k: Show some live tx-queue values in debugfs greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 02/11] ath9k: Initialize ah->hw greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 03/11] ath9k: Add more information to debugfs xmit file greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 04/11] ath9k: Remove un-used member from ath_node greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` greearb [this message] 2011-01-10 7:11 ` [ath9k-devel] [PATCH RESEND 05/11] ath9k: Ensure xmit makes progress greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 06/11] ath9k: Add counters to distinquish AMPDU enqueues greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 07/11] ath9k: Keep track of stations for debugfs greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 08/11] ath9k: More xmit queue debugfs information greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 09/11] ath9k: Try all queues when looking for next packet to send greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-25 21:37 ` John W. Linville 2011-01-25 21:37 ` [ath9k-devel] " John W. Linville 2011-01-25 22:01 ` Ben Greear 2011-01-25 22:01 ` [ath9k-devel] " Ben Greear 2011-01-10 7:11 ` [PATCH RESEND 10/11] ath9k: Restart xmit logic in xmit watchdog greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 7:11 ` [PATCH RESEND 11/11] ath9k: Implement rx copy-break greearb 2011-01-10 7:11 ` [ath9k-devel] " greearb at candelatech.com 2011-01-10 15:19 ` Felix Fietkau 2011-01-10 15:19 ` [ath9k-devel] " Felix Fietkau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1294643513-18820-6-git-send-email-greearb@candelatech.com \ --to=greearb@candelatech.com \ --cc=ath9k-devel@venema.h4ckr.net \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.