All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes
@ 2011-01-16 23:32 Paul Menzel
  2011-01-16 23:36 ` [PATCH 2/3] libomxil-bellagio: create and use recipe include file (INC file) Paul Menzel
  2011-01-17  8:14 ` [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Koen Kooi
  0 siblings, 2 replies; 12+ messages in thread
From: Paul Menzel @ 2011-01-16 23:32 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3421 bytes --]

Date: Sun, 16 Jan 2011 23:34:08 +0100

Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].

[1] http://wiki.openembedded.org/index.php/Styleguide

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
 recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
 recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
 3 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
index 3be6dde..aa78d6f 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.0.bb
@@ -6,13 +6,11 @@ DEPENDS = "alsa-lib ffmpeg \
 PR = "r7"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
+SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
 
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
 FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-
-SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
-SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
index 942f963..958ac26 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.1.bb
@@ -3,16 +3,14 @@ LICENSE = "LGPLv2"
 DEPENDS = "alsa-lib ffmpeg \
            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
-
 PR = "r1"
 
+SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
+SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
+
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
 FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-
-SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
-SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
index a58b296..ff30c10 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.2.bb
@@ -3,10 +3,12 @@ LICENSE = "LGPLv2"
 DEPENDS = "alsa-lib ffmpeg \
            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
-
 PR = "r1"
 
+SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
+SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
+
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
@@ -14,7 +16,3 @@ FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
 
 PARALLEL_MAKE = ""
-
-
-SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
-SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
-- 
1.7.2.3

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/3] libomxil-bellagio: create and use recipe include file (INC file)
  2011-01-16 23:32 [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Paul Menzel
@ 2011-01-16 23:36 ` Paul Menzel
  2011-01-16 23:43   ` [PATCH 3/3] libomxil-bellagio_git: add Git version Paul Menzel
  2011-01-17  8:14 ` [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Koen Kooi
  1 sibling, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-16 23:36 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 5673 bytes --]

Date: Sun, 16 Jan 2011 23:42:50 +0100

Create a recipe include file. The only difference now is, that the following version also include `PARALLEL_MAKE = ""`.

• 0.9.0
• 0.9.1

[1] http://wiki.openembedded.org/index.php/Styleguide#PR_variables_with_recipes_that_use_INC_files

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/openmax/libomxil-bellagio.inc        |   16 ++++++++++++++++
 recipes/openmax/libomxil-bellagio_0.9.0.bb   |   14 ++------------
 recipes/openmax/libomxil-bellagio_0.9.1.bb   |   14 ++------------
 recipes/openmax/libomxil-bellagio_0.9.2.1.bb |   17 +++--------------
 recipes/openmax/libomxil-bellagio_0.9.2.bb   |   16 ++--------------
 5 files changed, 25 insertions(+), 52 deletions(-)
 create mode 100644 recipes/openmax/libomxil-bellagio.inc

diff --git a/recipes/openmax/libomxil-bellagio.inc b/recipes/openmax/libomxil-bellagio.inc
new file mode 100644
index 0000000..8c3a82c
--- /dev/null
+++ b/recipes/openmax/libomxil-bellagio.inc
@@ -0,0 +1,16 @@
+DESCRIPTION = "OpenMAX Integration Layer (IL) is a standard API to access Multimedia Components on mobile platforms. It has been defined by the Khronos group."
+LICENSE = "LGPLv2"
+DEPENDS = "alsa-lib ffmpeg \
+           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
+
+INC_PR = "r7"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+
+inherit autotools
+
+FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
+FILES_${PN}-dev += "${libdir}/bellagio/*.a"
+FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
+
+PARALLEL_MAKE = ""
diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
index aa78d6f..70a0583 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.0.bb
@@ -1,16 +1,6 @@
-DESCRIPTION = "OpenMAX Integration Layer (IL) is a standard API to access Multimedia Components on mobile platforms. It has been defined by the Khronos group."
-LICENSE = "LGPLv2"
-DEPENDS = "alsa-lib ffmpeg \
-           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
+require ${PN}.inc
 
-PR = "r7"
+PR = "${INC_PR}.0"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
 SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
-
-inherit autotools
-
-FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
-FILES_${PN}-dev += "${libdir}/bellagio/*.a"
-FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
index 958ac26..e738a9d 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.1.bb
@@ -1,16 +1,6 @@
-DESCRIPTION = "OpenMAX Integration Layer (IL) is a standard API to access Multimedia Components on mobile platforms. It has been defined by the Khronos group."
-LICENSE = "LGPLv2"
-DEPENDS = "alsa-lib ffmpeg \
-           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
+require ${PN}.inc
 
-PR = "r1"
+PR = "${INC_PR}.0"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
 SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
-
-inherit autotools
-
-FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
-FILES_${PN}-dev += "${libdir}/bellagio/*.a"
-FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
index 7f74b6f..f21c731 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
@@ -1,17 +1,6 @@
-DESCRIPTION = "OpenMAX Integration Layer (IL) is a standard API to access Multimedia Components on mobile platforms. It has been defined by the Khronos group."
-LICENSE = "LGPLv2"
-DEPENDS = "alsa-lib ffmpeg \
-           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
+require ${PN}.inc
+
+PR = "${INC_PR}.0"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "323049db668ab260870fd7ecd2ec4156"
 SRC_URI[sha256sum] = "75cf8d3b5cac2764420ae2cc7846b9bb12a47d2ca04c96e5821309b0124ddc72"
-
-inherit autotools
-
-FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
-FILES_${PN}-dev += "${libdir}/bellagio/*.a"
-FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-PARALLEL_MAKE = ""
-
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
index ff30c10..98876ea 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.2.bb
@@ -1,18 +1,6 @@
-DESCRIPTION = "OpenMAX Integration Layer (IL) is a standard API to access Multimedia Components on mobile platforms. It has been defined by the Khronos group."
-LICENSE = "LGPLv2"
-DEPENDS = "alsa-lib ffmpeg \
-           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
+require ${PN}.inc
 
-PR = "r1"
+PR = "${INC_PR}.0"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
 SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
-
-inherit autotools
-
-FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
-FILES_${PN}-dev += "${libdir}/bellagio/*.a"
-FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-PARALLEL_MAKE = ""
-- 
1.7.2.3

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/3] libomxil-bellagio_git: add Git version
  2011-01-16 23:36 ` [PATCH 2/3] libomxil-bellagio: create and use recipe include file (INC file) Paul Menzel
@ 2011-01-16 23:43   ` Paul Menzel
  2011-01-17  8:13     ` Koen Kooi
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-16 23:43 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Date: Mon, 17 Jan 2011 00:15:51 +0100

The last release is over a year old (2009-12-23).

Build tested with `angstrom-2008.1` for `MACHINE = "beagleboard"`.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
1. I hope the package numbering is correctly. I used the Freesmartphone packages as an example.
2. Is a `DP = "-1"` needed? Users of this recipe speak up please!
---
 recipes/openmax/libomxil-bellagio_git.bb |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
 create mode 100644 recipes/openmax/libomxil-bellagio_git.bb

diff --git a/recipes/openmax/libomxil-bellagio_git.bb b/recipes/openmax/libomxil-bellagio_git.bb
new file mode 100644
index 0000000..4877fb3
--- /dev/null
+++ b/recipes/openmax/libomxil-bellagio_git.bb
@@ -0,0 +1,10 @@
+require ${PN}.inc
+
+PR = "${INC_PR}.0"
+
+SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
+SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
+PV = "0.9.2.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"
+
+S = "${WORKDIR}/git"
-- 
1.7.2.3


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] libomxil-bellagio_git: add Git version
  2011-01-16 23:43   ` [PATCH 3/3] libomxil-bellagio_git: add Git version Paul Menzel
@ 2011-01-17  8:13     ` Koen Kooi
  2011-01-17 11:45       ` [PATCH 3/3 v2] " Paul Menzel
  0 siblings, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2011-01-17  8:13 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-01-11 00:43, Paul Menzel wrote:
> Date: Mon, 17 Jan 2011 00:15:51 +0100
> 
> The last release is over a year old (2009-12-23).
> 
> Build tested with `angstrom-2008.1` for `MACHINE = "beagleboard"`.
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> 1. I hope the package numbering is correctly. I used the Freesmartphone packages as an example.
> 2. Is a `DP = "-1"` needed? Users of this recipe speak up please!

> +SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
> +SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
> +PV = "0.9.2.1+gitr${SRCPV}"
> +PR = "${INC_PR}.0"

For get recipes we generally do:

PR_append = "+gitr${SRCPV}" to keep the ugly hash out of PV, but keep it
available to the users
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNM/o2MkyGM64RGpERAiHnAJsGOFj7m3bh8Z5NepPB1ny1Z0hFBACgh9jW
LLatQnq+F8sl+/wKpvm+PbQ=
=IoJM
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes
  2011-01-16 23:32 [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Paul Menzel
  2011-01-16 23:36 ` [PATCH 2/3] libomxil-bellagio: create and use recipe include file (INC file) Paul Menzel
@ 2011-01-17  8:14 ` Koen Kooi
  2011-01-17 11:48   ` Paul Menzel
  1 sibling, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2011-01-17  8:14 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-01-11 00:32, Paul Menzel wrote:
> Date: Sun, 16 Jan 2011 23:34:08 +0100
> 
> Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
> 
> [1] http://wiki.openembedded.org/index.php/Styleguide
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
>  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
>  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------


FWIW, the above two aren't used and can get deleted, I suspect they
don't even build against our recent ffmpeg

>  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
>  3 files changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
> index 3be6dde..aa78d6f 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.0.bb
> @@ -6,13 +6,11 @@ DEPENDS = "alsa-lib ffmpeg \
>  PR = "r7"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
> +SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
>  
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
>  FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
> -
> -
> -SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
> -SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
> index 942f963..958ac26 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.1.bb
> @@ -3,16 +3,14 @@ LICENSE = "LGPLv2"
>  DEPENDS = "alsa-lib ffmpeg \
>             ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
>  
> -SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> -
>  PR = "r1"
>  
> +SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
> +SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
> +
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
>  FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
> -
> -
> -SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
> -SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
> index a58b296..ff30c10 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.2.bb
> @@ -3,10 +3,12 @@ LICENSE = "LGPLv2"
>  DEPENDS = "alsa-lib ffmpeg \
>             ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
>  
> -SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> -
>  PR = "r1"
>  
> +SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
> +SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
> +
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
> @@ -14,7 +16,3 @@ FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
>  
>  PARALLEL_MAKE = ""
> -
> -
> -SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
> -SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNM/psMkyGM64RGpERAoYrAKCTFgLDR/mHygAKKwmD5pqJxfCtSACfb5Wg
TsuMu6328pV5Il9+0+ZBN1w=
=K64M
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 3/3 v2] libomxil-bellagio_git: add Git version
  2011-01-17  8:13     ` Koen Kooi
@ 2011-01-17 11:45       ` Paul Menzel
  2011-01-18 23:20         ` [PATCH] libomxil-bellagio_{0.9.2.1, git}: add patch: remove `-Werror` from `CFLAGS` to fix build with GCC 4.5 Paul Menzel
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-17 11:45 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3092 bytes --]

Date: Mon, 17 Jan 2011 00:15:51 +0100

The last release 0.9.2.1 is over a year old (2009-12-23).

Build tested with `angstrom-2008.1` for `MACHINE = "beagleboard"`. With `angstrom-2010.x` it fails with the following error.

        arm-angstrom-linux-gnueabi-libtool: compile:  arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I../.. -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I../../include -I../../src -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wall -Werror -DCONFIG_DEBUG_LEVEL=0 -MT libomxbase_la-omx_base_component.lo -MD -MP -MF .deps/libomxbase_la-omx_base_component.Tpo -c omx_base_component.c  -fPIC -DPIC -o .libs/libomxbase_la-omx_base_component.o
        cc1: warnings being treated as errors
        omx_base_component.c: In function 'omx_base_component_GetParameter':
        omx_base_component.c:991:3: error: case value '2130706435' not in enumerated type 'OMX_INDEXTYPE'
        omx_base_component.c:918:3: error: case value '2130706436' not in enumerated type 'OMX_INDEXTYPE'
        make[3]: *** [libomxbase_la-omx_base_component.lo] Error 1
        make[3]: Leaving directory `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libomxil-bellagio-0.9.2.1+gitr0+772f0eca88b242ffb5469e8e381c63ce1f7cd3e1-r7.0/git/src/base'

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
Am Montag, den 17.01.2011, 09:13 +0100 schrieb Koen Kooi:
> On 17-01-11 00:43, Paul Menzel wrote:

[…]

> > 1. I hope the package numbering is correctly. I used the Freesmartphone packages as an example.
> > 2. Is a `DP = "-1"` needed? Users of this recipe speak up please!
> 
> > +SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
> > +SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
> > +PV = "0.9.2.1+gitr${SRCPV}"
> > +PR = "${INC_PR}.0"
> 
> For get recipes we generally do:
> 
> PR_append = "+gitr${SRCPV}" to keep the ugly hash out of PV, but keep it
> available to the users

Should the manual be a updated then [1]?


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/usermanual.html#id536032
---
 recipes/openmax/libomxil-bellagio_git.bb |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 recipes/openmax/libomxil-bellagio_git.bb

diff --git a/recipes/openmax/libomxil-bellagio_git.bb b/recipes/openmax/libomxil-bellagio_git.bb
new file mode 100644
index 0000000..4e28251
--- /dev/null
+++ b/recipes/openmax/libomxil-bellagio_git.bb
@@ -0,0 +1,11 @@
+require ${PN}.inc
+
+PR = "${INC_PR}.0"
+
+SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
+SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
+PV = "0.9.2.1"
+PR = "${INC_PR}.0"
+PR_append = "+gitr${SRCPV}"
+
+S = "${WORKDIR}/git"
-- 
1.7.2.3

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes
  2011-01-17  8:14 ` [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Koen Kooi
@ 2011-01-17 11:48   ` Paul Menzel
  2011-01-17 13:08     ` Koen Kooi
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-17 11:48 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

Am Montag, den 17.01.2011, 09:14 +0100 schrieb Koen Kooi:
> On 17-01-11 00:32, Paul Menzel wrote:
> > Date: Sun, 16 Jan 2011 23:34:08 +0100
> > 
> > Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
> > 
> > [1] http://wiki.openembedded.org/index.php/Styleguide
> > 
> > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > ---
> >  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
> >  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
> 
> 
> FWIW, the above two aren't used and can get deleted, I suspect they
> don't even build against our recent ffmpeg

Is it alright to send a follow-up patch after this patch series has been
committed?

> >  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------

Just for my interest, what is the reason to use 0.9.2 instead of
0.9.2.1?

[…]


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes
  2011-01-17 11:48   ` Paul Menzel
@ 2011-01-17 13:08     ` Koen Kooi
  2011-01-18 23:31       ` [PATCH] libomxil-bellagio: remove/delete unused versions 0.9.{0, 1, 2} Paul Menzel
  0 siblings, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2011-01-17 13:08 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-01-11 12:48, Paul Menzel wrote:
> Am Montag, den 17.01.2011, 09:14 +0100 schrieb Koen Kooi:
>> On 17-01-11 00:32, Paul Menzel wrote:
>>> Date: Sun, 16 Jan 2011 23:34:08 +0100
>>>
>>> Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
>>>
>>> [1] http://wiki.openembedded.org/index.php/Styleguide
>>>
>>> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
>>> ---
>>>  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
>>>  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
>>
>>
>> FWIW, the above two aren't used and can get deleted, I suspect they
>> don't even build against our recent ffmpeg
> 
> Is it alright to send a f
ollow-up patch after this patch series has been
> committed?

surr

> 
>>>  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
> 
> Just for my interest, what is the reason to use 0.9.2 instead of
> 0.9.2.1?

none, I just misread :) 0.9.2 can go as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNND8/MkyGM64RGpERApd6AJ9DR9W5xf8JmOFojgIRHoMijdZNCgCcDRRa
9NuIBOL4QaBwqn3jhGQV5xM=
=AXCH
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] libomxil-bellagio_{0.9.2.1, git}: add patch: remove `-Werror` from `CFLAGS` to fix build with GCC 4.5
  2011-01-17 11:45       ` [PATCH 3/3 v2] " Paul Menzel
@ 2011-01-18 23:20         ` Paul Menzel
  2011-01-20 10:14           ` Paul Menzel
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-18 23:20 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 5045 bytes --]

Date: Mon Jan 17 23:50:33 2011 +0100

Am Montag, den 17.01.2011, 12:45 +0100 schrieb Paul Menzel:
> Build tested with `angstrom-2008.1` for `MACHINE = "beagleboard"`. With `angstrom-2010.x` it fails with the following error.
>
>         arm-angstrom-linux-gnueabi-libtool: compile:  arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I../.. -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I../../include -I../../src -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wall -Werror -DCONFIG_DEBUG_LEVEL=0 -MT libomxbase_la-omx_base_component.lo -MD -MP -MF .deps/libomxbase_la-omx_base_component.Tpo -c omx_base_component.c  -fPIC -DPIC -o .libs/libomxbase_la-omx_base_component.o
>         cc1: warnings being treated as errors
>         omx_base_component.c: In function 'omx_base_component_GetParameter':
>         omx_base_component.c:991:3: error: case value '2130706435' not in enumerated type 'OMX_INDEXTYPE'
>         omx_base_component.c:918:3: error: case value '2130706436' not in enumerated type 'OMX_INDEXTYPE'
>         make[3]: *** [libomxbase_la-omx_base_component.lo] Error 1
>         make[3]: Leaving directory `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libomxil-bellagio-0.9.2.1+gitr0+772f0eca88b242ffb5469e8e381c63ce1f7cd3e1-r7.0/git/src/base'

Upstream advised to remove `-Werror` and is looking into it [1]. OpenBricks is applying the same patch [2].

A similar patch would make 0.9.2 compile, but this one here does not apply there (`CFLAGS="${CFLAGS} -Werror"` instead of `CFLAGS="${CFLAGS} -Wall -Werror"`).

[1] http://sourceforge.net/mailarchive/message.php?msg_id=26911808
[2] http://hg.openbricks.org/openbricks/rev/4f4ed3a596f2

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 ...01-configure.ac-remove-Werror-from-CFLAGS.patch |   32 ++++++++++++++++++++
 recipes/openmax/libomxil-bellagio_0.9.2.1.bb       |    4 ++
 recipes/openmax/libomxil-bellagio_git.bb           |    3 ++
 3 files changed, 39 insertions(+), 0 deletions(-)
 create mode 100644 recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch

diff --git a/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch b/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch
new file mode 100644
index 0000000..1df2b26
--- /dev/null
+++ b/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch
@@ -0,0 +1,32 @@
+From 85a2b9666ba2b65920f4ad0e2216405dc14340d4 Mon Sep 17 00:00:00 2001
+From: Paul Menzel <paulepanter@users.sourceforge.net>
+Date: Mon, 17 Jan 2011 23:35:18 +0100
+Subject: [PATCH] configure.ac: remove `-Werror` from `CFLAGS`
+
+These options should be set when compiling the program and passed by an environment variable. Or there should be an option to turn these restrictive options off.
+
+Currently the build fails at least with GCC 4.5. It is known to work with GCC 4.3.3 [1].
+
+[1] http://sourceforge.net/mailarchive/message.php?msg_id=26911808
+
+Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
+---
+ configure.ac |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index d6e0bc9..fb5c8c8 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -5,7 +5,7 @@ AM_INIT_AUTOMAKE()
+ AC_PREREQ([2.59])
+ 
+ AC_CONFIG_HEADERS([config.h])
+-CFLAGS="${CFLAGS} -Wall -Werror"
++CFLAGS="${CFLAGS} -Wall"
+ 
+ ################################################################################
+ # Set the shared versioning info, according to section 6.3 of the libtool info #
+-- 
+1.7.2.3
+
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
index f21c731..89f521a 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
@@ -2,5 +2,9 @@ require ${PN}.inc
 
 PR = "${INC_PR}.0"
 
+SRC_URI += " \
+	file://0001-configure.ac-remove-Werror-from-CFLAGS.patch \
+"
+
 SRC_URI[md5sum] = "323049db668ab260870fd7ecd2ec4156"
 SRC_URI[sha256sum] = "75cf8d3b5cac2764420ae2cc7846b9bb12a47d2ca04c96e5821309b0124ddc72"
diff --git a/recipes/openmax/libomxil-bellagio_git.bb b/recipes/openmax/libomxil-bellagio_git.bb
index 4e28251..f58adf4 100644
--- a/recipes/openmax/libomxil-bellagio_git.bb
+++ b/recipes/openmax/libomxil-bellagio_git.bb
@@ -4,6 +4,9 @@ PR = "${INC_PR}.0"
 
 SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
 SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
+SRC_URI += " \
+	file://0001-configure.ac-remove-Werror-from-CFLAGS.patch \
+"
 PV = "0.9.2.1"
 PR = "${INC_PR}.0"
 PR_append = "+gitr${SRCPV}"
-- 
1.7.2.3

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] libomxil-bellagio: remove/delete unused versions 0.9.{0, 1, 2}
  2011-01-17 13:08     ` Koen Kooi
@ 2011-01-18 23:31       ` Paul Menzel
  2011-01-19  7:23         ` Koen Kooi
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Menzel @ 2011-01-18 23:31 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 5789 bytes --]

Date: Tue Jan 18 16:55:14 2011 +0100

These version are not used anymore and 0.9.{0,1} do not even build with current FFmpeg [1].

	$ zless minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/temp/log.do_compile.16833
	[…]
	/bin/sh ../../../arm-oe-linux-gnueabi-libtool  --tag=CC   --mode=compile arm-oe-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -m
	no-thumb -DHAVE_CONFIG_H -I. -I../../..   -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -I/oe/build-minimal-eglibc/m
	inimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr//include   -I../../../include -I../../../src -I../../../src/base -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/arm
	v7a-oe-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os -pthread -g -Wall -MT libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo -MD -
	MP -MF .deps/libomxffmpeg_la-omx_ffmpeg_colorconv_component.Tpo -c -o libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo `test -f 'omx_ffmpeg_colorconv_component.c' || echo './'`omx
	_ffmpeg_colorconv_component.c
	arm-oe-linux-gnueabi-libtool: compile:  arm-oe-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I..
	/../.. -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -I/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux
	-gnueabi/usr//include -I../../../include -I../../../src -I../../../src/base -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -fex
	pensive-optimizations -fomit-frame-pointer -frename-registers -Os -pthread -g -Wall -MT libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo -MD -MP -MF .deps/libomxffmpeg_la-omx_ffmp
	eg_colorconv_component.Tpo -c omx_ffmpeg_colorconv_component.c  -fPIC -DPIC -o .libs/libomxffmpeg_la-omx_ffmpeg_colorconv_component.o
	omx_ffmpeg_colorconv_component.c: In function 'find_ffmpeg_pxlfmt':
	omx_ffmpeg_colorconv_component.c:72:23: error: 'PIX_FMT_RGBA32' undeclared (first use in this function)
	omx_ffmpeg_colorconv_component.c:72:23: note: each undeclared identifier is reported only once for each function it appears in
	omx_ffmpeg_colorconv_component.c: In function 'omx_ffmpeg_colorconv_component_BufferMgmtCallback':
	omx_ffmpeg_colorconv_component.c:799:13: warning: passing argument 2 of 'sws_scale' from incompatible pointer type
	/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include/libswscale/swscale.h:195:5: note: expected 'const uint8_t * const*' but argument is of type 'uint8_t **'
	make[4]: *** [libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo] Error 1
	make[4]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src/components/ffmpeg'
	make[3]: *** [all-recursive] Error 1
	make[3]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src/components'
	make[2]: *** [all-recursive] Error 1
	make[2]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src'
	make[1]: *** [all-recursive] Error 1
	make[1]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0'
	make: *** [all] Error 2
	FATAL: oe_runmake failed
	ERROR: Function do_compile failed

0.9.2 probably would build with a similar as [2]. Furthermore 0.9.2.1 has been around for over a year (77195e32 [2]).

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-January/028804.html
[2] http://patches.openembedded.org/patch/315/
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=77195e32400dd86facc038f61190139d38f14b31

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ------
 recipes/openmax/libomxil-bellagio_0.9.1.bb |    6 ------
 recipes/openmax/libomxil-bellagio_0.9.2.bb |    6 ------
 3 files changed, 0 insertions(+), 18 deletions(-)
 delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.0.bb
 delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.1.bb
 delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.2.bb

diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
deleted file mode 100644
index 70a0583..0000000
--- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
+++ /dev/null
@@ -1,6 +0,0 @@
-require ${PN}.inc
-
-PR = "${INC_PR}.0"
-
-SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
-SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
deleted file mode 100644
index e738a9d..0000000
--- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
+++ /dev/null
@@ -1,6 +0,0 @@
-require ${PN}.inc
-
-PR = "${INC_PR}.0"
-
-SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
-SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
deleted file mode 100644
index 98876ea..0000000
--- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
+++ /dev/null
@@ -1,6 +0,0 @@
-require ${PN}.inc
-
-PR = "${INC_PR}.0"
-
-SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
-SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
-- 
1.7.2.3

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] libomxil-bellagio: remove/delete unused versions 0.9.{0, 1, 2}
  2011-01-18 23:31       ` [PATCH] libomxil-bellagio: remove/delete unused versions 0.9.{0, 1, 2} Paul Menzel
@ 2011-01-19  7:23         ` Koen Kooi
  0 siblings, 0 replies; 12+ messages in thread
From: Koen Kooi @ 2011-01-19  7:23 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 19-01-11 00:31, Paul Menzel wrote:
> Date: Tue Jan 18 16:55:14 2011 +0100
> 
> These version are not used anymore and 0.9.{0,1} do not even build with current FFmpeg [1].
> 
> 	$ zless minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/temp/log.do_compile.16833
> 	[…]
> 	/bin/sh ../../../arm-oe-linux-gnueabi-libtool  --tag=CC   --mode=compile arm-oe-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -m
> 	no-thumb -DHAVE_CONFIG_H -I. -I../../..   -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -I/oe/build-minimal-eglibc/m
> 	inimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr//include   -I../../../include -I../../../src -I../../../src/base -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/arm
> 	v7a-oe-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os -pthread -g -Wall -MT libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo -MD -
> 	MP -MF .deps/libomxffmpeg_la-omx_ffmpeg_colorconv_component.Tpo -c -o libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo `test -f 'omx_ffmpeg_colorconv_component.c' || echo './'`omx
> 	_ffmpeg_colorconv_component.c
> 	arm-oe-linux-gnueabi-libtool: compile:  arm-oe-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I..
> 	/../.. -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -I/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux
> 	-gnueabi/usr//include -I../../../include -I../../../src -I../../../src/base -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include -fex
> 	pensive-optimizations -fomit-frame-pointer -frename-registers -Os -pthread -g -Wall -MT libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo -MD -MP -MF .deps/libomxffmpeg_la-omx_ffmp
> 	eg_colorconv_component.Tpo -c omx_ffmpeg_colorconv_component.c  -fPIC -DPIC -o .libs/libomxffmpeg_la-omx_ffmpeg_colorconv_component.o
> 	omx_ffmpeg_colorconv_component.c: In function 'find_ffmpeg_pxlfmt':
> 	omx_ffmpeg_colorconv_component.c:72:23: error: 'PIX_FMT_RGBA32' undeclared (first use in this function)
> 	omx_ffmpeg_colorconv_component.c:72:23: note: each undeclared identifier is reported only once for each function it appears in
> 	omx_ffmpeg_colorconv_component.c: In function 'omx_ffmpeg_colorconv_component_BufferMgmtCallback':
> 	omx_ffmpeg_colorconv_component.c:799:13: warning: passing argument 2 of 'sws_scale' from incompatible pointer type
> 	/oe/build-minimal-eglibc/minimal-dev/sysroots/armv7a-oe-linux-gnueabi/usr/include/libswscale/swscale.h:195:5: note: expected 'const uint8_t * const*' but argument is of type 'uint8_t **'
> 	make[4]: *** [libomxffmpeg_la-omx_ffmpeg_colorconv_component.lo] Error 1
> 	make[4]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src/components/ffmpeg'
> 	make[3]: *** [all-recursive] Error 1
> 	make[3]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src/components'
> 	make[2]: *** [all-recursive] Error 1
> 	make[2]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0/src'
> 	make[1]: *** [all-recursive] Error 1
> 	make[1]: Leaving directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libomxil-bellagio-0.9.0-r8.0/libomxil-bellagio-0.9.0'
> 	make: *** [all] Error 2
> 	FATAL: oe_runmake failed
> 	ERROR: Function do_compile failed
> 
> 0.9.2 probably would build with a similar as [2]. Furthermore 0.9.2.1 has been around for over a year (77195e32 [2]).
> 
> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-January/028804.html
> [2] http://patches.openembedded.org/patch/315/
> [3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=77195e32400dd86facc038f61190139d38f14b31
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>

Acked-by: Koen Kooi <koen@openembedded.org>


> ---
>  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ------
>  recipes/openmax/libomxil-bellagio_0.9.1.bb |    6 ------
>  recipes/openmax/libomxil-bellagio_0.9.2.bb |    6 ------
>  3 files changed, 0 insertions(+), 18 deletions(-)
>  delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.0.bb
>  delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.1.bb
>  delete mode 100644 recipes/openmax/libomxil-bellagio_0.9.2.bb
> 
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
> deleted file mode 100644
> index 70a0583..0000000
> --- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -require ${PN}.inc
> -
> -PR = "${INC_PR}.0"
> -
> -SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
> -SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
> deleted file mode 100644
> index e738a9d..0000000
> --- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -require ${PN}.inc
> -
> -PR = "${INC_PR}.0"
> -
> -SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
> -SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
> deleted file mode 100644
> index 98876ea..0000000
> --- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -require ${PN}.inc
> -
> -PR = "${INC_PR}.0"
> -
> -SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
> -SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNNpFzMkyGM64RGpERAoYVAJ400uLWCTfU8OW1cO/i2gQ9ag0p7ACgonK8
KH+P/ckW6/ikyKTL2pOCTW4=
=Rrf1
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] libomxil-bellagio_{0.9.2.1, git}: add patch: remove `-Werror` from `CFLAGS` to fix build with GCC 4.5
  2011-01-18 23:20         ` [PATCH] libomxil-bellagio_{0.9.2.1, git}: add patch: remove `-Werror` from `CFLAGS` to fix build with GCC 4.5 Paul Menzel
@ 2011-01-20 10:14           ` Paul Menzel
  0 siblings, 0 replies; 12+ messages in thread
From: Paul Menzel @ 2011-01-20 10:14 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 5561 bytes --]

Am Mittwoch, den 19.01.2011, 00:20 +0100 schrieb Paul Menzel:
> Date: Mon Jan 17 23:50:33 2011 +0100
> 
> Am Montag, den 17.01.2011, 12:45 +0100 schrieb Paul Menzel:
> > Build tested with `angstrom-2008.1` for `MACHINE = "beagleboard"`. With `angstrom-2010.x` it fails with the following error.
> >
> >         arm-angstrom-linux-gnueabi-libtool: compile:  arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I../.. -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I../../include -I../../src -isystem/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wall -Werror -DCONFIG_DEBUG_LEVEL=0 -MT libomxbase_la-omx_base_component.lo -MD -MP -MF .deps/libomxbase_la-omx_base_component.Tpo -c omx_base_component.c  -fPIC -DPIC -o .libs/libomxbase_la-omx_base_component.o
> >         cc1: warnings being treated as errors
> >         omx_base_component.c: In function 'omx_base_component_GetParameter':
> >         omx_base_component.c:991:3: error: case value '2130706435' not in enumerated type 'OMX_INDEXTYPE'
> >         omx_base_component.c:918:3: error: case value '2130706436' not in enumerated type 'OMX_INDEXTYPE'
> >         make[3]: *** [libomxbase_la-omx_base_component.lo] Error 1
> >         make[3]: Leaving directory `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libomxil-bellagio-0.9.2.1+gitr0+772f0eca88b242ffb5469e8e381c63ce1f7cd3e1-r7.0/git/src/base'
> 
> Upstream advised to remove `-Werror` and is looking into it [1]. OpenBricks is applying the same patch [2].
> 
> A similar patch would make 0.9.2 compile, but this one here does not apply there (`CFLAGS="${CFLAGS} -Werror"` instead of `CFLAGS="${CFLAGS} -Wall -Werror"`).
> 
> [1] http://sourceforge.net/mailarchive/message.php?msg_id=26911808
> [2] http://hg.openbricks.org/openbricks/rev/4f4ed3a596f2
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>

Please commit as I do not have commit access.


Thanks,

Paul

> ---
>  ...01-configure.ac-remove-Werror-from-CFLAGS.patch |   32 ++++++++++++++++++++
>  recipes/openmax/libomxil-bellagio_0.9.2.1.bb       |    4 ++
>  recipes/openmax/libomxil-bellagio_git.bb           |    3 ++
>  3 files changed, 39 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch
> 
> diff --git a/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch b/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch
> new file mode 100644
> index 0000000..1df2b26
> --- /dev/null
> +++ b/recipes/openmax/libomxil-bellagio/0001-configure.ac-remove-Werror-from-CFLAGS.patch
> @@ -0,0 +1,32 @@
> +From 85a2b9666ba2b65920f4ad0e2216405dc14340d4 Mon Sep 17 00:00:00 2001
> +From: Paul Menzel <paulepanter@users.sourceforge.net>
> +Date: Mon, 17 Jan 2011 23:35:18 +0100
> +Subject: [PATCH] configure.ac: remove `-Werror` from `CFLAGS`
> +
> +These options should be set when compiling the program and passed by an environment variable. Or there should be an option to turn these restrictive options off.
> +
> +Currently the build fails at least with GCC 4.5. It is known to work with GCC 4.3.3 [1].
> +
> +[1] http://sourceforge.net/mailarchive/message.php?msg_id=26911808
> +
> +Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> +---
> + configure.ac |    2 +-
> + 1 files changed, 1 insertions(+), 1 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index d6e0bc9..fb5c8c8 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -5,7 +5,7 @@ AM_INIT_AUTOMAKE()
> + AC_PREREQ([2.59])
> + 
> + AC_CONFIG_HEADERS([config.h])
> +-CFLAGS="${CFLAGS} -Wall -Werror"
> ++CFLAGS="${CFLAGS} -Wall"
> + 
> + ################################################################################
> + # Set the shared versioning info, according to section 6.3 of the libtool info #
> +-- 
> +1.7.2.3
> +
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
> index f21c731..89f521a 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.2.1.bb
> @@ -2,5 +2,9 @@ require ${PN}.inc
>  
>  PR = "${INC_PR}.0"
>  
> +SRC_URI += " \
> +	file://0001-configure.ac-remove-Werror-from-CFLAGS.patch \
> +"
> +
>  SRC_URI[md5sum] = "323049db668ab260870fd7ecd2ec4156"
>  SRC_URI[sha256sum] = "75cf8d3b5cac2764420ae2cc7846b9bb12a47d2ca04c96e5821309b0124ddc72"
> diff --git a/recipes/openmax/libomxil-bellagio_git.bb b/recipes/openmax/libomxil-bellagio_git.bb
> index 4e28251..f58adf4 100644
> --- a/recipes/openmax/libomxil-bellagio_git.bb
> +++ b/recipes/openmax/libomxil-bellagio_git.bb
> @@ -4,6 +4,9 @@ PR = "${INC_PR}.0"
>  
>  SRCREV = "772f0eca88b242ffb5469e8e381c63ce1f7cd3e1"
>  SRC_URI = "git://omxil.git.sourceforge.net/gitroot/omxil/omxil;protocol=git"
> +SRC_URI += " \
> +	file://0001-configure.ac-remove-Werror-from-CFLAGS.patch \
> +"
>  PV = "0.9.2.1"
>  PR = "${INC_PR}.0"
>  PR_append = "+gitr${SRCPV}"
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-01-20 10:15 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-16 23:32 [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Paul Menzel
2011-01-16 23:36 ` [PATCH 2/3] libomxil-bellagio: create and use recipe include file (INC file) Paul Menzel
2011-01-16 23:43   ` [PATCH 3/3] libomxil-bellagio_git: add Git version Paul Menzel
2011-01-17  8:13     ` Koen Kooi
2011-01-17 11:45       ` [PATCH 3/3 v2] " Paul Menzel
2011-01-18 23:20         ` [PATCH] libomxil-bellagio_{0.9.2.1, git}: add patch: remove `-Werror` from `CFLAGS` to fix build with GCC 4.5 Paul Menzel
2011-01-20 10:14           ` Paul Menzel
2011-01-17  8:14 ` [PATCH 1/3] libomxil-bellagio: cosmetics: unify recipes Koen Kooi
2011-01-17 11:48   ` Paul Menzel
2011-01-17 13:08     ` Koen Kooi
2011-01-18 23:31       ` [PATCH] libomxil-bellagio: remove/delete unused versions 0.9.{0, 1, 2} Paul Menzel
2011-01-19  7:23         ` Koen Kooi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.