* [PATCH 2/2] Allow distcheck to work without bluetooth
@ 2011-01-19 10:31 =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 13:20 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont @ 2011-01-19 10:31 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
---
Makefile.am | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index c1c34ca..e93076a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
+if !BLUETOOTH
+DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
+endif
MAINTAINERCLEANFILES = Makefile.in \
aclocal.m4 configure config.h.in config.sub config.guess \
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-19 10:31 [PATCH 2/2] Allow distcheck to work without bluetooth =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
@ 2011-01-19 13:20 ` Marcel Holtmann
2011-01-19 13:29 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
0 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2011-01-19 13:20 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
Hi Remi,
> diff --git a/Makefile.am b/Makefile.am
> index c1c34ca..e93076a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
>
>
> DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> +if !BLUETOOTH
> +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> +endif
this patch makes no sense to me. I am not going to apply it. Using make
distcheck works nicely on my system where I build the releases.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-19 13:20 ` Marcel Holtmann
@ 2011-01-19 13:29 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 14:36 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont @ 2011-01-19 13:29 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Wednesday 19 January 2011 15:20:58 ext Marcel Holtmann, you wrote:
> > diff --git a/Makefile.am b/Makefile.am
> > index c1c34ca..e93076a 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
> >
> > DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> >
> > +if !BLUETOOTH
> > +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> > +endif
>
> this patch makes no sense to me. I am not going to apply it. Using make
> distcheck works nicely on my system where I build the releases.
I am not trying to steal your release privilege. I am trying to be able to
test my changes to Makefiles or whatever.
--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-19 13:29 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
@ 2011-01-19 14:36 ` Marcel Holtmann
2011-01-20 8:25 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
0 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2011-01-19 14:36 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Hi Remi,
> > > diff --git a/Makefile.am b/Makefile.am
> > > index c1c34ca..e93076a 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
> > >
> > > DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> > >
> > > +if !BLUETOOTH
> > > +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> > > +endif
> >
> > this patch makes no sense to me. I am not going to apply it. Using make
> > distcheck works nicely on my system where I build the releases.
>
> I am not trying to steal your release privilege. I am trying to be able to
> test my changes to Makefiles or whatever.
you could just install libbluetooth and this would be fine. I like to
run make distcheck with everything enabled all the time. That is the
only way to ensure that it does build properly.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-19 14:36 ` Marcel Holtmann
@ 2011-01-20 8:25 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-20 9:31 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont @ 2011-01-20 8:25 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Wednesday 19 January 2011 16:36:08 ext Marcel Holtmann, you wrote:
> Hi Remi,
>
> > > > diff --git a/Makefile.am b/Makefile.am
> > > > index c1c34ca..e93076a 100644
> > > > --- a/Makefile.am
> > > > +++ b/Makefile.am
> > > > @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
> > > >
> > > > DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> > > >
> > > > +if !BLUETOOTH
> > > > +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> > > > +endif
> > >
> > > this patch makes no sense to me. I am not going to apply it. Using make
> > > distcheck works nicely on my system where I build the releases.
> >
> > I am not trying to steal your release privilege. I am trying to be able
> > to test my changes to Makefiles or whatever.
>
> you could just install libbluetooth and this would be fine. I like to
> run make distcheck with everything enabled all the time. That is the
> only way to ensure that it does build properly.
Fair enough, but does disabling data files not defeat the purpose?
--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-20 8:25 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
@ 2011-01-20 9:31 ` Marcel Holtmann
2011-01-20 9:52 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
0 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2011-01-20 9:31 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
Hi Remi,
> > > > > diff --git a/Makefile.am b/Makefile.am
> > > > > index c1c34ca..e93076a 100644
> > > > > --- a/Makefile.am
> > > > > +++ b/Makefile.am
> > > > > @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
> > > > >
> > > > > DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> > > > >
> > > > > +if !BLUETOOTH
> > > > > +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> > > > > +endif
> > > >
> > > > this patch makes no sense to me. I am not going to apply it. Using make
> > > > distcheck works nicely on my system where I build the releases.
> > >
> > > I am not trying to steal your release privilege. I am trying to be able
> > > to test my changes to Makefiles or whatever.
> >
> > you could just install libbluetooth and this would be fine. I like to
> > run make distcheck with everything enabled all the time. That is the
> > only way to ensure that it does build properly.
>
> Fair enough, but does disabling data files not defeat the purpose?
these are just configuration files and not code.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Allow distcheck to work without bluetooth
2011-01-20 9:31 ` Marcel Holtmann
@ 2011-01-20 9:52 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
0 siblings, 0 replies; 7+ messages in thread
From: =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont @ 2011-01-20 9:52 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
On Thursday 20 January 2011 11:31:32 ext Marcel Holtmann, you wrote:
> Hi Remi,
>
> > > > > > diff --git a/Makefile.am b/Makefile.am
> > > > > > index c1c34ca..e93076a 100644
> > > > > > --- a/Makefile.am
> > > > > > +++ b/Makefile.am
> > > > > > @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
> > > > > >
> > > > > > DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> > > > > >
> > > > > > +if !BLUETOOTH
> > > > > > +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> > > > > > +endif
> > > > >
> > > > > this patch makes no sense to me. I am not going to apply it. Using
> > > > > make distcheck works nicely on my system where I build the
> > > > > releases.
> > > >
> > > > I am not trying to steal your release privilege. I am trying to be
> > > > able to test my changes to Makefiles or whatever.
> > >
> > > you could just install libbluetooth and this would be fine. I like to
> > > run make distcheck with everything enabled all the time. That is the
> > > only way to ensure that it does build properly.
> >
> > Fair enough, but does disabling data files not defeat the purpose?
>
> these are just configuration files and not code.
Yeah? distcheck is about checking that all *files* are declared properly in the
Makefiles, and installation/uninstallation is clean.
If you merely want to check compilation, check is more than enough.
--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-20 9:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-19 10:31 [PATCH 2/2] Allow distcheck to work without bluetooth =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 13:20 ` Marcel Holtmann
2011-01-19 13:29 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 14:36 ` Marcel Holtmann
2011-01-20 8:25 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-20 9:31 ` Marcel Holtmann
2011-01-20 9:52 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.