From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 0/4] Tegra: Harmony: Add internal speaker support
Date: Thu, 20 Jan 2011 10:04:38 +0000 [thread overview]
Message-ID: <1295517879.3277.1.camel@odin> (raw)
In-Reply-To: <1295470205-26501-1-git-send-email-swarren@nvidia.com>
On Wed, 2011-01-19 at 13:50 -0700, Stephen Warren wrote:
> Harmony has headers on the board for an internal speaker and internal mic.
> This patch series adds various infra-structure, and enables usage of the
> internal speaker.
>
> The patch series includes both changes to code within the ASoC
> subsystem and Tegra subsystem, the latter provided only for context when
> reading the ASoC changes. Would you prefer I separated these so that the
> ASoC maintainers can grab a whole series and apply it, rather than just
> a subset of the patches?
>
> While patch 2 is physically located in the Tegra subsystem, I'd
> consider it part of the ASoC driver. Can such a change be checked into
> the ASoC tree? This new header file will be required to build to ASoC driver
> once the following patches are in. I was considering placing this in
> include/sound, following the example of various codecs, but it doesn't seem
> a good idea to pollute that directory with platform-specific files. The
> current location for the file follows the example of s3c24xx/simtec. Perhaps
> it should be in sound/soc/tegra?
>
> Stephen Warren (4):
> ASoC: WM8903: Expose GPIOs through gpiolib
> ARM: tegra: Add Harmony sound platform data type
> ARM: tegra: Platform data fixes for ASoC driver updates
> ASoC: tegra: Harmony: Support the internal speaker
>
> arch/arm/mach-tegra/board-harmony.c | 31 ++++++
> arch/arm/mach-tegra/gpio-names.h | 2 +
> arch/arm/mach-tegra/include/mach/harmony_audio.h | 19 ++++
> include/sound/wm8903.h | 7 +-
> sound/soc/codecs/wm8903.c | 117 +++++++++++++++++++++-
> sound/soc/tegra/harmony.c | 89 ++++++++++++++--
> 6 files changed, 251 insertions(+), 14 deletions(-)
> create mode 100644 arch/arm/mach-tegra/include/mach/harmony_audio.h
>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-01-20 10:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1295393859-3396-1-git-send-email-swarren@wwwdotorg.org>
[not found] ` <1295393859-3396-2-git-send-email-swarren@wwwdotorg.org>
2011-01-19 0:21 ` [PATCH 1/3] ASoC: WM8903: Add wm8903_set_gpio Mark Brown
2011-01-19 0:25 ` [PATCH 0/3] Tegra: Add internal speaker support Mark Brown
2011-01-19 0:29 ` Stephen Warren
[not found] ` <AANLkTi=m585PZum2NQUOqq1PiqP84LuT-qCruzaO7x7t@mail.gmail.com>
2011-01-19 11:30 ` Mark Brown
2011-01-19 12:47 ` Liam Girdwood
2011-01-19 20:50 ` [PATCH v2 0/4] Tegra: Harmony: " Stephen Warren
2011-01-20 10:04 ` Liam Girdwood [this message]
2011-01-19 20:50 ` [PATCH v2 1/4] ASoC: WM8903: Expose GPIOs through gpiolib Stephen Warren
2011-01-20 11:53 ` Mark Brown
2011-01-20 17:23 ` Stephen Warren
2011-01-20 20:33 ` Mark Brown
2011-01-19 20:50 ` [PATCH v2 2/4] ARM: tegra: Add Harmony sound platform data type Stephen Warren
2011-01-19 20:50 ` [PATCH v2 3/4] ARM: tegra: Platform data fixes for ASoC driver updates Stephen Warren
2011-01-19 20:50 ` [PATCH v2 4/4] ASoC: tegra: Harmony: Support the internal speaker Stephen Warren
2011-01-20 11:58 ` Mark Brown
2011-01-25 20:29 ` Mark Brown
2011-01-26 3:46 ` Stephen Warren
2011-01-26 11:00 ` Mark Brown
2011-01-20 20:52 ` [PATCH v3 0/4] Tegra: Harmony: Add internal speaker support Stephen Warren
2011-01-20 20:52 ` [PATCH v3 1/4] ASoC: WM8903: Expose GPIOs through gpiolib Stephen Warren
2011-01-21 12:05 ` Mark Brown
2011-01-20 20:52 ` [PATCH v3 2/4] ARM: tegra: Add Harmony sound platform data type Stephen Warren
2011-01-21 18:43 ` Colin Cross
2011-01-21 22:35 ` Stephen Warren
2011-01-21 22:41 ` Colin Cross
2011-01-21 23:41 ` Mark Brown
2011-01-21 23:49 ` Stephen Warren
2011-01-22 5:14 ` Olof Johansson
2011-01-22 5:34 ` Stephen Warren
2011-01-22 5:40 ` Olof Johansson
2011-01-20 20:52 ` [PATCH v3 3/4] ARM: tegra: Platform data fixes for ASoC driver updates Stephen Warren
2011-01-20 21:22 ` Mark Brown
2011-01-20 22:15 ` Liam Girdwood
2011-01-21 17:45 ` Stephen Warren
2011-01-21 17:50 ` Mark Brown
2011-01-21 18:06 ` Stephen Warren
2011-01-21 18:11 ` Mark Brown
2011-01-21 18:22 ` Stephen Warren
2011-01-21 18:27 ` Mark Brown
2011-01-21 18:36 ` Stephen Warren
2011-01-21 18:39 ` Mark Brown
2011-01-21 18:51 ` Stephen Warren
2011-01-21 18:57 ` Mark Brown
2011-01-21 22:41 ` Stephen Warren
2011-01-20 20:52 ` [PATCH v3 4/4] ASoC: tegra: Harmony: Support the internal speaker Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295517879.3277.1.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.