* [PATCH] ARM: mxs: acknowledge gpio irq
@ 2011-01-25 15:54 Uwe Kleine-König
2011-01-26 22:09 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2011-01-25 15:54 UTC (permalink / raw)
To: linux-arm-kernel
This fixes a machine hang after a gpio irq triggered.
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
arch/arm/mach-mxs/gpio.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/gpio.c b/arch/arm/mach-mxs/gpio.c
index d7ad7a6..cb0c0e8 100644
--- a/arch/arm/mach-mxs/gpio.c
+++ b/arch/arm/mach-mxs/gpio.c
@@ -139,6 +139,8 @@ static void mxs_gpio_irq_handler(u32 irq, struct irq_desc *desc)
struct mxs_gpio_port *port = (struct mxs_gpio_port *)get_irq_data(irq);
u32 gpio_irq_no_base = port->virtual_irq_start;
+ desc->irq_data.chip->irq_ack(&desc->irq_data);
+
irq_stat = __raw_readl(port->base + PINCTRL_IRQSTAT(port->id)) &
__raw_readl(port->base + PINCTRL_IRQEN(port->id));
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: mxs: acknowledge gpio irq
2011-01-25 15:54 [PATCH] ARM: mxs: acknowledge gpio irq Uwe Kleine-König
@ 2011-01-26 22:09 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2011-01-26 22:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Uwe,
On Tue, Jan 25, 2011 at 04:54:22PM +0100, Uwe Kleine-K?nig wrote:
> This fixes a machine hang after a gpio irq triggered.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-mxs/gpio.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/gpio.c b/arch/arm/mach-mxs/gpio.c
> index d7ad7a6..cb0c0e8 100644
> --- a/arch/arm/mach-mxs/gpio.c
> +++ b/arch/arm/mach-mxs/gpio.c
> @@ -139,6 +139,8 @@ static void mxs_gpio_irq_handler(u32 irq, struct irq_desc *desc)
> struct mxs_gpio_port *port = (struct mxs_gpio_port *)get_irq_data(irq);
> u32 gpio_irq_no_base = port->virtual_irq_start;
>
> + desc->irq_data.chip->irq_ack(&desc->irq_data);
> +
> irq_stat = __raw_readl(port->base + PINCTRL_IRQSTAT(port->id)) &
> __raw_readl(port->base + PINCTRL_IRQEN(port->id));
>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
The implementation were referring to mxc gpio. We are not running
into this problem on mxc?
Regards,
Shawn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-26 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 15:54 [PATCH] ARM: mxs: acknowledge gpio irq Uwe Kleine-König
2011-01-26 22:09 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.