All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: Jouni Malinen <j@w1.fi>,
	linville@tuxdriver.com, ath5k-devel@venema.h4ckr.net,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] ath: Fix WEP hardware encryption
Date: Wed, 26 Jan 2011 09:29:48 +0100	[thread overview]
Message-ID: <1296030588.3635.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201101261138.53169.br1@einfach.org>

On Wed, 2011-01-26 at 11:38 +0900, Bruno Randolf wrote:

> Even without my patch, WEP does not work with multiple vifs. 
> (As far as i understand it, with WEP the lookup is just done based on the key 
> index in the WLAN header field. mac80211 (or is it hostapd?) sets up both keys 
> for both interfaces with a key index of 0, which causes the lookup to go to 
> the same key for both vifs. I guess mac80211 or hostapd would need to be 
> changed to use different key indices for different vif WEP keys, but then of 
> course we can only use 4 different WEP keys in sum, and not 4 different WEP 
> keys per vif. No big deal imho.)

Are you saying software WEP in mac80211 is broken with multiple VIFs? I
find that hard to believe :-)

johannes


  reply	other threads:[~2011-01-26  8:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  4:15 [PATCH 1/6] ath5k: ath5k_setup_channels cleanup and whitespace Bruno Randolf
2011-01-25  4:15 ` [PATCH 2/6] ath5k: Use local variable for capabilities Bruno Randolf
2011-01-25  4:15 ` [PATCH 3/6] ath: Add function to check if 4.9GHz channels are allowed Bruno Randolf
2011-01-25  4:15 ` [PATCH 4/6] ath5k: Enable 802.11j 4.9GHz frequencies Bruno Randolf
2011-01-25  4:15 ` [PATCH 5/6] ath9k: Remove unused IEEE80211_WEP_NKID Bruno Randolf
2011-01-25  4:15 ` [PATCH 6/6] ath: Fix WEP hardware encryption Bruno Randolf
2011-01-25 18:32   ` Jouni Malinen
2011-01-26  2:38     ` Bruno Randolf
2011-01-26  8:29       ` Johannes Berg [this message]
2011-01-26  9:21         ` [ath5k-devel] " Bruno Randolf
2011-01-26  9:23           ` Johannes Berg
2011-01-26  9:37       ` Jouni Malinen
2011-01-26 10:36         ` Bruno Randolf
2011-01-27  5:51           ` Vasanthakumar Thiagarajan
2011-01-27  9:19             ` Bruno Randolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296030588.3635.12.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=br1@einfach.org \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.