From: Coly Li <bosong.ly@taobao.com>
To: linux-kernel@vger.kernel.org
Cc: Coly Li <bosong.ly@taobao.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@suse.de>
Subject: [PATCH 0/6] use BUG_ON correctly
Date: Thu, 27 Jan 2011 02:54:49 +0800 [thread overview]
Message-ID: <1296068095-16988-1-git-send-email-bosong.ly@taobao.com> (raw)
BUG_ON() already uses unlikely() inside its definition if possible,
therefore code should not use BUG_ON() with explicit unlikely()
like BUG_ON(unlikely(...)), an explicit unlikely() doesn't make
things better.
This patch set fixes all incorrect usage of BUG_ON() as the above
line mentioned.
Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <gregkh@suse.de>
---
drivers/dma/iop-adma.c | 6 +++---
drivers/dma/mv_xor.c | 6 +++---
drivers/dma/ppc4xx/adma.c | 8 ++++----
drivers/scsi/scsi_lib.c | 4 ++--
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 14 +++++++-------
mm/nommu.c | 10 +++++-----
6 files changed, 24 insertions(+), 24 deletions(-)
next reply other threads:[~2011-01-26 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 18:54 Coly Li [this message]
2011-01-26 18:54 ` [PATCH 1/6] mm: use BUG_ON correctly in nommu.c Coly Li
2011-01-26 18:54 ` [PATCH 2/6] dma: use BUG_ON correctly in iop-adma.c Coly Li
2011-01-26 18:54 ` [PATCH 3/6] dma: use BUG_ON correctly in mv_xor.c Coly Li
2011-01-26 18:54 ` [PATCH 4/6] dma: use BUG_ON correctly in ppc4xx/adam.c Coly Li
2011-01-26 18:54 ` [PATCH 5/6] wl_cfg80211.c: use BUG_ON correctly Coly Li
2011-01-26 18:54 ` [PATCH 6/6] scsi_lib.c: " Coly Li
-- strict thread matches above, loose matches on Subject: below --
2011-01-26 18:39 [PATCH 0/6] " Coly Li
2011-01-27 2:02 ` Yong Zhang
2011-01-27 6:21 ` Coly Li
2011-01-27 6:07 ` Yong Zhang
2011-01-27 6:38 ` Coly Li
2011-01-27 6:20 ` Yong Zhang
2011-01-27 7:19 ` Coly Li
2011-01-27 7:41 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296068095-16988-1-git-send-email-bosong.ly@taobao.com \
--to=bosong.ly@taobao.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.